Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.12] remove hardcoded width for generate ppl button #1488

Closed
wants to merge 1 commit into from
Closed

[Backport 2.12] remove hardcoded width for generate ppl button #1488

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions public/components/event_analytics/explorer/query_assist/input.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
handleTimeRangePickerRefresh: (availability?: boolean, setSummaryStatus?: boolean) => void;
handleTimePickerChange: (timeRange: string[]) => Promise<void>;
tabId: string;
setNeedsUpdate: any;

Check warning on line 53 in public/components/event_analytics/explorer/query_assist/input.tsx

View workflow job for this annotation

GitHub Actions / Lint 

Unexpected any. Specify a different type
selectedIndex: Array<EuiComboBoxOptionOption<string | number | string[] | undefined>>;
nlqInput: string;
setNlqInput: React.Dispatch<React.SetStateAction<string>>;
Expand Down Expand Up @@ -106,7 +106,7 @@
if (explorerData.total > 0 || summaryData.responseForSummaryStatus === 'failure')
generateSummary();
})();
}, [summaryData.responseForSummaryStatus]);

Check warning on line 109 in public/components/event_analytics/explorer/query_assist/input.tsx

View workflow job for this annotation

GitHub Actions / Lint 

React Hook useEffect has missing dependencies: 'dispatch', 'explorerData.total', 'generateSummary', 'props.nlqInput', and 'props.tabId'. Either include them or remove the dependency array

const [barSelected, setBarSelected] = useState(false);

Expand All @@ -125,7 +125,7 @@
} else if (queryRedux.ollyQueryAssistant.length > 0) {
setAutoRun(true);
}
}, [queryRedux.ollyQueryAssistant]);

Check warning on line 128 in public/components/event_analytics/explorer/query_assist/input.tsx

View workflow job for this annotation

GitHub Actions / Lint 

React Hook useEffect has missing dependencies: 'autoRun' and 'runAndSummarize'. Either include them or remove the dependency array

// hide if not in a tab
if (props.tabId === '') return <>{props.children}</>;
Expand Down Expand Up @@ -345,7 +345,6 @@
iconSide="right"
fill={false}
data-test-subj="query-assist-generate-button"
style={{ width: 160 }}
>
Generate query
</EuiButton>
Expand All @@ -362,7 +361,6 @@
type="submit"
fill={barSelected}
data-test-subj="query-assist-generate-and-run-button"
style={{ width: 175 }}
>
Generate and run
</EuiButton>
Expand Down
Loading