Add workflow to build and install binary to catch run time issues #1467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
derek-ho
requested review from
ps48,
kavithacm,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az,
anirudha,
paulstn and
sumukhswamy
as code owners
This reverts commit c75fe26.
derek-ho
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1467 +/- ##
=======================================
Coverage 57.75% 57.75%
=======================================
Files 367 367
Lines 13825 13825
Branches 3627 3627
=======================================
Hits 7985 7985
Misses 5777 5777
Partials 63 63
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Swiddis
approved these changes
Mar 14, 2024
RyanL1997
approved these changes
Mar 21, 2024
sumukhswamy
approved these changes
Mar 21, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 22, 2024
) * Add binary install workflow Signed-off-by: Derek Ho <dxho@amazon.com> * Fix plugin zip name Signed-off-by: Derek Ho <dxho@amazon.com> * Revert performance now change Signed-off-by: Derek Ho <dxho@amazon.com> * Revert "Revert performance now change" This reverts commit c75fe26. * Bump version and provide suffix Signed-off-by: Derek Ho <dxho@amazon.com> * Revert "Revert "Revert performance now change"" This reverts commit 933e576. * Revert "Revert "Revert "Revert performance now change""" This reverts commit 170122e. * remove security referneces Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> Co-authored-by: Simeon Widdis <sawiddis@gmail.com> (cherry picked from commit 4e1e0e5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
derek-ho
pushed a commit
that referenced
this pull request
Mar 22, 2024
) (#1611) * Add binary install workflow * Fix plugin zip name * Revert performance now change * Revert "Revert performance now change" This reverts commit c75fe26. * Bump version and provide suffix * Revert "Revert "Revert performance now change"" This reverts commit 933e576. * Revert "Revert "Revert "Revert performance now change""" This reverts commit 170122e. * remove security referneces --------- (cherry picked from commit 4e1e0e5) Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Simeon Widdis <sawiddis@gmail.com>
RyanL1997
pushed a commit
to RyanL1997/dashboards-observability
that referenced
this pull request
Apr 18, 2024
…1467) Signed-off-by: Darshit Chanpura <dchanp@amazon.com> Co-authored-by: Ryan Liang <109499885+RyanL1997@users.noreply.github.com> (cherry picked from commit 497c7f157b85d73e6000a7a10a2ad24eb3ba6db8) Co-authored-by: Darshit Chanpura <35282393+DarshitChanpura@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have observed some issues within other plugins of issues being only caught at run time. This is because several things can go wrong during the build process, which may not be caught in a dev setup. This adds a workflow to verify that building and installing into OSD works on every PR.
Related issues:
opensearch-project/security-dashboards-plugin#1709
opensearch-project/security-analytics-dashboards-plugin#875
There was also an issue in this repo that was fixed when we caught a similar issue during release testing. Context is here: #309. Here is a test run proving this PR would have caught that issue during RC testing: https://github.com/opensearch-project/dashboards-observability/actions/runs/8024893403/job/21924379904
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.