-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature][Metrics] Metrics Explorer UX with PromQL and Export Panel - merge to main #1291
Conversation
… updated Export Panel Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good structurally, I think the core refactoring was really beneficial. I have a few more small-scale comments.
.../components/custom_panels/panel_modules/visualization_container/visualization_container.scss
Outdated
Show resolved
Hide resolved
Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com>
Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1291 +/- ##
==========================================
- Coverage 56.32% 55.57% -0.76%
==========================================
Files 327 329 +2
Lines 11944 12081 +137
Branches 2741 2854 +113
==========================================
- Hits 6728 6714 -14
+ Misses 5171 5057 -114
- Partials 45 310 +265
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com>
…s based upon attribute-labels legend list. Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com>
Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com>
Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com>
8f09ab2
to
1f751ee
Compare
Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com>
Local coverage and test complete b/c Gh CI snapshot failures.
|
Bad merge. Rebuilt in another PR. Closing. |
…search-project#1291) Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com> (cherry picked from commit 180f69458a9ebc9c1d3d8661b66326318f98b800)
Metrics Explorer updated with PromQL query for Prometheus Metrics and updated Export Panel
Description
Features :
Issues Resolved
#1084
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.