Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert commits back to after 2.11 release #1231

Merged
merged 25 commits into from
Nov 13, 2023
Merged

Revert commits back to after 2.11 release #1231

merged 25 commits into from
Nov 13, 2023

Conversation

mengweieric
Copy link
Collaborator

@mengweieric mengweieric commented Nov 8, 2023 •
edited
Loading

Description

Revert commits back to after 2.11 release.

Git worklog

git revert -s 4288504c~25..4288504c

Issues Resolved

#1230

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov Codecov
Copy link

codecov bot commented Nov 8, 2023 •
edited
Loading

Codecov Report

Merging #1231 (9dd8818) into 2.11 (4288504) will increase coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             2.11    #1231      +/-   ##
==========================================
+ Coverage   44.09%   44.22%   +0.12%     
==========================================
  Files         329      327       -2     
  Lines       19658    19477     -181     
  Branches     4735     4643      -92     
==========================================
- Hits         8669     8614      -55     
- Misses      10412    10818     +406     
+ Partials      577       45     -532
Flag Coverage Δ
dashboards-observability 44.22% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 102 files with indirect coverage changes

@mengweieric mengweieric force-pushed the force-revert-after-2.11-commits branch from 4387b7c to 928d734 Compare November 8, 2023 21:30
@mengweieric
Revert "Update empty allowed roles to admin only (opensearch-project#…
01e8746 
…1217) (opensearch-project#1220)"

This reverts commit 4288504.

Signed-off-by: Eric <menwe@amazon.com>
@mengweieric
Revert "Increment version to 2.11.1.0 (opensearch-project#1190)"
c2c0899 
This reverts commit ccd5fb8.

Signed-off-by: Eric <menwe@amazon.com>
@mengweieric
Revert "Add S3 integration for Nginx and VPC (opensearch-project#1214) (
a6516ed 
opensearch-project#1216)"

This reverts commit e0a509c.

Signed-off-by: Eric <menwe@amazon.com>
@mengweieric
Revert "disabling inspect and default pattern/timestamp buttons when …
415e73c 
…using async data sources (opensearch-project#1205) (opensearch-project#1212)"

This reverts commit ca5ad02.

Signed-off-by: Eric <menwe@amazon.com>
@mengweieric
Revert "Saved object datasource backward compatibility fixes (opensea…
40d21ab 
…rch-project#1208) (opensearch-project#1210)"

This reverts commit 467a0b3.

Signed-off-by: Eric <menwe@amazon.com>
@mengweieric
Revert "Link integrations from datasources UI (opensearch-project#1203)…
4146047 
… (opensearch-project#1207)"

This reverts commit 8e9fe5e.

Signed-off-by: Eric <menwe@amazon.com>
@mengweieric
Revert "[Explorer] Fixes for cancel button and saved object loading (o…
06bbd29 
…pensearch-project#1197) (opensearch-project#1201)"

This reverts commit f0e7a9d.

Signed-off-by: Eric <menwe@amazon.com>
@mengweieric
Revert "Correct query schema for ELB mview generation (opensearch-pro…
a59a262 
…ject#1196) (opensearch-project#1199)"

This reverts commit 0b7be95.

Signed-off-by: Eric <menwe@amazon.com>
@mengweieric
Revert "[Backport 2.11] Add integrations queries for Flint (opensearc…
f17ce22 
…h-project#1195)"

This reverts commit 97f46ba.

Signed-off-by: Eric <menwe@amazon.com>
@mengweieric
Revert "remove husky pre-commit checks (opensearch-project#1192) (ope…
03ff648 
…nsearch-project#1193)"

This reverts commit 25d52f3.

Signed-off-by: Eric <menwe@amazon.com>
@mengweieric
Revert "Bug fixes for observability count distribution and applicatio…
a44b3e7 
…n analytics (opensearch-project#1187) (opensearch-project#1189)"

This reverts commit e2440d2.

Signed-off-by: Eric <menwe@amazon.com>
@mengweieric
Revert "Support cancellation of async queries (opensearch-project#1177)…
de41cd3 
… (opensearch-project#1186)"

This reverts commit 6b495f3.

Signed-off-by: Eric <menwe@amazon.com>
@mengweieric
Revert "[Explorer] Supports session for s3 direct query (opensearch-p…
2dc32a6 
…roject#1178) (opensearch-project#1183)"

This reverts commit d50047f.

Signed-off-by: Eric <menwe@amazon.com>
@mengweieric
Revert "[Explorer] Modify text in empty prompt (opensearch-project#1172…
46fa996 
…) (opensearch-project#1182)"

This reverts commit 95a60cc.

Signed-off-by: Eric <menwe@amazon.com>
@mengweieric
Revert "[Feature] Match discover look and feel (opensearch-project#1135…
61a3355 
…) (opensearch-project#1179)"

This reverts commit b69801e.

Signed-off-by: Eric <menwe@amazon.com>
@mengweieric
Revert "config panel dark mode fix (opensearch-project#1169) (opensea…
5162627 
…rch-project#1176)"

This reverts commit 34696b3.

Signed-off-by: Eric <menwe@amazon.com>
@mengweieric
Revert "Fix events home table and toast life time (opensearch-project…
b45f2e6 
…#1170)"

This reverts commit a9b36fc.

Signed-off-by: Eric <menwe@amazon.com>
@mengweieric
Revert "Quiet react-dnd draggableId/droppableId warnings. (opensearch…
389fddf 
…-project#1147) (opensearch-project#1166)"

This reverts commit a2f9a00.

Signed-off-by: Eric <menwe@amazon.com>
@mengweieric
Revert "Fix integration labeling to identify S3 integrations (opensea…
ebcd7c0 
…rch-project#1157) (opensearch-project#1164)"

This reverts commit 9de9aea.

Signed-off-by: Eric <menwe@amazon.com>
@mengweieric
Revert "Remove loading progress for integration setup (opensearch-pro…
bec0b26 
…ject#1156) (opensearch-project#1162)"

This reverts commit a08721b.

Signed-off-by: Eric <menwe@amazon.com>
@mengweieric
Revert "Switch from toast to callout for integration set up failures (o…
21f0d58 
…pensearch-project#1155) (opensearch-project#1159)"

This reverts commit e6a474a.

Signed-off-by: Eric <menwe@amazon.com>
@mengweieric
Revert "Disable integration set up button if invalid (opensearch-proj…
5eb606c 
…ect#1152) (opensearch-project#1161)"

This reverts commit 74aae17.

Signed-off-by: Eric <menwe@amazon.com>
@mengweieric
Revert "Update URL of create datasources, fix spacing (opensearch-pro…
e797550 
…ject#1149) (opensearch-project#1154)"

This reverts commit 0b66d83.

Signed-off-by: Eric <menwe@amazon.com>
@mengweieric
Revert "Allow patch on allowedRoles (opensearch-project#1143) (opense…
bc88efb 
…arch-project#1145)"

This reverts commit 0acc0f3.

Signed-off-by: Eric <menwe@amazon.com>
@mengweieric
Revert "fix for explorer data grid not paginating (opensearch-project…
9dd8818 
…#1139) (opensearch-project#1141)"

This reverts commit c5ead50.

Signed-off-by: Eric <menwe@amazon.com>
@mengweieric mengweieric force-pushed the force-revert-after-2.11-commits branch from 928d734 to 9dd8818 Compare November 8, 2023 21:31
Swiddis
Swiddis approved these changes Nov 8, 2023
View reviewed changes
Copy link
Collaborator

@Swiddis Swiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we only revert new features to still get a lot of these fixes in, but will approve in the interest of time

@mengweieric
Copy link
Collaborator Author

mengweieric commented Nov 8, 2023 •
edited
Loading

Ideally we only revert new features to still get a lot of these fixes in, but will approve in the interest of time

yea, it's not easily to figure out as some of the fixes may depend on features in previous commits which also need to be reverted

@mengweieric mengweieric merged commit c170e58 into opensearch-project:2.11 Nov 13, 2023
8 checks passed
@mengweieric mengweieric deleted the force-revert-after-2.11-commits branch February 14, 2024 18:29
RyanL1997 pushed a commit to RyanL1997/dashboards-observability that referenced this pull request Apr 18, 2024
@opensearch-trigger-bot
Update URLs referencing old docs-beta site (opensearch-project#1231) (o…
41b6d37 
…pensearch-project#1330)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuali925 joshuali925 joshuali925 approved these changes

@Swiddis Swiddis Swiddis approved these changes

@YANG-DB YANG-DB YANG-DB approved these changes

@pjfitzgibbons pjfitzgibbons Awaiting requested review from pjfitzgibbons

@ps48 ps48 Awaiting requested review from ps48 ps48 is a code owner

@kavithacm kavithacm Awaiting requested review from kavithacm kavithacm is a code owner

@derek-ho derek-ho Awaiting requested review from derek-ho derek-ho is a code owner

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

@rupal-bq rupal-bq Awaiting requested review from rupal-bq rupal-bq is a code owner

@vamsi-amazon vamsi-amazon Awaiting requested review from vamsi-amazon vamsi-amazon is a code owner

@penghuo penghuo Awaiting requested review from penghuo penghuo is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mengweieric @joshuali925 @Swiddis @YANG-DB