address comments

Signed-off-by: Adam Tackett <tackadam@amazon.com>
opensearch-project · Oct 25, 2024 · f3eb11b · f3eb11b
1 parent d12b5cb
commit f3eb11b
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 9 deletions.
diff --git a/public/components/trace_analytics/components/common/filters/filters.tsx b/public/components/trace_analytics/components/common/filters/filters.tsx
@@ -13,6 +13,7 @@ import {
   EuiIcon,
   EuiPopover,
   EuiPopoverTitle,
+  EuiSpacer,
   EuiTextColor,
 } from '@elastic/eui';
 import React, { useMemo, useState } from 'react';
@@ -225,12 +226,15 @@ export function Filters(props: FiltersOwnProps) {
   const filterComponents = useMemo(() => renderFilters(), [props.filters]);
 
   return props.filters.length > 0 ? (
-    <EuiFlexGroup gutterSize="s" alignItems="center" responsive={false}>
-      {filterComponents}
-      <EuiFlexItem grow={false}>
-        <AddFilterButton />
-      </EuiFlexItem>
-    </EuiFlexGroup>
+    <>
+      <EuiSpacer size="s" />
+      <EuiFlexGroup gutterSize="s" alignItems="center" responsive={false}>
+        {filterComponents}
+        <EuiFlexItem grow={false}>
+          <AddFilterButton />
+        </EuiFlexItem>
+      </EuiFlexGroup>
+    </>
   ) : null;
 }
 

diff --git a/public/components/trace_analytics/components/services/services_content.tsx b/public/components/trace_analytics/components/services/services_content.tsx
@@ -205,7 +205,6 @@ export function ServicesContent(props: ServicesProps) {
               />
             </EuiFlexItem>
           </EuiFlexGroup>
-          {props.filters.length > 0 && <EuiSpacer size="s" />}
           <Filters
             page={page}
             filters={filters}

diff --git a/public/components/trace_analytics/components/traces/traces_content.tsx b/public/components/trace_analytics/components/traces/traces_content.tsx
@@ -252,7 +252,6 @@ export function TracesContent(props: TracesProps) {
               />
             </EuiFlexItem>
           </EuiFlexGroup>
-          {props.filters.length > 0 && <EuiSpacer size="s" />}
           <Filters
             page={page}
             filters={filters}

diff --git a/public/components/trace_analytics/home.tsx b/public/components/trace_analytics/home.tsx
@@ -296,7 +296,7 @@ export const Home = (props: HomeProps) => {
         path: tracesPath + '?datasourceId=' + dataSourceMDSId[0].id,
       });
     } else {
-      location.assign(tracesPath);
+      location.assign(tracesPath + '?datasourceId=' + dataSourceMDSId[0].id);
     }
 
     setTracesTableMode('traces');