[Bug] Traces/Services remove toast message on empty data (#2346) (#2348)

* remove toast message on empty data with early returns * make sure errors on request still trigger toast --------- (cherry picked from commit 5703582) Signed-off-by: Adam Tackett <tackadam@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Adam Tackett <tackadam@amazon.com>
opensearch-project · Feb 5, 2025 · 82730d8 · 82730d8
1 parent 195108e
commit 82730d8
Show file tree

Hide file tree

Showing 2 changed files with 49 additions and 24 deletions.
diff --git a/public/components/trace_analytics/requests/services_request_handler.ts b/public/components/trace_analytics/requests/services_request_handler.ts
@@ -47,6 +47,12 @@ export const handleServicesRequest = async (
         dataSourceMDSId,
         setServiceMap
       );
+
+      if (!serviceObject || Object.keys(serviceObject).length === 0) {
+        setItems([]);
+        return [];
+      }
+
       return Promise.all(
         response.aggregations.service.buckets
           .filter((bucket: any) => serviceObject[bucket.key])
@@ -103,35 +109,39 @@ export const handleServiceMapRequest = async (
     getServiceNodesQuery(mode),
     mode,
     dataSourceMDSId
-  )
-    .then((response) => {
-      response.aggregations.service_name.buckets.map(
-        (bucket: any) =>
-          (map[bucket.key] = {
-            serviceName: bucket.key,
-            id: id++,
-            targetResources: bucket.target_resource.buckets.map((res: any) => res.key),
-            targetServices: [],
-            destServices: [],
-          })
-      );
-      return true;
-    })
-    .catch((error) => {
-      console.error('Error retrieving service nodes:', error);
-      coreRefs.core?.notifications.toasts.addError(error, {
-        title: 'Failed to retrieve service nodes',
-        toastLifeTimeMs: 10000,
-      });
-      return false;
+  ).catch((error) => {
+    console.error('Error retrieving service nodes:', error);
+    coreRefs.core?.notifications.toasts.addError(error, {
+      title: 'Failed to retrieve service nodes',
+      toastLifeTimeMs: 10000,
     });
+    return null;
+  });
 
-  // Early return if service node not found
-  if (!serviceNodesResponse) {
+  if (
+    !serviceNodesResponse ||
+    !serviceNodesResponse.aggregations ||
+    !serviceNodesResponse.aggregations.service_name ||
+    !serviceNodesResponse.aggregations.service_name.buckets ||
+    serviceNodesResponse.aggregations.service_name.buckets.length === 0
+  ) {
+    if (setItems) {
+      setItems(map);
+    }
     return map;
   }
 
-  const targets = {};
+  serviceNodesResponse.aggregations.service_name.buckets.forEach((bucket: any) => {
+    map[bucket.key] = {
+      serviceName: bucket.key,
+      id: id++,
+      targetResources: bucket.target_resource.buckets.map((res: any) => res.key),
+      targetServices: [],
+      destServices: [],
+    };
+  });
+
+  const targets: Record<string, string> = {};
   await handleDslRequest(http, null, getServiceEdgesQuery('target', mode), mode, dataSourceMDSId)
     .then((response) =>
       response.aggregations.service_name.buckets.map((bucket: any) => {

diff --git a/public/components/trace_analytics/requests/traces_request_handler.ts b/public/components/trace_analytics/requests/traces_request_handler.ts
@@ -153,6 +153,21 @@ export const handleTracesRequest = async (
         percentileRangesResult.status === 'fulfilled' ? percentileRangesResult.value : {};
       const response = responseResult.value;
 
+      if ((response.statusCode && response.statusCode >= 400) || response.error) {
+        return Promise.reject(response);
+      }
+
+      if (
+        !response ||
+        !response.aggregations ||
+        !response.aggregations.traces ||
+        !response.aggregations.traces.buckets ||
+        response.aggregations.traces.buckets.length === 0
+      ) {
+        setItems([]);
+        return [];
+      }
+
       return response.aggregations.traces.buckets.map((bucket: any) => {
         if (mode === 'data_prepper' || mode === 'custom_data_prepper') {
           return {