optimize the code

Signed-off-by: yubonluo <yubonluo@amazon.com>
opensearch-project · Oct 22, 2024 · 05893cf · 05893cf
1 parent 6c6bc27
commit 05893cf
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/public/components/overview/home.tsx b/public/components/overview/home.tsx
@@ -52,17 +52,17 @@ export const Home = () => {
   const [isPopoverOpen, setIsPopoverOpen] = useState(false);
   const [showGetStarted, setShowGetStarted] = useState<boolean | null>(null); // Initial null state
 
+  const isCurrentWorkspaceOwner = coreRefs.workspaces?.currentWorkspace$.getValue()?.owner;
+  const isDashboardAdmin =
+    coreRefs.application?.capabilities?.dashboards?.isDashboardAdmin !== false;
   // When workspace enabled, only workspace owner/OSD admin can update observability:defaultDashboard.
   const canUpdateUiSetting = useMemo(() => {
-    if (coreRefs.application?.capabilities?.workspaces?.enabled) {
-      const isCurrentWorkspaceOwner = coreRefs.workspaces?.currentWorkspace$.getValue()?.owner;
-      const isDashboardAdmin =
-        coreRefs.application?.capabilities?.dashboards?.isDashboardAdmin !== false;
+    const capabilities = coreRefs.application?.capabilities;
+    if (capabilities?.workspaces?.enabled) {
       return isCurrentWorkspaceOwner || isDashboardAdmin;
-    } else {
-      return true;
     }
-  }, [coreRefs.workspaces, coreRefs.application?.capabilities]);
+    return true;
+  }, [isCurrentWorkspaceOwner, isDashboardAdmin]);
 
   ObsDashboardStateManager.showFlyout$.next(() => () => setIsFlyoutVisible(true));