-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lock wms crs input to epsg-3857 (issue 600) #632
Conversation
Signed-off-by: Quinn Guerin <qguerin@icr-team.com>
Signed-off-by: Quinn Guerin <qguerin@icr-team.com>
Thanks for sharing the context for maplibre supported projections, like it metioned:
In this case, maybe we remove crs field component on UI and use the fixed constant value of |
@junqiu-lei Per maplibre/maplibre-gl-js#168, there is a very slow push to add support for additional crs types. My thinking was that leaving the wms crs ui field, would make it trivial to re-enable once maplibre adds support. Additionally, it would at least alert users to the fact that they can only use epsg-3857, which could save them a headache since some legacy sources do not support epsg-3857. |
Since it's related to UX change, @canascar @kgcreative do you have any suggestion input here? |
Signed-off-by: Heemin Kim <heemin@amazon.com>
* locked custom wms crs input to epsg-2857 Signed-off-by: Quinn Guerin <qguerin@icr-team.com> * updated changelog Signed-off-by: Quinn Guerin <qguerin@icr-team.com> --------- Signed-off-by: Quinn Guerin <qguerin@icr-team.com> Signed-off-by: Heemin Kim <heemin@amazon.com> Co-authored-by: Quinn Guerin <qguerin@icr-team.com> Co-authored-by: Heemin Kim <heemin@amazon.com> (cherry picked from commit 8c7a4ca)
* locked custom wms crs input to epsg-2857 Signed-off-by: Quinn Guerin <qguerin@icr-team.com> * updated changelog Signed-off-by: Quinn Guerin <qguerin@icr-team.com> --------- Signed-off-by: Quinn Guerin <qguerin@icr-team.com> Signed-off-by: Heemin Kim <heemin@amazon.com> Co-authored-by: Quinn Guerin <qguerin@icr-team.com> Co-authored-by: Heemin Kim <heemin@amazon.com> (cherry picked from commit 8c7a4ca) Co-authored-by: Quinn <10715168+qugu2427@users.noreply.github.com>
Description
Disable the custom wms crs input and set it to a constant value of
EPSG:3857
.Currently, users are able to input a different crs into the curstom wms field. The problem is that maplibre only allows epsg-3857 (see #600 (comment)), thus inputting any other value creates an incorrect bbox which essentially ruins the whole map.
Though this is not a perfect 'fix', it does prevent these bbox errors from occuring. Additionally, most map servers will allow epsg-3857 as a source.
Issues Resolved
#600
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.