Support multi data source in region map #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junqiu-lei
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda and
martin-gaievski
as code owners
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
junqiu-lei
force-pushed
the
region-map-1
branch
from
fcf31ea
to
1b28e3a
Compare
BionIT
approved these changes
Apr 26, 2024
|
CI failure is unrelated to this PR, local test passed. |
naveentatikonda
approved these changes
Apr 26, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 26, 2024
(cherry picked from commit 61d9703)
junqiu-lei
added a commit
that referenced
this pull request
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR add the ability to use multi data source in region map for the custom import map feature upload api.
Test will be added in functional test repo where has remote cluster mock resources.
This PR contains API updates for:
Meanwhile another related PR in OSD: opensearch-project/OpenSearch-Dashboards#6654 is merged
Demo
Screen.Recording.2024-04-26.at.8.14.06.AM.mov
Issues Resolved
Part of #584
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.