-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow to verify binary installation #591
Conversation
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Seems like there is an issue with a recent dependency OSD core added. Created a follow up issue: opensearch-project/OpenSearch-Dashboards#5953. @ryanbogan can you follow up here and help take this PR to completion? Thanks! |
@@ -106,7 +106,7 @@ jobs: | |||
- name: Bootstrap plugin | |||
run: | | |||
cd OpenSearch-Dashboards/plugins/dashboards-maps | |||
yarn osd bootstrap | |||
yarn osd bootstrap --single-version=loose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More context here: opensearch-project/OpenSearch-Dashboards#5561
Signed-off-by: Derek Ho <dxho@amazon.com>
…into binary-install
|
||
- name: Health check | ||
run: | | ||
timeout 300 bash -c 'while [[ "$(curl http://localhost:5601/api/status | jq -r '.status.overall.state')" != "green" ]]; do sleep 5; done' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is 300 seconds enough timeout based on previous experience?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea - this is the OSD binary/not a dev setup, so we don't need to wait for the bundles to compile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This run the health check was successful almost right away: https://github.com/opensearch-project/dashboards-maps/actions/runs/8912664392/job/24476554624?pr=591
(cherry picked from commit d6d19bc)
Description
I have observed some issues within other plugins of issues being only caught at run time. This is because several things can go wrong during the build process, which may not be caught in a dev setup. This adds a workflow to verify that building and installing into OSD works on every PR.
Related issues:
opensearch-project/security-dashboards-plugin#1709
opensearch-project/security-analytics-dashboards-plugin#875
opensearch-project/dashboards-observability#309
opensearch-project/OpenSearch-Dashboards#5952
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.