[Backport 2.x] Fix broken build and failing tests #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #574 +/- ##
=======================================
Coverage 41.36% 41.36%
=======================================
Files 53 53
Lines 1789 1789
Branches 330 328 -2
=======================================
Hits 740 740
Misses 1019 1019
Partials 30 30 ☔ View full report in Codecov by Sentry. |
ryanbogan
changed the title
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
ryanbogan
changed the title
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
ryanbogan
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei and
martin-gaievski
as code owners
junqiu-lei
approved these changes
Jan 24, 2024
heemin32
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the broken build due to a change in babel.
Fixes unit tests by updating expected snapshot that changed due to upstream changes.
Fixes integration test by adding wait before selecting colors.
Changes Cypress test browser to electron in the CI, because the latest version chrome browser used higher memory/CPU which causes the workflow to fail
Backport of #572
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.