Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move maps entrypoint under plugins #196

Merged
merged 2 commits into from
Jan 10, 2023

Conversation

junqiu-lei
Copy link
Member

@junqiu-lei junqiu-lei commented Jan 10, 2023

Signed-off-by: Junqiu Lei junqiu@amazon.com

Description

Move maps entrypoint under plugins. Finally It will be at above notifications, below anomaly detection plugin.

image

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Junqiu Lei <junqiu@amazon.com>
@kgcreative
Copy link
Member

LGTM. Please place this above notifications, below anomaly detection

Signed-off-by: Junqiu Lei <junqiu@amazon.com>
@junqiu-lei
Copy link
Member Author

LGTM. Please place this above notifications, below anomaly detection

Thank you @kgcreative for the confirmation, just updated the code.

@codecov-commenter
Copy link

Codecov Report

Merging #196 (e5370b6) into main (19b4761) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #196   +/-   ##
=======================================
  Coverage   87.64%   87.64%           
=======================================
  Files           6        6           
  Lines         178      178           
  Branches       24       24           
=======================================
  Hits          156      156           
  Misses         16       16           
  Partials        6        6           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@junqiu-lei junqiu-lei merged commit c06a8ef into opensearch-project:main Jan 10, 2023
@junqiu-lei junqiu-lei deleted the move_maps_entrypoint branch January 10, 2023 23:00
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 10, 2023
* Move maps entrypoint under plugins

Signed-off-by: Junqiu Lei <junqiu@amazon.com>
(cherry picked from commit c06a8ef)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 10, 2023
* Move maps entrypoint under plugins

Signed-off-by: Junqiu Lei <junqiu@amazon.com>
(cherry picked from commit c06a8ef)
junqiu-lei added a commit that referenced this pull request Jan 10, 2023
* Move maps entrypoint under plugins

Signed-off-by: Junqiu Lei <junqiu@amazon.com>
(cherry picked from commit c06a8ef)

Co-authored-by: Junqiu Lei <junqiu@amazon.com>
junqiu-lei added a commit that referenced this pull request Jan 10, 2023
* Move maps entrypoint under plugins

Signed-off-by: Junqiu Lei <junqiu@amazon.com>
(cherry picked from commit c06a8ef)

Co-authored-by: Junqiu Lei <junqiu@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants