Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve and simplify processor form configs #339

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

ohltyler
Copy link
Member

@ohltyler ohltyler commented Sep 3, 2024

Description

PR to clean up and simplify some of the forms for configuring processors, and some other minor improvements. Specifically:

  • wraps the processor forms in an accordion. They are all set to be closed by default, except when adding a new one inline, in which case defaults to being open to have less friction for starting to edit/config the newly added processor
  • passes model interface instead of the derived model inputs/outputs as much to simplify the amount of state components, and set it up for downstream validation (to be added in a later PR)
  • adds parsing logic in QuickConfigureModal to derive default key/value pairs in the input / output maps based on any model interface, if applicable. Adds flexibility and default support for multiple input/output fields, compared to 1, before.
  • simplifies logic in SelectWithCustomOptions to just pull displayed values based on the form input, instead of adhoc form manipulation which caused bugs in certain scenarios
  • makes the selector in the input/output map forms compressed and realigns some of the components that needed adjusted after Use smaller and compressed variants of buttons and form components #336
  • handles an edge case of no existing workflows on the details page

Demo video, showing:

  • processors wrapped in accordion
  • bug fixed to allow custom inputs in the input map / output map
  • compressed view and form alignment
screen-capture.9.webm

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
…odals;

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
@ohltyler ohltyler merged commit 0f565a6 into opensearch-project:main Sep 4, 2024
13 checks passed
@ohltyler ohltyler deleted the usability-7 branch September 4, 2024 01:52
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 4, 2024
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
(cherry picked from commit 0f565a6)
ohltyler added a commit that referenced this pull request Sep 4, 2024
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
(cherry picked from commit 0f565a6)

Co-authored-by: Tyler Ohlsen <ohltyler@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants