-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessors for custom compression modes #89
Accessors for custom compression modes #89
Conversation
b2009fa
to
07d42d8
Compare
@reta please take a look! Thank you :D |
@sarthakaggarwal97 sure, what is the practical reason of exposing these properties? |
@reta I'm working on a plugin which requires me to have my own implementation of the Lucene90CompressingStoredFieldsFormat to optimize on read operations. |
@sarthakaggarwal97 There are few issues here:
|
7cb4065
to
d77955a
Compare
@reta yes, if we want to just fetch the compression mode, we should use the API you suggested. |
src/main/java/org/opensearch/index/codec/customcodecs/Lucene95CustomStoredFieldsFormat.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/index/codec/customcodecs/Lucene95CustomStoredFieldsFormat.java
Outdated
Show resolved
Hide resolved
1b5d4f3
to
403f3af
Compare
src/main/java/org/opensearch/index/codec/customcodecs/Lucene95CustomStoredFieldsFormat.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/index/codec/customcodecs/Lucene95CustomStoredFieldsFormat.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/index/codec/customcodecs/Lucene95CustomStoredFieldsFormat.java
Show resolved
Hide resolved
403f3af
to
f950364
Compare
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
f950364
to
8b51cf6
Compare
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> (cherry picked from commit 804fe11) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 804fe11) Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Enables accessors for custom compression modes.
Issues Resolved
#88
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.