Add support of secure OpenSearch clusters in integration tests #50
Conversation
| throw new RuntimeException("user name is missing"); | ||
| } | ||
|
|
||
| final String password = System.getProperty("password"); |
There was a problem hiding this comment.
Maybe a non issue here since this is a simple test but my senses tingle when I see a password that doesn't use the closeable SecureString in a try-with-resources. I'm not sure there's a way to avoid returning the property as a String instead of char[] anyway so the String object allocation is likely unavoidable.
There was a problem hiding this comment.
Thanks @nknize , this is sadly platform wide issue since the password is passed from CI to the tests (for all core and all pugins) using environment variables [1].
[1] https://github.com/opensearch-project/opensearch-build/blob/main/scripts/default/integtest.sh#L98
There was a problem hiding this comment.
In a separate PR we should work to change that to use the KeyStore.
There was a problem hiding this comment.
👍 no objection, could you please open an issue https://github.com/opensearch-project/opensearch-build here, I will provide more details if needed, thank you
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
reta
force-pushed
the
add.secure.support
branch
from
3c45c46
to
cb19825
Compare
Signed-off-by: Andriy Redko <andriy.redko@aiven.io> (cherry picked from commit c0aa957) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Andriy Redko <andriy.redko@aiven.io> (cherry picked from commit c0aa957) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Andriy Redko <andriy.redko@aiven.io> (cherry picked from commit c0aa957) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Andriy Redko <andriy.redko@aiven.io> (cherry picked from commit c0aa957) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Description
Add support of secure OpenSearch clusters in integration tests
Issues Resolved
Closes #49
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.