-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add local staging maven jars publishing and add custom build.sh #27
Add local staging maven jars publishing and add custom build.sh #27
Conversation
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
|
@peterzhuamazon thanks but why we need Jenkins since we have GH workflow for it (that all other repos use)? We will need to copy/paste the script all over the place :( |
This is release maven even though the name says staging local. Also waiting for this from you to get merged beforehand: Thanks. |
Got the answer, this is the release workflows |
Please hold on till #26 gets in to have the right articfat names |
@@ -43,7 +42,7 @@ repositories { | |||
} | |||
|
|||
allprojects { | |||
group 'org.opensearch.plugin' | |||
group 'org.opensearch' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be under plugin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, it should be non-plugin for all project, and plugin for only the plugin zip.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait a sec, for plugins we publish -client
artifacts and they are all under org.opensearch.plugin
, for example:
https://mvnrepository.com/artifact/org.opensearch.plugin/ingest-attachment/2.9.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For info, looked with @peterzhuamazon : for non-core plugins, JAR artifacts go under org.opensearch
but ZIP artifacts go under org.opensearch.plugin
. For core plugins, everything goes under org.opensearch.plugin
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> (cherry picked from commit 888cf7b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> (cherry picked from commit 888cf7b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 888cf7b) Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 888cf7b) Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Add local staging maven jars publishing and add custom build.sh
Issues Resolved
opensearch-project/opensearch-build#3743
opensearch-project/opensearch-build#3971
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.