Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increment replication plugin version to 2.0 #348

Merged

Conversation

saikaranam-amazon
Copy link
Member

@saikaranam-amazon saikaranam-amazon commented Apr 4, 2022

Signed-off-by: Sai Kumar karanas@amazon.com

Description

Increment replication plugin version to 2.0

Issues Resolved

#312

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@saikaranam-amazon saikaranam-amazon requested a review from a team April 4, 2022 18:21
@saikaranam-amazon
Copy link
Member Author

saikaranam-amazon commented Apr 4, 2022

Ignore security plugin test failures as (security plugin's) main branch is tracking OS 1.4.0

@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2022

Codecov Report

Merging #348 (49fddb8) into main (ecd95b2) will decrease coverage by 61.65%.
The diff coverage is 0.00%.

❗ Current head 49fddb8 differs from pull request most recent head 15074b7. Consider uploading reports for the commit 15074b7 to get more accurate results

@@              Coverage Diff              @@
##               main     #348       +/-   ##
=============================================
- Coverage     72.55%   10.90%   -61.66%     
+ Complexity      907      111      -796     
=============================================
  Files           139      141        +2     
  Lines          4453     4559      +106     
  Branches        525      506       -19     
=============================================
- Hits           3231      497     -2734     
- Misses          906     3991     +3085     
+ Partials        316       71      -245     
Impacted Files Coverage Δ
...tion/action/replay/TransportReplayChangesAction.kt 0.00% <0.00%> (-78.66%) ⬇️
...lication/metadata/TransportUpdateMetadataAction.kt 0.00% <0.00%> (-71.82%) ⬇️
...ication/metadata/store/ReplicationMetadataStore.kt 24.44% <0.00%> (-42.97%) ⬇️
...on/repository/RemoteClusterRestoreLeaderService.kt 0.00% <0.00%> (-77.78%) ⬇️
.../replication/seqno/RemoteClusterTranslogService.kt 0.00% <0.00%> (-90.48%) ⬇️
...ch/replication/task/CrossClusterReplicationTask.kt 15.58% <ø> (-68.63%) ⬇️
...lin/org/opensearch/replication/util/Injectables.kt 0.00% <0.00%> (-100.00%) ⬇️
.../opensearch/replication/rest/LeaderStatsHandler.kt 0.00% <0.00%> (-100.00%) ⬇️
.../opensearch/replication/rest/UpdateIndexHandler.kt 0.00% <0.00%> (-100.00%) ⬇️
...opensearch/replication/seqno/RemoteClusterStats.kt 0.00% <0.00%> (-100.00%) ⬇️
... and 131 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecd95b2...15074b7. Read the comment docs.

naveenpajjuri
naveenpajjuri previously approved these changes Apr 5, 2022
Signed-off-by: Sai Kumar <karanas@amazon.com>
@@ -434,20 +434,6 @@ integTest {
}
}

doLast {
for (int port=startJmxPort; port<endJmxPort; port++) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix this in a followup PR

@saikaranam-amazon saikaranam-amazon merged commit 01acfec into opensearch-project:main Apr 5, 2022
@naveenpajjuri naveenpajjuri mentioned this pull request Apr 5, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants