Added validations for indexPattern in autofollow API

[skumarp7]

Description

This PR adds validations for the indexPattern configured in autofollow API

Existing behavior of the autofollow API with invalid indexPattern:

  curl -Method POST -Uri "http://localhost:9201/_plugins/_replication/_autofollow?pretty"  -H @{'Content-Typ
e' = 'application/json'} -body '{"leader_alias":"leader", "name": "test", "pattern": "test/abcd"}'                   


StatusCode        : 200
StatusDescription : OK
Content           : {
                      "acknowledged" : true
                    }

Behaviour after adding validations on indexPattern:

curl -Method POST -Uri "http://localhost:9201/_plugins/_replication/_autofollow?pretty"  -H @{'Content-Typ
e' = 'application/json'} -body '{"leader_alias":"leader_sanjay", "name": "test", "pattern": "test/adfas"}'

curl : { "error" : { "root_cause" : [ { "type" : "action_request_validation_exception", "reason" : "Validation Failed: 1: Autofollow pattern: 
test/adfas must not contain the following characters [ , \", *, \\, <, |, ,, >, /, ?];" } ], "type" : "action_request_validation_exception", 
"reason" : "Validation Failed: 1: Autofollow pattern: test/adfas must not contain the following characters [ , \", *, \\, <, |, ,, >, /, ?];" },    
"status" : 400 }

Issues Resolved

#1034

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[skumarp7]

Hi All,

Please let me know if the above made changes are good to go. Feedback is much appreciated :)

[skumarp7]

Hi @monusingh-1 , Any update ?

[ankitkala]

Thanks for taking out the time to contribute this fix @skumarp7

Have few minor comments on the PR. Rest LGTM.

[ankitkala]

Let's name this as validateAutofollowPattern.

[skumarp7]

Done

[ankitkala]

To ensure we're not regressing, Can you please add the tests for various valid patterns as well?

[skumarp7]

Done

[ankitkala]

The characters in the pattern doesn't have to a valid filename right? Wanted to understand the how you arrived at this criteria.

[skumarp7]

I have tried to adapt similar validations done in opensearch on indexPatterns at index template level where the index Pattern must not contain invalid filename characters.

reference: https://github.com/opensearch-project/OpenSearch/blob/main/server/src/main/java/org/opensearch/cluster/metadata/MetadataIndexTemplateService.java

[monusingh-1]

Enabled approval workflow

[ankitkala]

Thanks for

[monusingh-1]

Security tests have started to fail, investigating