Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.0] Handling OpenSearchRejectExecuteException Exception (#1004) #1024

Conversation

sricharanvuppu
Copy link
Member

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

sricharanvuppu and others added 2 commits June 28, 2023 16:10
…ct#1004)

* Handling OpenSearchRejectExecuteException Exception
* introduced writersPerShard setting.

Signed-off-by: sricharanvuppu <srivuppu@amazon.com>
(cherry picked from commit 448e7a7)
Signed-off-by: sricharanvuppu <srivuppu@amazon.com>
Signed-off-by: sricharanvuppu <srivuppu@amazon.com>
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #1024 (0e6dbd8) into 2.0 (325852f) will increase coverage by 6.45%.
Report is 1 commits behind head on 2.0.
The diff coverage is 68.57%.

❗ Current head 0e6dbd8 differs from pull request most recent head 7aa6fde. Consider uploading reports for the commit 7aa6fde to get more accurate results

@@             Coverage Diff              @@
##                2.0    #1024      +/-   ##
============================================
+ Coverage     70.21%   76.67%   +6.45%     
- Complexity      959     1041      +82     
============================================
  Files           141      141              
  Lines          4674     4707      +33     
  Branches        519      525       +6     
============================================
+ Hits           3282     3609     +327     
+ Misses         1063      765     -298     
- Partials        329      333       +4     
Files Coverage Δ
...in/org/opensearch/replication/ReplicationPlugin.kt 91.78% <100.00%> (+0.87%) ⬆️
.../org/opensearch/replication/ReplicationSettings.kt 100.00% <100.00%> (ø)
...on/resume/TransportResumeIndexReplicationAction.kt 86.95% <100.00%> (+1.04%) ⬆️
...ication/seqno/RemoteClusterRetentionLeaseHelper.kt 72.44% <100.00%> (ø)
...rch/replication/task/shard/ShardReplicationTask.kt 75.18% <100.00%> (ø)
...org/opensearch/replication/ReplicationException.kt 11.11% <20.00%> (-3.18%) ⬇️
...tlin/org/opensearch/replication/util/Extensions.kt 68.13% <58.33%> (-2.11%) ⬇️
...search/replication/task/shard/TranslogSequencer.kt 78.46% <66.66%> (-7.91%) ⬇️

... and 37 files with indirect coverage changes

monusingh-1
monusingh-1 previously approved these changes Jul 6, 2023
var highWatermark = initialSeqNo
for (m in channel) {
rateLimiter.acquire()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move it to before the while statement

Signed-off-by: sricharanvuppu <srivuppu@amazon.com>
@monusingh-1 monusingh-1 merged commit f08f6a6 into opensearch-project:2.0 Oct 4, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants