Updates sample cert and admin keystore #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
DarshitChanpura
requested review from
lezzago,
qreshi,
bowenlan-amzn,
rishabhmaurya,
getsaurabh02,
eirsep,
sbcd90,
AWSHurneyt and
engechas
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #598 +/- ##
============================================
- Coverage 73.98% 73.96% -0.02%
Complexity 892 892
============================================
Files 133 133
Lines 5865 5865
Branches 716 716
============================================
- Hits 4339 4338 -1
Misses 1215 1215
- Partials 311 312 +1 ☔ View full report in Codecov by Sentry. |
bowenlan-amzn
approved these changes
Feb 20, 2024
|
should be merged post opensearch-project/security#4061 is merged |
|
Hello reviewers, This could be potential reason for failing tests with security atleast at the distribution level for 2.13.0. Thanks! |
engechas
approved these changes
Apr 10, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 10, 2024
Signed-off-by: Darshit Chanpura <dchanp@amazon.com> (cherry picked from commit c05715b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt
pushed a commit
that referenced
this pull request
Jan 27, 2025
(cherry picked from commit c05715b) Signed-off-by: Darshit Chanpura <dchanp@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Downstream change coming from security plugin: opensearch-project/security#4061
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.