Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Backport 2.x) support list of monitor ids in Chained Monitor Findings (#514) #515

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

eirsep
Copy link
Member

@eirsep eirsep commented Sep 1, 2023

support list of monitor ids in Chained Monitor Findings

Creating manual backport PR as backport CI failed due to conflicts

…roject#514)

support list of monitor ids in Chained Monitor Findings

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #515 (6fefb19) into 2.x (e6783b6) will increase coverage by 0.62%.
The diff coverage is 74.46%.

@@             Coverage Diff              @@
##                2.x     #515      +/-   ##
============================================
+ Coverage     72.94%   73.56%   +0.62%     
- Complexity      844      851       +7     
============================================
  Files           130      130              
  Lines          5621     5651      +30     
  Branches        688      696       +8     
============================================
+ Hits           4100     4157      +57     
+ Misses         1216     1187      -29     
- Partials        305      307       +2     
Files Changed Coverage Δ
...h/commons/alerting/model/ChainedMonitorFindings.kt 71.42% <72.00%> (+55.42%) ⬆️
...ch/commons/alerting/action/IndexWorkflowRequest.kt 82.02% <77.27%> (-3.51%) ⬇️

... and 3 files with indirect coverage changes

@eirsep eirsep merged commit 41c9fcf into opensearch-project:2.x Sep 1, 2023
7 of 8 checks passed
AWSHurneyt pushed a commit to AWSHurneyt/common-utils that referenced this pull request Apr 12, 2024
…roject#514) (opensearch-project#515)

support list of monitor ids in Chained Monitor Findings

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants