-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Fix after core #8157 (#486) #499
[Backport 2.x] Fix after core #8157 (#486) #499
Conversation
* Fix after core #8157 Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * Fix ktlint issue Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * Fix spotless java check Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> --------- Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> (cherry picked from commit 003071c) Signed-off-by: Hailong Cui <ihailong@amazon.com>
@@ -9,7 +9,7 @@ buildscript { | |||
opensearch_version = System.getProperty("opensearch.version", "2.10.0-SNAPSHOT") | |||
isSnapshot = "true" == System.getProperty("build.snapshot", "true") | |||
buildVersionQualifier = System.getProperty("build.version_qualifier", "") | |||
kotlin_version = System.getProperty("kotlin.version", "1.6.10") | |||
kotlin_version = System.getProperty("kotlin.version", "1.8.21") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bowenlan-amzn I am not sure we need upgrade this in 2.x branch, can you confirm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this should be fine
Codecov Report
@@ Coverage Diff @@
## 2.x #499 +/- ##
============================================
+ Coverage 72.82% 72.84% +0.01%
+ Complexity 837 835 -2
============================================
Files 129 129
Lines 5587 5586 -1
Branches 683 683
============================================
Hits 4069 4069
+ Misses 1216 1215 -1
Partials 302 302
|
@bowenlan-amzn @AWSHurneyt would you mind do the review for this PR? |
* Fix after core #8157 * Fix ktlint issue * Fix spotless java check --------- (cherry picked from commit 003071c) Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> Signed-off-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: bowenlan-amzn <bowenlan23@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Backport 003071c from #486