Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opensearch commons strings library dependency import #474

Merged
merged 2 commits into from
Jul 6, 2023

Conversation

eirsep
Copy link
Member

@eirsep eirsep commented Jul 6, 2023

fix opensearch commons strings library dependency import

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #474 (3a38316) into 2.x (fca6d8e) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.x     #474      +/-   ##
============================================
- Coverage     71.31%   71.29%   -0.02%     
  Complexity      792      792              
============================================
  Files           127      127              
  Lines          5355     5355              
  Branches        679      679              
============================================
- Hits           3819     3818       -1     
- Misses         1243     1244       +1     
  Partials        293      293              
Impacted Files Coverage Δ
...in/java/org/opensearch/commons/InjectSecurity.java 71.92% <ø> (ø)
...earch/commons/authuser/AuthUserRequestBuilder.java 0.00% <ø> (ø)
...ain/java/org/opensearch/commons/authuser/User.java 87.82% <ø> (ø)
...commons/destination/message/LegacyBaseMessage.java 67.44% <ø> (ø)
...ommons/destination/message/LegacyChimeMessage.java 89.47% <ø> (ø)
...estination/message/LegacyCustomWebhookMessage.java 74.68% <ø> (ø)
...ommons/destination/message/LegacyEmailMessage.java 89.47% <ø> (ø)
.../commons/destination/message/LegacySNSMessage.java 0.00% <ø> (ø)
...ommons/destination/message/LegacySlackMessage.java 85.71% <ø> (ø)
.../org/opensearch/commons/destination/util/Util.java 0.00% <ø> (ø)
... and 15 more

... and 1 file with indirect coverage changes

@eirsep eirsep changed the title replace isNullOrEmpty() check opensearch commons strings library dependency import Jul 6, 2023
Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
@eirsep eirsep merged commit f475879 into opensearch-project:2.x Jul 6, 2023
7 of 8 checks passed
AWSHurneyt pushed a commit to AWSHurneyt/common-utils that referenced this pull request Apr 12, 2024
…ect#474)

* fix opensearch commons strings library dependency import

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

* gradle apply spotless check

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

---------

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants