Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoding of versions in workflow #120

Conversation

peterzhuamazon
Copy link
Member

Signed-off-by: Peter Zhu zhujiaxi@amazon.com

Description

Remove hardcoding of versions in workflow

Issues Resolved

#103

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
eirsep
eirsep previously approved these changes Mar 29, 2022
dhruv16dhr
dhruv16dhr previously approved these changes Mar 29, 2022
@peterzhuamazon
Copy link
Member Author

Give it a second as I think the workflow did not fail properly.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon peterzhuamazon dismissed stale reviews from dhruv16dhr and eirsep via 9921a97 March 29, 2022 18:08
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@21c3b3c). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #120   +/-   ##
=======================================
  Coverage        ?   83.56%           
  Complexity      ?      555           
=======================================
  Files           ?       61           
  Lines           ?     2050           
  Branches        ?      146           
=======================================
  Hits            ?     1713           
  Misses          ?      232           
  Partials        ?      105           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21c3b3c...9921a97. Read the comment docs.

@peterzhuamazon peterzhuamazon merged commit 8c9d7e5 into opensearch-project:main Mar 29, 2022
@peterzhuamazon peterzhuamazon deleted the opensearch-2.0.0-qualifier-default-2 branch March 29, 2022 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for build version qualifiers.
6 participants