Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert alpha1 default version #473

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

ylwu-amzn
Copy link
Collaborator

@ylwu-amzn ylwu-amzn commented Mar 29, 2022

Signed-off-by: Yaliang Wu ylwu@amazon.com

Description

Revert alpha1 default version as it requires more changes than expected. Refer to ml-commons PR opensearch-project/ml-commons#257

This PR revert the default version change to make sure CI can work.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Yaliang Wu <ylwu@amazon.com>
@ylwu-amzn ylwu-amzn requested a review from a team March 29, 2022 00:37
@opensearch-trigger-bot opensearch-trigger-bot bot added backport 1.x infra Changes to infrastructure, testing, CI/CD, pipelines, etc. labels Mar 29, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #473 (0aa3adc) into main (7f35ed9) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #473      +/-   ##
============================================
- Coverage     78.19%   78.13%   -0.06%     
+ Complexity     4162     4157       -5     
============================================
  Files           296      296              
  Lines         17659    17659              
  Branches       1879     1879              
============================================
- Hits          13808    13798      -10     
- Misses         2957     2964       +7     
- Partials        894      897       +3     
Flag Coverage Δ
plugin 78.13% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ain/java/org/opensearch/ad/model/ModelProfile.java 69.09% <0.00%> (-3.64%) ⬇️
...ava/org/opensearch/ad/task/ADHCBatchTaskCache.java 88.88% <0.00%> (-1.24%) ⬇️
.../main/java/org/opensearch/ad/cluster/HashRing.java 81.37% <0.00%> (-0.81%) ⬇️
...java/org/opensearch/ad/task/ADBatchTaskRunner.java 81.76% <0.00%> (-0.31%) ⬇️
...ain/java/org/opensearch/ad/task/ADTaskManager.java 76.67% <0.00%> (-0.23%) ⬇️

Copy link
Member

@amitgalitz amitgalitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we blocking opensearch 2.0 build? I am okay with reverting but also okay with just sending new PR to fix when we figure out how to solve all issues

@ylwu-amzn
Copy link
Collaborator Author

No, this is to make sure new PRs will be checked by CI. For example, if you publish PR to change RCF jar to rc1 maven, the CI won't work at all. We'd better make sure the CI can pass so other PRs can be verified.

Copy link
Contributor

@aksingh-es aksingh-es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed backport label.LGTM

@ylwu-amzn ylwu-amzn merged commit 9dcf010 into opensearch-project:main Mar 29, 2022
@aksingh-es aksingh-es removed the infra Changes to infrastructure, testing, CI/CD, pipelines, etc. label Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants