Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for -Dbuild.version_qualifier #468

Merged
merged 1 commit into from
Mar 28, 2022
Merged

Add support for -Dbuild.version_qualifier #468

merged 1 commit into from
Mar 28, 2022

Conversation

aksingh-es
Copy link
Contributor

Signed-off-by: Amit Singh snghes@amazon.com

Description

-Dbuild.version_qualifier

Issues Resolved

Part of opensearch-project/opensearch-build#1632.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Amit Singh <snghes@amazon.com>
@aksingh-es aksingh-es requested a review from a team March 25, 2022 17:44
@opensearch-trigger-bot opensearch-trigger-bot bot added backport 1.x infra Changes to infrastructure, testing, CI/CD, pipelines, etc. labels Mar 25, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #468 (a28baff) into main (fa00555) will increase coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #468      +/-   ##
============================================
+ Coverage     78.18%   78.37%   +0.18%     
- Complexity     4162     4177      +15     
============================================
  Files           296      296              
  Lines         17659    17659              
  Branches       1879     1879              
============================================
+ Hits          13807    13840      +33     
+ Misses         2958     2932      -26     
+ Partials        894      887       -7     
Flag Coverage Δ
plugin 78.37% <ø> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ain/java/org/opensearch/ad/model/ModelProfile.java 70.90% <0.00%> (-1.82%) ⬇️
...rch/ad/transport/AnomalyResultTransportAction.java 80.13% <0.00%> (-0.69%) ⬇️
...opensearch/ad/indices/AnomalyDetectionIndices.java 72.36% <0.00%> (+0.18%) ⬆️
.../main/java/org/opensearch/ad/ml/CheckpointDao.java 70.19% <0.00%> (+0.64%) ⬆️
...ain/java/org/opensearch/ad/task/ADTaskManager.java 77.35% <0.00%> (+0.67%) ⬆️
...ava/org/opensearch/ad/task/ADHCBatchTaskCache.java 92.59% <0.00%> (+2.46%) ⬆️
...java/org/opensearch/ad/task/ADBatchTaskRunner.java 85.71% <0.00%> (+3.49%) ⬆️

Copy link
Member

@amitgalitz amitgalitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for making this change! I removed the 1.x backport label that gets auto added as this is a 2.0 campaign. LMK if you think this should be backported however.

Copy link
Collaborator

@ylwu-amzn ylwu-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Changes to infrastructure, testing, CI/CD, pipelines, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants