Remove JDK8 support #408
Merged
Remove JDK8 support #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #408 +/- ##
============================================
- Coverage 77.95% 77.71% -0.25%
+ Complexity 4127 4115 -12
============================================
Files 296 296
Lines 17676 17657 -19
Branches 1881 1879 -2
============================================
- Hits 13780 13722 -58
- Misses 2998 3033 +35
- Partials 898 902 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ohltyler
changed the title
ylwu-amzn
reviewed
Mar 11, 2022
| @@ -79,7 +79,7 @@ allprojects { | |||
| } | |||
|
|
|||
| plugins.withId('java') { | |||
| sourceCompatibility = targetCompatibility = "1.8" | |||
| sourceCompatibility = targetCompatibility = JavaVersion.VERSION_11 | |||
There was a problem hiding this comment.
From description
This is needed for 2.0.0, since 2.0.0 is using Apache Lucene 9, which requires JDK 11 or newer
Should we bump to 2.0 to test if this works? Check line 19, we are still using 1.3.0
There was a problem hiding this comment.
^ Yes, definitely do. But you're fine doing it in another PR.
dblock
previously approved these changes
Mar 11, 2022
| @@ -79,7 +79,7 @@ allprojects { | |||
| } | |||
|
|
|||
| plugins.withId('java') { | |||
| sourceCompatibility = targetCompatibility = "1.8" | |||
| sourceCompatibility = targetCompatibility = JavaVersion.VERSION_11 | |||
There was a problem hiding this comment.
^ Yes, definitely do. But you're fine doing it in another PR.
ylwu-amzn
previously approved these changes
Mar 11, 2022
|
@ylwu-amzn we'll have changes included in 1.3.0 first, that are changing the same CI file as here. So let's hold off on merging this yet until #431 is ready and merged, and then I'll rebase here. |
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
|
Rebased with latest changes in main. |
amitgalitz
approved these changes
Mar 14, 2022
ylwu-amzn
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tyler Ohlsen ohltyler@amazon.com
Description
This PR does 3 things to remove JDK8 support:
build.gradlefrom Java 8 -> Java 11. This tells the compiler to use a minimum of Java 11 when compiling Java source code (see gradle docs). This is needed for 2.0.0, since 2.0.0 is using Apache Lucene 9, which requires JDK 11 or newer (see release notes).assumeFalselines that were added in tests that were failing when running in JDK8 (see Build on JDK 8, revert private build of protostuff. #418)Confirmed it builds and runs successfully, tests pass. Spun up a cluster and did a quick sanity test as well.
Issues Resolved
Resolves #398
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.