Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 1.2.2. #343

Closed
wants to merge 1 commit into from
Closed

Conversation

dblock
Copy link
Member

@dblock dblock commented Dec 15, 2021

Signed-off-by: dblock dblock@amazon.com

Description

Bump version to 1.2.2.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: dblock <dblock@amazon.com>
Copy link
Member

@vamshin vamshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@vamshin
Copy link
Member

vamshin commented Dec 15, 2021

@dblock workfow seem to fail because of job scheduler. Looks like this needs to be bumped as well

| -> Failed installing file:/home/runner/work/anomaly-detection/anomaly-detection/src/test/resources/job-scheduler/opensearch-job-scheduler-1.2.1.0-SNAPSHOT.zip
Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0.
| -> Rolling back file:/home/runner/work/anomaly-detection/anomaly-detection/src/test/resources/job-scheduler/opensearch-job-scheduler-1.2.1.0-SNAPSHOT.zip
Use '--warning-mode all' to show the individual deprecation warnings.
| -> Rolled back file:/home/runner/work/anomaly-detection/anomaly-detection/src/test/resources/job-scheduler/opensearch-job-scheduler-1.2.1.0-SNAPSHOT.zip
See https://docs.gradle.org/6.6.1/userguide/command_line_interface.html#sec:command_line_warnings
| Exception in thread "main" java.lang.IllegalArgumentException: Plugin [opensearch-job-scheduler] was built for OpenSearch version 1.2.1 but version 1.2.2 is running
21 actionable tasks: 12 executed, 9 up-to-date
| 	at org.opensearch.plugins.PluginsService.verifyCompatibility(PluginsService.java:390)
| 	at org.opensearch.plugins.InstallPluginCommand.loadPluginInfo(InstallPluginCommand.java:803)
| 	at org.opensearch.plugins.InstallPluginCommand.installPlugin(InstallPluginCommand.java:858)
| 	at org.opensearch.plugins.InstallPluginCommand.execute(InstallPluginCommand.java:263)
| 	at org.opensearch.plugins.InstallPluginCommand.execute(InstallPluginCommand.java:237)
| 	at org.opensearch.cli.EnvironmentAwareCommand.execute(EnvironmentAwareCommand.java:100)
| 	at org.opensearch.cli.Command.mainWithoutErrorHandling(Command.java:138)
| 	at org.opensearch.cli.MultiCommand.execute(MultiCommand.java:104)
| 	at org.opensearch.cli.Command.mainWithoutErrorHandling(Command.java:138)
| 	at org.opensearch.cli.Command.main(Command.java:101)
| 	at org.opensearch.plugins.PluginCli.main(PluginCli.java:60)

FAILURE: Build failed with an exception.

@ohltyler
Copy link
Member

@dblock we also usually replace snapshot job-scheduler zips when version bumping. See #340. I can handle this if you want to close.

@dblock
Copy link
Member Author

dblock commented Dec 15, 2021

I see. @ohltyler take it.

@dblock dblock closed this Dec 15, 2021
@dblock
Copy link
Member Author

dblock commented Dec 15, 2021

What's the issue number of getting rid of the checked-in zip? This is quite error prone and you should be able to download the snapshot zip during build.

@ohltyler
Copy link
Member

ohltyler commented Dec 15, 2021

Definitely agreed - I'm not familiar with how that was initially set up but agreed it shouldn't need to happen. @ylwu-amzn any idea?

@ohltyler
Copy link
Member

#344 is out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants