Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flatten_result_index_mapping field to Config #1276

Merged

Conversation

jackiehanyang
Copy link
Collaborator

@jackiehanyang jackiehanyang commented Aug 11, 2024

Description

Add flatten_result_index_mapping field to Config

Related Issues

#1213

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Copy link

codecov bot commented Aug 11, 2024

Codecov Report

Attention: Patch coverage is 76.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 77.11%. Comparing base (3f0fc8c) to head (e6613e7).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
.../java/org/opensearch/ad/model/AnomalyDetector.java 75.00% 1 Missing and 1 partial ⚠️
...java/org/opensearch/forecast/model/Forecaster.java 33.33% 2 Missing ⚠️
...n/java/org/opensearch/timeseries/model/Config.java 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1276      +/-   ##
============================================
+ Coverage     71.83%   77.11%   +5.28%     
- Complexity     4898     5299     +401     
============================================
  Files           518      517       -1     
  Lines         22879    22911      +32     
  Branches       2245     2241       -4     
============================================
+ Hits          16434    17667    +1233     
+ Misses         5410     4212    -1198     
+ Partials       1035     1032       -3     
Flag Coverage Δ
plugin 77.11% <76.00%> (+5.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/main/java/org/opensearch/ad/model/ADTask.java 98.00% <100.00%> (+<0.01%) ⬆️
.../handler/AbstractAnomalyDetectorActionHandler.java 97.82% <100.00%> (+77.82%) ⬆️
...va/org/opensearch/forecast/model/ForecastTask.java 97.59% <100.00%> (+<0.01%) ⬆️
.../rest/handler/AbstractForecasterActionHandler.java 88.88% <100.00%> (+88.88%) ⬆️
.../java/org/opensearch/ad/model/AnomalyDetector.java 86.08% <75.00%> (-0.34%) ⬇️
...java/org/opensearch/forecast/model/Forecaster.java 77.51% <33.33%> (+6.43%) ⬆️
...n/java/org/opensearch/timeseries/model/Config.java 87.31% <66.66%> (-0.10%) ⬇️

... and 94 files with indirect coverage changes

@jackiehanyang jackiehanyang merged commit 34b350e into opensearch-project:main Aug 12, 2024
14 of 19 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 12, 2024
* Add flatten_result_index_mapping field into Config

Signed-off-by: Jackie Han <jkhanjob@gmail.com>

* apply spotless check

Signed-off-by: Jackie Han <jkhanjob@gmail.com>

---------

Signed-off-by: Jackie Han <jkhanjob@gmail.com>
(cherry picked from commit 34b350e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
jackiehanyang pushed a commit that referenced this pull request Aug 12, 2024
* Add flatten_result_index_mapping field into Config



* apply spotless check



---------


(cherry picked from commit 34b350e)

Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
jackiehanyang added a commit to jackiehanyang/anomaly-detection that referenced this pull request Sep 3, 2024
jackiehanyang added a commit that referenced this pull request Sep 3, 2024
#1291)

* Revert "Add flatten_result_index_mapping field to Config (#1276) (#1277)"

This reverts commit d3bd162.

* resolve conflicts

Signed-off-by: Jackie Han <jkhanjob@gmail.com>

---------

Signed-off-by: Jackie Han <jkhanjob@gmail.com>
@opensearch-trigger-bot
Copy link

The backport to 2.0 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/anomaly-detection/backport-2.0 2.0
# Navigate to the new working tree
pushd ../.worktrees/anomaly-detection/backport-2.0
# Create a new branch
git switch --create backport/backport-1276-to-2.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 34b350e85d5d2232f1915d6ed3bc8877c54fada1
# Push it to GitHub
git push --set-upstream origin backport/backport-1276-to-2.0
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/anomaly-detection/backport-2.0

Then, create a pull request where the base branch is 2.0 and the compare/head branch is backport/backport-1276-to-2.0.

@opensearch-trigger-bot
Copy link

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/anomaly-detection/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/anomaly-detection/backport-2.x
# Create a new branch
git switch --create backport/backport-1276-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 34b350e85d5d2232f1915d6ed3bc8877c54fada1
# Push it to GitHub
git push --set-upstream origin backport/backport-1276-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/anomaly-detection/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1276-to-2.x.

@opensearch-trigger-bot
Copy link

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/anomaly-detection/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/anomaly-detection/backport-2.x
# Create a new branch
git switch --create backport/backport-1276-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 34b350e85d5d2232f1915d6ed3bc8877c54fada1
# Push it to GitHub
git push --set-upstream origin backport/backport-1276-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/anomaly-detection/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1276-to-2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants