Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add Feature Filtering in Model Validation #1261

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

kaituo
Copy link
Collaborator

@kaituo kaituo commented Jul 8, 2024

Description

Backport 63dacaa from #1258.

Also, this PR followed opensearch-project/k-NN#1795 to fix CI.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Kaituo Li <kaituo@amazon.com>
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 68.12227% with 73 lines in your changes missing coverage. Please review.

Project coverage is 77.14%. Comparing base (138dbd0) to head (fc1cfec).
Report is 8 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #1261      +/-   ##
============================================
+ Coverage     71.40%   77.14%   +5.74%     
- Complexity     4878     5297     +419     
============================================
  Files           518      517       -1     
  Lines         22931    22891      -40     
  Branches       2260     2239      -21     
============================================
+ Hits          16373    17659    +1286     
+ Misses         5509     4201    -1308     
+ Partials       1049     1031      -18     
Flag Coverage Δ
plugin 77.14% <68.12%> (+5.74%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...a/org/opensearch/ad/constant/ADCommonMessages.java 95.83% <ø> (ø)
...d/rest/handler/ADModelValidationActionHandler.java 100.00% <ø> (+100.00%) ⬆️
...nsport/ValidateAnomalyDetectorTransportAction.java 100.00% <ø> (ø)
.../handler/ForecastModelValidationActionHandler.java 100.00% <ø> (+100.00%) ⬆️
...t/transport/ValidateForecasterTransportAction.java 100.00% <ø> (+70.00%) ⬆️
...opensearch/timeseries/constant/CommonMessages.java 97.43% <ø> (ø)
...a/org/opensearch/timeseries/ml/ModelColdStart.java 79.25% <100.00%> (-0.95%) ⬇️
...ch/timeseries/model/IntervalTimeConfiguration.java 92.85% <ø> (+7.14%) ⬆️
...opensearch/timeseries/model/TimeConfiguration.java 100.00% <ø> (ø)
...ansport/BaseSuggestConfigParamTransportAction.java 68.51% <100.00%> (+44.98%) ⬆️
... and 8 more

... and 91 files with indirect coverage changes

@kaituo kaituo merged commit e2c821f into opensearch-project:2.x Jul 8, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants