Add Alias Permission in Security Tests #1245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SecureADRestIT.testCreateAnomalyDetectorWithCustomResultIndex test failed because the cat user did not have the necessary permissions to create an alias, as the current custom index name is an alias. This PR addresses this issue by adding the required alias permission. Additionally, this PR includes other tests to improve test coverage. Testing: * Verified that all security tests pass. Signed-off-by: Kaituo Li <kaituo@amazon.com>
kaituo
requested review from
jmazanec15,
jngz-es,
saratvemulapalli,
ohltyler,
vamshin,
VijayanB,
ylwu-amzn,
amitgalitz,
jackiehanyang,
sean-zheng-amazon,
dbwiddis,
owaiskazi19 and
joshpalis
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1245 +/- ##
============================================
+ Coverage 71.61% 71.86% +0.25%
- Complexity 4882 4902 +20
============================================
Files 518 518
Lines 22879 22879
Branches 2245 2245
============================================
+ Hits 16384 16442 +58
+ Misses 5457 5405 -52
+ Partials 1038 1032 -6
Flags with carried forward coverage won't be shown. Click here to find out more. |
amitgalitz
approved these changes
Jun 13, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 13, 2024
The SecureADRestIT.testCreateAnomalyDetectorWithCustomResultIndex test failed because the cat user did not have the necessary permissions to create an alias, as the current custom index name is an alias. This PR addresses this issue by adding the required alias permission. Additionally, this PR includes other tests to improve test coverage. Testing: * Verified that all security tests pass. Signed-off-by: Kaituo Li <kaituo@amazon.com> (cherry picked from commit b9eff78) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 13, 2024
The SecureADRestIT.testCreateAnomalyDetectorWithCustomResultIndex test failed because the cat user did not have the necessary permissions to create an alias, as the current custom index name is an alias. This PR addresses this issue by adding the required alias permission. Additionally, this PR includes other tests to improve test coverage. Testing: * Verified that all security tests pass. Signed-off-by: Kaituo Li <kaituo@amazon.com> (cherry picked from commit b9eff78) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kaituo
pushed a commit
that referenced
this pull request
Jun 13, 2024
The SecureADRestIT.testCreateAnomalyDetectorWithCustomResultIndex test failed because the cat user did not have the necessary permissions to create an alias, as the current custom index name is an alias. This PR addresses this issue by adding the required alias permission. Additionally, this PR includes other tests to improve test coverage. Testing: * Verified that all security tests pass. (cherry picked from commit b9eff78) Signed-off-by: Kaituo Li <kaituo@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kaituo
pushed a commit
that referenced
this pull request
Jun 13, 2024
The SecureADRestIT.testCreateAnomalyDetectorWithCustomResultIndex test failed because the cat user did not have the necessary permissions to create an alias, as the current custom index name is an alias. This PR addresses this issue by adding the required alias permission. Additionally, this PR includes other tests to improve test coverage. Testing: * Verified that all security tests pass. (cherry picked from commit b9eff78) Signed-off-by: Kaituo Li <kaituo@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
74 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The SecureADRestIT.testCreateAnomalyDetectorWithCustomResultIndex test failed because the cat user did not have the necessary permissions to create an alias, as the current custom index name is an alias. This PR addresses this issue by adding the required alias permission.
Additionally, this PR includes other tests to improve test coverage.
Testing:
Issues Resolved
#1243
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.