Set baseline JDK version to JDK-21 #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Widdis <widdis@gmail.com>
dbwiddis
requested review from
jmazanec15,
jngz-es,
kaituo,
saratvemulapalli,
ohltyler,
vamshin,
VijayanB,
ylwu-amzn,
amitgalitz,
jackiehanyang,
sean-zheng-amazon,
owaiskazi19 and
joshpalis
as code owners
opensearch-trigger-bot
bot
added
infra
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1228 +/- ##
============================================
- Coverage 71.48% 71.44% -0.05%
+ Complexity 4888 4882 -6
============================================
Files 518 518
Lines 22933 22932 -1
Branches 2260 2260
============================================
- Hits 16394 16383 -11
- Misses 5496 5503 +7
- Partials 1043 1046 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Can you also change this workflow, https://github.com/opensearch-project/anomaly-detection/blob/main/.github/workflows/maven-publish.yml this failed in flow-framework too. |
Signed-off-by: Daniel Widdis <widdis@gmail.com>
kaituo
approved these changes
Jun 10, 2024
|
@dbwiddis Do you need to backport? |
No. I specifically excluded the backport label. 2.x will continue to support older JDKs, the campaign is only for 3.x. |
kaituo
added a commit
to kaituo/anomaly-detection-dashboards-plugin
that referenced
this pull request
Jun 19, 2024
This PR updates the frontend CI configuration to set up JDK 21, aligning with the baseline JDK 21 already set on the backend (opensearch-project/anomaly-detection#1228). Without this update, remote tests in CI would fail with the error: "error: release version 21 not supported." Testing: * Verified that remote tests in CI pass successfully with JDK 21. Signed-off-by: Kaituo Li <kaituo@amazon.com>
4 tasks
amitgalitz
pushed a commit
to opensearch-project/anomaly-detection-dashboards-plugin
that referenced
this pull request
Jun 19, 2024
This PR updates the frontend CI configuration to set up JDK 21, aligning with the baseline JDK 21 already set on the backend (opensearch-project/anomaly-detection#1228). Without this update, remote tests in CI would fail with the error: "error: release version 21 not supported." Testing: * Verified that remote tests in CI pass successfully with JDK 21. Signed-off-by: Kaituo Li <kaituo@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sets the baseline JDK version to JDK-21
Issues Resolved
Resolves #1223
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.