Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump plugin version to 1.0.0.0 #110

Merged
merged 8 commits into from
Jun 30, 2021

Conversation

ohltyler
Copy link
Member

@ohltyler ohltyler commented Jun 29, 2021

Signed-off-by: Tyler Ohlsen ohltyler@amazon.com

Description

Bumps plugin version to 1.0.0.0. Note that rc1 versions of the dependencies are still being used here, since integTest is failing due to an issue related to OpenSearch's distribution downloader. Changes will need to be made to bump the versions to 1.0.0 once the upstream fix has been made. I've opened #109 to track this, which also includes a link to the upstream issue.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ohltyler
Copy link
Member Author

ohltyler commented Jun 29, 2021

All tests are failing now with a similar EOFException - this is happening without bumping any versions.

org.opensearch.ad.transport.ADStatsIT > testNormalADStats FAILED
Suite: Test class org.opensearch.ad.transport.ADStatsIT
    TransportSerializationException[Failed to deserialize response from handler [org.opensearch.transport.TransportService$ContextRestoreResponseHandler/org.opensearch.action.ActionListenerResponseHandler@11dfcebe/org.opensearch.client.transport.TransportClientNodesService$RetryListener@5c7b163d]]; nested: EOFException[tried to read: 89 bytes but this stream is limited to: 43];

@ohltyler
Copy link
Member Author

Looking at the recent changes to try to find why this issue is occurring now.

In the CI workflow, we are building the local package using the 1.0 branch or OpenSearch, and different versioned branches of common-utils and job-scheduler.

From the 1.0 branch - I'm able to consistently see this error after & including commit 06578a766807ef0ca92ff764a5a5bfe1e87cbd2d, when building and publishing to maven local. Before this commit, I'm not seeing the issue, and the integTest task is passing. Still investigating

@ohltyler
Copy link
Member Author

Getting integTest to work now after specifying the rc1 tag of OpenSearch instead of 1.0 branch. Most likely related to a versioning issue when trying to mix different versions, since 1.0 branch is using version 1.0.0 instead of 1.0.0-rc1.

@ohltyler ohltyler mentioned this pull request Jun 29, 2021
1 task
@ohltyler ohltyler added infra Changes to infrastructure, testing, CI/CD, pipelines, etc. v1.0.0 labels Jun 29, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2021

Codecov Report

Merging #110 (76aa023) into main (b9c0fde) will decrease coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #110      +/-   ##
============================================
- Coverage     79.50%   79.32%   -0.18%     
+ Complexity     2697     2691       -6     
============================================
  Files           243      243              
  Lines         11132    11132              
  Branches       1014     1014              
============================================
- Hits           8850     8831      -19     
- Misses         1871     1884      +13     
- Partials        411      417       +6     
Flag Coverage Δ
plugin 79.32% <ø> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../main/java/org/opensearch/ad/cluster/HashRing.java 78.94% <0.00%> (-13.16%) ⬇️
...port/SearchAnomalyDetectorInfoTransportAction.java 63.63% <0.00%> (-4.55%) ⬇️
src/main/java/org/opensearch/ad/model/ADTask.java 95.31% <0.00%> (-2.82%) ⬇️
.../opensearch/ad/cluster/ADClusterEventListener.java 92.00% <0.00%> (-2.00%) ⬇️
...java/org/opensearch/ad/task/ADBatchTaskRunner.java 87.82% <0.00%> (-0.58%) ⬇️
...ain/java/org/opensearch/ad/task/ADTaskManager.java 72.99% <0.00%> (-0.23%) ⬇️
...opensearch/ad/indices/AnomalyDetectionIndices.java 51.72% <0.00%> (+0.31%) ⬆️

@ohltyler ohltyler mentioned this pull request Jun 30, 2021
1 task
@ohltyler ohltyler merged commit 73a666a into opensearch-project:main Jun 30, 2021
@ohltyler ohltyler deleted the bump-version-2 branch June 30, 2021 17:47
ohltyler added a commit to ohltyler/anomaly-detection-2 that referenced this pull request Jun 30, 2021
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
ohltyler added a commit that referenced this pull request Jun 30, 2021
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Changes to infrastructure, testing, CI/CD, pipelines, etc. v1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants