Fallback to cluster health on remote info failure #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
amitgalitz
requested review from
ohltyler,
kaituo,
jackiehanyang,
sean-zheng-amazon,
dbwiddis,
owaiskazi19 and
joshpalis
as code owners
kaituo
approved these changes
Oct 11, 2024
jackiehanyang
approved these changes
Oct 14, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 14, 2024
Signed-off-by: Amit Galitzky <amgalitz@amazon.com> (cherry picked from commit c6f33ce)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 14, 2024
Signed-off-by: Amit Galitzky <amgalitz@amazon.com> (cherry picked from commit c6f33ce)
amitgalitz
added a commit
to amitgalitz/anomaly-detection-dashboards-plugin
that referenced
this pull request
Oct 14, 2024
…project#886) Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
1 task
amitgalitz
added a commit
to amitgalitz/anomaly-detection-dashboards-plugin
that referenced
this pull request
Oct 14, 2024
…project#886) Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
4 tasks
amitgalitz
added a commit
that referenced
this pull request
Oct 14, 2024
* fallback if get remote info fails to cluster health call (#886) Signed-off-by: Amit Galitzky <amgalitz@amazon.com> * add correct snapshots Signed-off-by: Amit Galitzky <amgalitz@amazon.com> * change upload artifact version Signed-off-by: Amit Galitzky <amgalitz@amazon.com> --------- Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
jackiehanyang
pushed a commit
that referenced
this pull request
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed call to get remote info to only display a warning if it fails and to continue on to cluster health call so to ensure a default of only the local cluster showing up in the cluster selection.
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.