fix the bug that index field is not getting populated when editing a … #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…detector Signed-off-by: Jackie Han <jkhanjob@gmail.com>
jackiehanyang
requested review from
ohltyler,
kaituo,
amitgalitz,
sean-zheng-amazon,
dbwiddis,
owaiskazi19 and
joshpalis
as code owners
kaituo
previously approved these changes
Jun 11, 2024
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
kaituo
approved these changes
Jun 11, 2024
jackiehanyang
added a commit
that referenced
this pull request
Jun 11, 2024
#783) (#784) * fix the bug that index field is not getting populated when editing a detector Signed-off-by: Jackie Han <jkhanjob@gmail.com> * update documentation Signed-off-by: Jackie Han <jkhanjob@gmail.com> --------- Signed-off-by: Jackie Han <jkhanjob@gmail.com> (cherry picked from commit 2198a20) Co-authored-by: Jackie Han <jkhanjob@gmail.com>
opensearch-trigger-bot bot
added a commit
that referenced
this pull request
Jun 11, 2024
#783) (#784) * fix the bug that index field is not getting populated when editing a detector Signed-off-by: Jackie Han <jkhanjob@gmail.com> * update documentation Signed-off-by: Jackie Han <jkhanjob@gmail.com> --------- Signed-off-by: Jackie Han <jkhanjob@gmail.com> (cherry picked from commit 2198a20) Co-authored-by: Jackie Han <jkhanjob@gmail.com> (cherry picked from commit 2214cb3)
jackiehanyang
added a commit
that referenced
this pull request
Jun 11, 2024
#783) (#785) * fix the bug that index field is not getting populated when editing a detector Signed-off-by: Jackie Han <jkhanjob@gmail.com> * update documentation Signed-off-by: Jackie Han <jkhanjob@gmail.com> --------- Signed-off-by: Jackie Han <jkhanjob@gmail.com> (cherry picked from commit 2198a20) Co-authored-by: Jackie Han <jkhanjob@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When try to edit a detector from detector define page, index field is not get populated with value.
Addressed by changing the timing and sequence of setting index field values. Instead of setting initial field values first and data fetching next, the code now do data fetching first, then setting field values.
Issues Resolved
[List any issues this PR will resolve]
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.