make custom result index lifecycle management in AD optional #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
jackiehanyang
requested review from
ohltyler,
kaituo,
amitgalitz,
sean-zheng-amazon,
dbwiddis,
owaiskazi19 and
joshpalis
as code owners
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
|
CI failed due to Snapshot Summary |
forgot to update snapshots after removing the unit. Updating it now |
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
kaituo
approved these changes
Jun 11, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 11, 2024
* make custom result index lifecycle management in AD optional Signed-off-by: Jackie Han <jkhanjob@gmail.com> * remove unit of custom result index conditions when it's not defined Signed-off-by: Jackie Han <jkhanjob@gmail.com> * udpate snapshots Signed-off-by: Jackie Han <jkhanjob@gmail.com> --------- Signed-off-by: Jackie Han <jkhanjob@gmail.com> (cherry picked from commit f1fb57a)
jackiehanyang
added a commit
that referenced
this pull request
Jun 11, 2024
…779) * make custom result index lifecycle management in AD optional Signed-off-by: Jackie Han <jkhanjob@gmail.com> * remove unit of custom result index conditions when it's not defined Signed-off-by: Jackie Han <jkhanjob@gmail.com> * udpate snapshots Signed-off-by: Jackie Han <jkhanjob@gmail.com> --------- Signed-off-by: Jackie Han <jkhanjob@gmail.com> (cherry picked from commit f1fb57a) Co-authored-by: Jackie Han <jkhanjob@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
make custom result index lifecycle management in AD optional, allow customer to choose if they want to manage their custom result index in AD or ISM
Issues Resolved
opensearch-project/anomaly-detection#1213
opensearch-project/anomaly-detection#1232
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.