add MDS support for detector creation&Update flow #728

jackiehanyang · 2024-04-18T22:51:54Z

onboarded MDS for the following API calls by adding datasourceid paths to the redux and node apis:

apiRouter.post('/detectors/preview/{dataSourceId}', adService.previewDetector);
apiRouter.get('/detectors/{detectorName}/_match/{dataSourceId}', adService.matchDetector);
apiRouter.get('/detectors/_count/{dataSourceId}', adService.getDetectorCount);
apiRouter.post('/detectors/_validate/{validationType}/{dataSourceId}', adService.validateDetector);
apiRouter.get('/_mappings/{dataSourceId}', opensearchService.getMapping);

Revisions:

4/19:

remove neo in variable naming
create and use enum when referring to list detector page query param
make universal MDSState and share it between pages

Description

This pr adds MDS support for detector creation&update flow

Screen.Recording.2024-04-18.at.14.30.04.mov

Issues Resolved

#721
[List any issues this PR will resolve]

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Jackie Han <jkhanjob@gmail.com>

huyaboo

Overall looks good. Please see comments regarding how your page is handling DataSourceSelectable components and check if activeOption is being handled correctly in the case that no dataSourceId is provided.

huyaboo · 2024-04-19T02:10:56Z

public/pages/DefineDetector/containers/DefineDetector.tsx

+            componentType={'DataSourceSelectable'}
+            componentConfig={{
+              fullWidth: false,
+              activeOption: [{ id: MDSCreateState.selectedDataSourceId }],


How are we handling the case where MDSCreateState.selectedDataSourceId = '' but Local cluster is disabled? When this is initially defined, the default value is '' which means the initial selected option will be the Local cluster. I think a potential solution here is to set the initial state of MDSCreateState.selectedDataSourceId = undefined and something like the following:

activeOption: MDSCreateState.selectedDataSourceId === undefined ? [{ id: MDSCreateState.selectedDataSourceId }] : undefined

This enables the DataSourceSelectable component to handle the default selected choice. Could you please check for other pages as well?

+1, good catch

isn't the decision for when MDSCreateState.selectedDataSourceId = '' but Local cluster is disabled is an error banner will be thrown from the data source picker component? Have we changed that design? I think @zhyuanqi was working on that implementation?

The case I'm referring to is how you set the initial render of the page. Currently, if Local cluster is disabled and you navigate to the /app/anomaly-detection-dashboards#/, it will throw the toast message every time which should be avoided. This is because MDSCreateState.selectedDataSourceId = '' when this is not valid.

From datasource UI component side, it is not possible for a user to select Local cluster because the component will check to see if Local cluster is disabled and add/omit it if necessary. Of course, the toast should still be thrown if the user intentionally/unintentionally sets the url to dataSourceId= because it's invalid.

ic, this is the issue that AD and IMS have in the future playground, right? Let's address it in the next pr, I haven't pull latest change from OSD in this pr. So the bug has not been exposed in my local yet

From MDS side, here should be the expected behaviors:

If Local cluster is enabled:

The initial render of the page should have defaultDataSource as the selected option, not the Local cluster. This can be easily done if activeOptions = undefined. The url should reflect this choice with ?dataSourceId=<defaultDataSource>

The user should be able to select Local cluster without any Toast message being shown (and the url should reflect this choice with ?dataSourceId=)

The ?dataSourceId= should be a valid url and this should represent the Local cluster being selected

If Local cluster is disabled:

The initial render of the page should have defaultDataSource as the selected option, not the Local cluster. This can be easily done if activeOptions = undefined. The url should reflect this choice with ?dataSourceId=<defaultDataSource>

The user shouldn't be able to select Local cluster from UI component (this is datasource UI responsibility; this should already be covered)

The ?dataSourceId= can either do one of 2 things:

Throw the toast message because the Local cluster is attempted to be made but is not valid

(Preferred): redirect the url to the ?dataSourceId=<defaultDataSource> and put the defaultDatasource as the selected option. If this is non-trivial, this is the preferred option

thanks for the details! I will do a sanity check on all the data source picker components and make adjustment in the next pr. Wanted to focus on adding MDS support for creation&update flow in this pr :)

@kgcreative I may need confirmation if this makes sense from UX perspective. For right now, on datasource UI side, defaultDataSource is prioritized over Local cluster so we shouldn't change these priorities.

server/models/types.ts

ohltyler

This is great! Nothing big, few minor comments. Besides that, could you also add a lot more details in the PR description? It is really helpful for tracking and auditing of changes to have at the very least some details in each PR regarding the impact of the change, the implementation changes made (e.g., 'onboarded MDS for the following x API calls by adding datasourceid paths to the redux and node apis', etc. In addition to what is currently missing if it's an ongoing process, what future PRs will finish x,y,z, and referencing to the meta issue. Especially when it comes to hunting down bugs or user-reported issues.

public/components/CreateDetectorButtons/CreateDetectorButtons.tsx

public/pages/DefineDetector/components/Timestamp/Timestamp.tsx

public/pages/DefineDetector/containers/DefineDetector.tsx

ohltyler · 2024-04-19T03:51:02Z

public/pages/DefineDetector/containers/DefineDetector.tsx

+  const handleDataSourceChange = ([event]) => {
+    const dataSourceId = event?.id;
+    if (!dataSourceId) {
+      getNotifications().toasts.addDanger(
+        prettifyErrorMessage('Unable to set data source.')
+      );


curious, what could cause event to not have an id? Is there a way to make event typesafe so we don't need to worry about if id does not exist?

not so sure... MDS team provided this usage in their component guideline doc

@BionIT @huyaboo thoughts on this?

The callback function will either return [] (error state), [{id: '', label: 'Local cluster'] (if Local cluster is enabled) or [{id: <dataSourceId>, label: <dataSourceTitle>}]. Thus, event can be undefined and it's expected that Plugins handle this case as an invalid/error state.

One example of [] being returned is when you pass in an activeOption and you specify a dataSourceFilter that filters out the datasource. Since the dataSourceFilter function removes the activeOption as a valid choice, the component will return [].

ohltyler · 2024-04-19T03:52:33Z

public/pages/DefineDetector/containers/DefineDetector.tsx

+            componentType={'DataSourceSelectable'}
+            componentConfig={{
+              fullWidth: false,
+              activeOption: [{ id: MDSCreateState.selectedDataSourceId }],


+1, good catch

public/pages/utils/helpers.ts

public/utils/constants.ts

Signed-off-by: Jackie Han <jkhanjob@gmail.com>

ohltyler

Finished another round, getting close. I'll wait for the open threads to be resolved as well. Can you please update the PR description as well?

public/pages/utils/helpers.ts

server/utils/constants.ts

huyaboo

Approved with 2 action items:

Address remaining comments
After merge, align with the expected behaviors for the DataSourceSelectable components and how to handle url cases gracefully

Signed-off-by: Jackie Han <jkhanjob@gmail.com>

ohltyler

LGTM! Lets track the open discussions.

…#728) * update snapshots Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add snpshot Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add data source client Signed-off-by: Jackie Han <jkhanjob@gmail.com> * test * neo List Detectors page Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add opensearch_dashboards.json file Signed-off-by: Jackie Han <jkhanjob@gmail.com> * neo List Detectors page Signed-off-by: Jackie Han <jkhanjob@gmail.com> * test Signed-off-by: Jackie Han <jkhanjob@gmail.com> * Support MDS on DetectorDetails page Signed-off-by: Jackie Han <jkhanjob@gmail.com> * change 4/7 Signed-off-by: Jackie Han <jkhanjob@gmail.com> * version change Signed-off-by: Jackie Han <jkhanjob@gmail.com> * list detector list change Signed-off-by: Jackie Han <jkhanjob@gmail.com> * Support MDS on List, Detail, Dashboard, Overview pages Signed-off-by: Jackie Han <jkhanjob@gmail.com> * change version back to 3.0 Signed-off-by: Jackie Han <jkhanjob@gmail.com> * revert version change Signed-off-by: Jackie Han <jkhanjob@gmail.com> * make dataSourceId optional in DetectorListItem type Signed-off-by: Jackie Han <jkhanjob@gmail.com> * update imports Signed-off-by: Jackie Han <jkhanjob@gmail.com> * remove used function Signed-off-by: Jackie Han <jkhanjob@gmail.com> * cleanup Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add getter and setter for dataSource plugin Signed-off-by: Jackie Han <jkhanjob@gmail.com> * read dataSourceId from the url instead of passing props Signed-off-by: Jackie Han <jkhanjob@gmail.com> * addressing comments Signed-off-by: Jackie Han <jkhanjob@gmail.com> * addressing comments and run prettier Signed-off-by: Jackie Han <jkhanjob@gmail.com> * addressing comments in neo1 branch Signed-off-by: Jackie Han <jkhanjob@gmail.com> * addressing comments Signed-off-by: Jackie Han <jkhanjob@gmail.com> * make getDataSourceManagementPlugin() optional Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add comment Signed-off-by: Jackie Han <jkhanjob@gmail.com> * make dataSourceId type safe Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add MDS support on creation page Signed-off-by: Jackie Han <jkhanjob@gmail.com> * updated methods to get data source query param from url Signed-off-by: Jackie Han <jkhanjob@gmail.com> * using helper to construct url with dataSourceId Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add update page, and update urls on detector detail page Signed-off-by: Jackie Han <jkhanjob@gmail.com> * update update call router Signed-off-by: Jackie Han <jkhanjob@gmail.com> * update reducer and router Signed-off-by: Jackie Han <jkhanjob@gmail.com> * clean up Signed-off-by: Jackie Han <jkhanjob@gmail.com> * addressing comments Signed-off-by: Jackie Han <jkhanjob@gmail.com> * update enums Signed-off-by: Jackie Han <jkhanjob@gmail.com> --------- Signed-off-by: Jackie Han <jkhanjob@gmail.com> Signed-off-by: owaiskazi19 <owaiskazi19@gmail.com>

…#728) * update snapshots Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add snpshot Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add data source client Signed-off-by: Jackie Han <jkhanjob@gmail.com> * test * neo List Detectors page Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add opensearch_dashboards.json file Signed-off-by: Jackie Han <jkhanjob@gmail.com> * neo List Detectors page Signed-off-by: Jackie Han <jkhanjob@gmail.com> * test Signed-off-by: Jackie Han <jkhanjob@gmail.com> * Support MDS on DetectorDetails page Signed-off-by: Jackie Han <jkhanjob@gmail.com> * change 4/7 Signed-off-by: Jackie Han <jkhanjob@gmail.com> * version change Signed-off-by: Jackie Han <jkhanjob@gmail.com> * list detector list change Signed-off-by: Jackie Han <jkhanjob@gmail.com> * Support MDS on List, Detail, Dashboard, Overview pages Signed-off-by: Jackie Han <jkhanjob@gmail.com> * change version back to 3.0 Signed-off-by: Jackie Han <jkhanjob@gmail.com> * revert version change Signed-off-by: Jackie Han <jkhanjob@gmail.com> * make dataSourceId optional in DetectorListItem type Signed-off-by: Jackie Han <jkhanjob@gmail.com> * update imports Signed-off-by: Jackie Han <jkhanjob@gmail.com> * remove used function Signed-off-by: Jackie Han <jkhanjob@gmail.com> * cleanup Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add getter and setter for dataSource plugin Signed-off-by: Jackie Han <jkhanjob@gmail.com> * read dataSourceId from the url instead of passing props Signed-off-by: Jackie Han <jkhanjob@gmail.com> * addressing comments Signed-off-by: Jackie Han <jkhanjob@gmail.com> * addressing comments and run prettier Signed-off-by: Jackie Han <jkhanjob@gmail.com> * addressing comments in neo1 branch Signed-off-by: Jackie Han <jkhanjob@gmail.com> * addressing comments Signed-off-by: Jackie Han <jkhanjob@gmail.com> * make getDataSourceManagementPlugin() optional Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add comment Signed-off-by: Jackie Han <jkhanjob@gmail.com> * make dataSourceId type safe Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add MDS support on creation page Signed-off-by: Jackie Han <jkhanjob@gmail.com> * updated methods to get data source query param from url Signed-off-by: Jackie Han <jkhanjob@gmail.com> * using helper to construct url with dataSourceId Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add update page, and update urls on detector detail page Signed-off-by: Jackie Han <jkhanjob@gmail.com> * update update call router Signed-off-by: Jackie Han <jkhanjob@gmail.com> * update reducer and router Signed-off-by: Jackie Han <jkhanjob@gmail.com> * clean up Signed-off-by: Jackie Han <jkhanjob@gmail.com> * addressing comments Signed-off-by: Jackie Han <jkhanjob@gmail.com> * update enums Signed-off-by: Jackie Han <jkhanjob@gmail.com> --------- Signed-off-by: Jackie Han <jkhanjob@gmail.com>

* Support MDS on List, Detail, Dashboard, Overview pages (#722) * update snapshots Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add snpshot Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add data source client Signed-off-by: Jackie Han <jkhanjob@gmail.com> * test * neo List Detectors page Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add opensearch_dashboards.json file Signed-off-by: Jackie Han <jkhanjob@gmail.com> * neo List Detectors page Signed-off-by: Jackie Han <jkhanjob@gmail.com> * test Signed-off-by: Jackie Han <jkhanjob@gmail.com> * Support MDS on DetectorDetails page Signed-off-by: Jackie Han <jkhanjob@gmail.com> * change 4/7 Signed-off-by: Jackie Han <jkhanjob@gmail.com> * version change Signed-off-by: Jackie Han <jkhanjob@gmail.com> * list detector list change Signed-off-by: Jackie Han <jkhanjob@gmail.com> * Support MDS on List, Detail, Dashboard, Overview pages Signed-off-by: Jackie Han <jkhanjob@gmail.com> * change version back to 3.0 Signed-off-by: Jackie Han <jkhanjob@gmail.com> * revert version change Signed-off-by: Jackie Han <jkhanjob@gmail.com> * make dataSourceId optional in DetectorListItem type Signed-off-by: Jackie Han <jkhanjob@gmail.com> * update imports Signed-off-by: Jackie Han <jkhanjob@gmail.com> * remove used function Signed-off-by: Jackie Han <jkhanjob@gmail.com> * cleanup Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add getter and setter for dataSource plugin Signed-off-by: Jackie Han <jkhanjob@gmail.com> * read dataSourceId from the url instead of passing props Signed-off-by: Jackie Han <jkhanjob@gmail.com> * addressing comments and run prettier Signed-off-by: Jackie Han <jkhanjob@gmail.com> * addressing comments Signed-off-by: Jackie Han <jkhanjob@gmail.com> * make getDataSourceManagementPlugin() optional Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add comment Signed-off-by: Jackie Han <jkhanjob@gmail.com> * make dataSourceId type safe Signed-off-by: Jackie Han <jkhanjob@gmail.com> --------- Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add MDS support for detector creation&Update flow (#728) * update snapshots Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add snpshot Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add data source client Signed-off-by: Jackie Han <jkhanjob@gmail.com> * test * neo List Detectors page Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add opensearch_dashboards.json file Signed-off-by: Jackie Han <jkhanjob@gmail.com> * neo List Detectors page Signed-off-by: Jackie Han <jkhanjob@gmail.com> * test Signed-off-by: Jackie Han <jkhanjob@gmail.com> * Support MDS on DetectorDetails page Signed-off-by: Jackie Han <jkhanjob@gmail.com> * change 4/7 Signed-off-by: Jackie Han <jkhanjob@gmail.com> * version change Signed-off-by: Jackie Han <jkhanjob@gmail.com> * list detector list change Signed-off-by: Jackie Han <jkhanjob@gmail.com> * Support MDS on List, Detail, Dashboard, Overview pages Signed-off-by: Jackie Han <jkhanjob@gmail.com> * change version back to 3.0 Signed-off-by: Jackie Han <jkhanjob@gmail.com> * revert version change Signed-off-by: Jackie Han <jkhanjob@gmail.com> * make dataSourceId optional in DetectorListItem type Signed-off-by: Jackie Han <jkhanjob@gmail.com> * update imports Signed-off-by: Jackie Han <jkhanjob@gmail.com> * remove used function Signed-off-by: Jackie Han <jkhanjob@gmail.com> * cleanup Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add getter and setter for dataSource plugin Signed-off-by: Jackie Han <jkhanjob@gmail.com> * read dataSourceId from the url instead of passing props Signed-off-by: Jackie Han <jkhanjob@gmail.com> * addressing comments Signed-off-by: Jackie Han <jkhanjob@gmail.com> * addressing comments and run prettier Signed-off-by: Jackie Han <jkhanjob@gmail.com> * addressing comments in neo1 branch Signed-off-by: Jackie Han <jkhanjob@gmail.com> * addressing comments Signed-off-by: Jackie Han <jkhanjob@gmail.com> * make getDataSourceManagementPlugin() optional Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add comment Signed-off-by: Jackie Han <jkhanjob@gmail.com> * make dataSourceId type safe Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add MDS support on creation page Signed-off-by: Jackie Han <jkhanjob@gmail.com> * updated methods to get data source query param from url Signed-off-by: Jackie Han <jkhanjob@gmail.com> * using helper to construct url with dataSourceId Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add update page, and update urls on detector detail page Signed-off-by: Jackie Han <jkhanjob@gmail.com> * update update call router Signed-off-by: Jackie Han <jkhanjob@gmail.com> * update reducer and router Signed-off-by: Jackie Han <jkhanjob@gmail.com> * clean up Signed-off-by: Jackie Han <jkhanjob@gmail.com> * addressing comments Signed-off-by: Jackie Han <jkhanjob@gmail.com> * update enums Signed-off-by: Jackie Han <jkhanjob@gmail.com> --------- Signed-off-by: Jackie Han <jkhanjob@gmail.com> * update actionOption attribution for all data soure components (#732) Signed-off-by: Jackie Han <jkhanjob@gmail.com> * Add MDS UTs and bug fixes (#734) * working on ut Signed-off-by: Jackie Han <jkhanjob@gmail.com> * update ut Signed-off-by: Jackie Han <jkhanjob@gmail.com> * update UTs and add bug fixes Signed-off-by: Jackie Han <jkhanjob@gmail.com> --------- Signed-off-by: Jackie Han <jkhanjob@gmail.com> * bug fixes (#737) Signed-off-by: Jackie Han <jkhanjob@gmail.com> --------- Signed-off-by: Jackie Han <jkhanjob@gmail.com>

* Support MDS on List, Detail, Dashboard, Overview pages (#722) * update snapshots Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add snpshot Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add data source client Signed-off-by: Jackie Han <jkhanjob@gmail.com> * test * neo List Detectors page Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add opensearch_dashboards.json file Signed-off-by: Jackie Han <jkhanjob@gmail.com> * neo List Detectors page Signed-off-by: Jackie Han <jkhanjob@gmail.com> * test Signed-off-by: Jackie Han <jkhanjob@gmail.com> * Support MDS on DetectorDetails page Signed-off-by: Jackie Han <jkhanjob@gmail.com> * change 4/7 Signed-off-by: Jackie Han <jkhanjob@gmail.com> * version change Signed-off-by: Jackie Han <jkhanjob@gmail.com> * list detector list change Signed-off-by: Jackie Han <jkhanjob@gmail.com> * Support MDS on List, Detail, Dashboard, Overview pages Signed-off-by: Jackie Han <jkhanjob@gmail.com> * change version back to 3.0 Signed-off-by: Jackie Han <jkhanjob@gmail.com> * revert version change Signed-off-by: Jackie Han <jkhanjob@gmail.com> * make dataSourceId optional in DetectorListItem type Signed-off-by: Jackie Han <jkhanjob@gmail.com> * update imports Signed-off-by: Jackie Han <jkhanjob@gmail.com> * remove used function Signed-off-by: Jackie Han <jkhanjob@gmail.com> * cleanup Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add getter and setter for dataSource plugin Signed-off-by: Jackie Han <jkhanjob@gmail.com> * read dataSourceId from the url instead of passing props Signed-off-by: Jackie Han <jkhanjob@gmail.com> * addressing comments and run prettier Signed-off-by: Jackie Han <jkhanjob@gmail.com> * addressing comments Signed-off-by: Jackie Han <jkhanjob@gmail.com> * make getDataSourceManagementPlugin() optional Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add comment Signed-off-by: Jackie Han <jkhanjob@gmail.com> * make dataSourceId type safe Signed-off-by: Jackie Han <jkhanjob@gmail.com> --------- Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add MDS support for detector creation&Update flow (#728) * update snapshots Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add snpshot Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add data source client Signed-off-by: Jackie Han <jkhanjob@gmail.com> * test * neo List Detectors page Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add opensearch_dashboards.json file Signed-off-by: Jackie Han <jkhanjob@gmail.com> * neo List Detectors page Signed-off-by: Jackie Han <jkhanjob@gmail.com> * test Signed-off-by: Jackie Han <jkhanjob@gmail.com> * Support MDS on DetectorDetails page Signed-off-by: Jackie Han <jkhanjob@gmail.com> * change 4/7 Signed-off-by: Jackie Han <jkhanjob@gmail.com> * version change Signed-off-by: Jackie Han <jkhanjob@gmail.com> * list detector list change Signed-off-by: Jackie Han <jkhanjob@gmail.com> * Support MDS on List, Detail, Dashboard, Overview pages Signed-off-by: Jackie Han <jkhanjob@gmail.com> * change version back to 3.0 Signed-off-by: Jackie Han <jkhanjob@gmail.com> * revert version change Signed-off-by: Jackie Han <jkhanjob@gmail.com> * make dataSourceId optional in DetectorListItem type Signed-off-by: Jackie Han <jkhanjob@gmail.com> * update imports Signed-off-by: Jackie Han <jkhanjob@gmail.com> * remove used function Signed-off-by: Jackie Han <jkhanjob@gmail.com> * cleanup Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add getter and setter for dataSource plugin Signed-off-by: Jackie Han <jkhanjob@gmail.com> * read dataSourceId from the url instead of passing props Signed-off-by: Jackie Han <jkhanjob@gmail.com> * addressing comments Signed-off-by: Jackie Han <jkhanjob@gmail.com> * addressing comments and run prettier Signed-off-by: Jackie Han <jkhanjob@gmail.com> * addressing comments in neo1 branch Signed-off-by: Jackie Han <jkhanjob@gmail.com> * addressing comments Signed-off-by: Jackie Han <jkhanjob@gmail.com> * make getDataSourceManagementPlugin() optional Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add comment Signed-off-by: Jackie Han <jkhanjob@gmail.com> * make dataSourceId type safe Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add MDS support on creation page Signed-off-by: Jackie Han <jkhanjob@gmail.com> * updated methods to get data source query param from url Signed-off-by: Jackie Han <jkhanjob@gmail.com> * using helper to construct url with dataSourceId Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add update page, and update urls on detector detail page Signed-off-by: Jackie Han <jkhanjob@gmail.com> * update update call router Signed-off-by: Jackie Han <jkhanjob@gmail.com> * update reducer and router Signed-off-by: Jackie Han <jkhanjob@gmail.com> * clean up Signed-off-by: Jackie Han <jkhanjob@gmail.com> * addressing comments Signed-off-by: Jackie Han <jkhanjob@gmail.com> * update enums Signed-off-by: Jackie Han <jkhanjob@gmail.com> --------- Signed-off-by: Jackie Han <jkhanjob@gmail.com> * update actionOption attribution for all data soure components (#732) Signed-off-by: Jackie Han <jkhanjob@gmail.com> * Add MDS UTs and bug fixes (#734) * working on ut Signed-off-by: Jackie Han <jkhanjob@gmail.com> * update ut Signed-off-by: Jackie Han <jkhanjob@gmail.com> * update UTs and add bug fixes Signed-off-by: Jackie Han <jkhanjob@gmail.com> --------- Signed-off-by: Jackie Han <jkhanjob@gmail.com> * bug fixes (#737) Signed-off-by: Jackie Han <jkhanjob@gmail.com> --------- Signed-off-by: Jackie Han <jkhanjob@gmail.com> (cherry picked from commit 48acb93)

* Support MDS on List, Detail, Dashboard, Overview pages (#722) * update snapshots Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add snpshot Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add data source client Signed-off-by: Jackie Han <jkhanjob@gmail.com> * test * neo List Detectors page Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add opensearch_dashboards.json file Signed-off-by: Jackie Han <jkhanjob@gmail.com> * neo List Detectors page Signed-off-by: Jackie Han <jkhanjob@gmail.com> * test Signed-off-by: Jackie Han <jkhanjob@gmail.com> * Support MDS on DetectorDetails page Signed-off-by: Jackie Han <jkhanjob@gmail.com> * change 4/7 Signed-off-by: Jackie Han <jkhanjob@gmail.com> * version change Signed-off-by: Jackie Han <jkhanjob@gmail.com> * list detector list change Signed-off-by: Jackie Han <jkhanjob@gmail.com> * Support MDS on List, Detail, Dashboard, Overview pages Signed-off-by: Jackie Han <jkhanjob@gmail.com> * change version back to 3.0 Signed-off-by: Jackie Han <jkhanjob@gmail.com> * revert version change Signed-off-by: Jackie Han <jkhanjob@gmail.com> * make dataSourceId optional in DetectorListItem type Signed-off-by: Jackie Han <jkhanjob@gmail.com> * update imports Signed-off-by: Jackie Han <jkhanjob@gmail.com> * remove used function Signed-off-by: Jackie Han <jkhanjob@gmail.com> * cleanup Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add getter and setter for dataSource plugin Signed-off-by: Jackie Han <jkhanjob@gmail.com> * read dataSourceId from the url instead of passing props Signed-off-by: Jackie Han <jkhanjob@gmail.com> * addressing comments and run prettier Signed-off-by: Jackie Han <jkhanjob@gmail.com> * addressing comments Signed-off-by: Jackie Han <jkhanjob@gmail.com> * make getDataSourceManagementPlugin() optional Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add comment Signed-off-by: Jackie Han <jkhanjob@gmail.com> * make dataSourceId type safe Signed-off-by: Jackie Han <jkhanjob@gmail.com> --------- Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add MDS support for detector creation&Update flow (#728) * update snapshots Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add snpshot Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add data source client Signed-off-by: Jackie Han <jkhanjob@gmail.com> * test * neo List Detectors page Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add opensearch_dashboards.json file Signed-off-by: Jackie Han <jkhanjob@gmail.com> * neo List Detectors page Signed-off-by: Jackie Han <jkhanjob@gmail.com> * test Signed-off-by: Jackie Han <jkhanjob@gmail.com> * Support MDS on DetectorDetails page Signed-off-by: Jackie Han <jkhanjob@gmail.com> * change 4/7 Signed-off-by: Jackie Han <jkhanjob@gmail.com> * version change Signed-off-by: Jackie Han <jkhanjob@gmail.com> * list detector list change Signed-off-by: Jackie Han <jkhanjob@gmail.com> * Support MDS on List, Detail, Dashboard, Overview pages Signed-off-by: Jackie Han <jkhanjob@gmail.com> * change version back to 3.0 Signed-off-by: Jackie Han <jkhanjob@gmail.com> * revert version change Signed-off-by: Jackie Han <jkhanjob@gmail.com> * make dataSourceId optional in DetectorListItem type Signed-off-by: Jackie Han <jkhanjob@gmail.com> * update imports Signed-off-by: Jackie Han <jkhanjob@gmail.com> * remove used function Signed-off-by: Jackie Han <jkhanjob@gmail.com> * cleanup Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add getter and setter for dataSource plugin Signed-off-by: Jackie Han <jkhanjob@gmail.com> * read dataSourceId from the url instead of passing props Signed-off-by: Jackie Han <jkhanjob@gmail.com> * addressing comments Signed-off-by: Jackie Han <jkhanjob@gmail.com> * addressing comments and run prettier Signed-off-by: Jackie Han <jkhanjob@gmail.com> * addressing comments in neo1 branch Signed-off-by: Jackie Han <jkhanjob@gmail.com> * addressing comments Signed-off-by: Jackie Han <jkhanjob@gmail.com> * make getDataSourceManagementPlugin() optional Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add comment Signed-off-by: Jackie Han <jkhanjob@gmail.com> * make dataSourceId type safe Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add MDS support on creation page Signed-off-by: Jackie Han <jkhanjob@gmail.com> * updated methods to get data source query param from url Signed-off-by: Jackie Han <jkhanjob@gmail.com> * using helper to construct url with dataSourceId Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add update page, and update urls on detector detail page Signed-off-by: Jackie Han <jkhanjob@gmail.com> * update update call router Signed-off-by: Jackie Han <jkhanjob@gmail.com> * update reducer and router Signed-off-by: Jackie Han <jkhanjob@gmail.com> * clean up Signed-off-by: Jackie Han <jkhanjob@gmail.com> * addressing comments Signed-off-by: Jackie Han <jkhanjob@gmail.com> * update enums Signed-off-by: Jackie Han <jkhanjob@gmail.com> --------- Signed-off-by: Jackie Han <jkhanjob@gmail.com> * update actionOption attribution for all data soure components (#732) Signed-off-by: Jackie Han <jkhanjob@gmail.com> * Add MDS UTs and bug fixes (#734) * working on ut Signed-off-by: Jackie Han <jkhanjob@gmail.com> * update ut Signed-off-by: Jackie Han <jkhanjob@gmail.com> * update UTs and add bug fixes Signed-off-by: Jackie Han <jkhanjob@gmail.com> --------- Signed-off-by: Jackie Han <jkhanjob@gmail.com> * bug fixes (#737) Signed-off-by: Jackie Han <jkhanjob@gmail.com> --------- Signed-off-by: Jackie Han <jkhanjob@gmail.com> (cherry picked from commit 48acb93) Co-authored-by: Jackie Han <jkhanjob@gmail.com>

jackiehanyang added 30 commits February 14, 2024 14:12

update snapshots

d3de573

Signed-off-by: Jackie Han <jkhanjob@gmail.com>

add snpshot

8258d5c

Signed-off-by: Jackie Han <jkhanjob@gmail.com>

add data source client

9f62cf2

Signed-off-by: Jackie Han <jkhanjob@gmail.com>

test

b0d3f5b

Merge branch 'opensearch-project:main' into main

c21d6c7

neo List Detectors page

e0333ec

Signed-off-by: Jackie Han <jkhanjob@gmail.com>

add opensearch_dashboards.json file

8a94a9b

Signed-off-by: Jackie Han <jkhanjob@gmail.com>

neo List Detectors page

f122344

Signed-off-by: Jackie Han <jkhanjob@gmail.com>

test

aa5e25d

Signed-off-by: Jackie Han <jkhanjob@gmail.com>

Support MDS on DetectorDetails page

10c730b

Signed-off-by: Jackie Han <jkhanjob@gmail.com>

change 4/7

fd26997

Signed-off-by: Jackie Han <jkhanjob@gmail.com>

Merge branch 'neoDetailPage' into neo1

99a06f1

version change

2bb2a89

Signed-off-by: Jackie Han <jkhanjob@gmail.com>

list detector list change

c363632

Signed-off-by: Jackie Han <jkhanjob@gmail.com>

Support MDS on List, Detail, Dashboard, Overview pages

c2d97dc

Signed-off-by: Jackie Han <jkhanjob@gmail.com>

change version back to 3.0

373bbdf

Signed-off-by: Jackie Han <jkhanjob@gmail.com>

revert version change

e046f6d

Signed-off-by: Jackie Han <jkhanjob@gmail.com>

make dataSourceId optional in DetectorListItem type

d1bbbae

Signed-off-by: Jackie Han <jkhanjob@gmail.com>

update imports

894cf08

Signed-off-by: Jackie Han <jkhanjob@gmail.com>

remove used function

2cea066

Signed-off-by: Jackie Han <jkhanjob@gmail.com>

cleanup

2189a54

Signed-off-by: Jackie Han <jkhanjob@gmail.com>

add getter and setter for dataSource plugin

7b428f8

Signed-off-by: Jackie Han <jkhanjob@gmail.com>

read dataSourceId from the url instead of passing props

f166bd2

Signed-off-by: Jackie Han <jkhanjob@gmail.com>

addressing comments

77582ab

Signed-off-by: Jackie Han <jkhanjob@gmail.com>

addressing comments and run prettier

67f0a08

Signed-off-by: Jackie Han <jkhanjob@gmail.com>

merge neo1 branch

8dc43a1

Signed-off-by: Jackie Han <jkhanjob@gmail.com>

addressing comments in neo1 branch

5a99c24

Signed-off-by: Jackie Han <jkhanjob@gmail.com>

addressing comments

e28ff14

Signed-off-by: Jackie Han <jkhanjob@gmail.com>

make getDataSourceManagementPlugin() optional

598e3d3

Signed-off-by: Jackie Han <jkhanjob@gmail.com>

add comment

50e407b

Signed-off-by: Jackie Han <jkhanjob@gmail.com>

jackiehanyang added 3 commits April 18, 2024 15:38

Merge remote-tracking branch 'upstream/feature/mds' into neo-createPage

8fe7b3a

updated methods to get data source query param from url

3f0b7cc

Signed-off-by: Jackie Han <jkhanjob@gmail.com>

using helper to construct url with dataSourceId

a5f1131

Signed-off-by: Jackie Han <jkhanjob@gmail.com>

jackiehanyang requested review from ohltyler, kaituo, amitgalitz, sean-zheng-amazon, dbwiddis, owaiskazi19 and joshpalis as code owners April 18, 2024 22:51

add update page, and update urls on detector detail page

22dbc70

Signed-off-by: Jackie Han <jkhanjob@gmail.com>

jackiehanyang changed the title ~~add MDS support for detector creation flow~~ add MDS support for detector creation&Update flow Apr 18, 2024

jackiehanyang added 3 commits April 18, 2024 16:44

update update call router

9702e90

Signed-off-by: Jackie Han <jkhanjob@gmail.com>

update reducer and router

70f30bc

Signed-off-by: Jackie Han <jkhanjob@gmail.com>

clean up

863e0d2

Signed-off-by: Jackie Han <jkhanjob@gmail.com>

huyaboo reviewed Apr 19, 2024

View reviewed changes

ohltyler reviewed Apr 19, 2024

View reviewed changes

addressing comments

c616873

Signed-off-by: Jackie Han <jkhanjob@gmail.com>

ohltyler reviewed Apr 19, 2024

View reviewed changes

public/pages/utils/helpers.ts Outdated Show resolved Hide resolved

server/utils/constants.ts Show resolved Hide resolved

huyaboo approved these changes Apr 19, 2024

View reviewed changes

update enums

68ff1ad

Signed-off-by: Jackie Han <jkhanjob@gmail.com>

ohltyler approved these changes Apr 19, 2024

View reviewed changes

jackiehanyang merged commit a0a2608 into opensearch-project:feature/mds Apr 19, 2024
1 of 2 checks passed

jackiehanyang mentioned this pull request Apr 26, 2024

merge feature/mds branch into main #735

Closed

4 tasks

jackiehanyang mentioned this pull request Apr 29, 2024

merge feature/mds branch into main #739

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add MDS support for detector creation&Update flow #728

add MDS support for detector creation&Update flow #728

jackiehanyang commented Apr 18, 2024 •

edited

Loading

huyaboo left a comment

huyaboo Apr 19, 2024

ohltyler Apr 19, 2024

jackiehanyang Apr 19, 2024 •

edited

Loading

huyaboo Apr 19, 2024

jackiehanyang Apr 19, 2024

huyaboo Apr 19, 2024

jackiehanyang Apr 19, 2024 •

edited

Loading

huyaboo Apr 19, 2024

ohltyler left a comment

ohltyler Apr 19, 2024

jackiehanyang Apr 19, 2024

ohltyler Apr 19, 2024

huyaboo Apr 19, 2024

ohltyler Apr 19, 2024

ohltyler left a comment

huyaboo left a comment

ohltyler left a comment

add MDS support for detector creation&Update flow #728

add MDS support for detector creation&Update flow #728

Conversation

jackiehanyang commented Apr 18, 2024 • edited Loading

Revisions:

Description

Issues Resolved

Check List

huyaboo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jackiehanyang Apr 19, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jackiehanyang Apr 19, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ohltyler left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ohltyler left a comment

Choose a reason for hiding this comment

huyaboo left a comment

Choose a reason for hiding this comment

ohltyler left a comment

Choose a reason for hiding this comment

jackiehanyang commented Apr 18, 2024 •

edited

Loading

jackiehanyang Apr 19, 2024 •

edited

Loading

jackiehanyang Apr 19, 2024 •

edited

Loading