Completely fix docker pull and install plugin #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
24 tasks
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
|
Expected failure on the security as the docker image itself does not have security and pa plugin. |
|
The pulling mechanic is running well now as well as installation. |
AWSHurneyt
approved these changes
Mar 31, 2022
qreshi
reviewed
Mar 31, 2022
qreshi
approved these changes
Mar 31, 2022
Angie-Zhang
pushed a commit
to Angie-Zhang/alerting
that referenced
this pull request
Jun 29, 2022
* Completely fix docker pull and install plugin Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Set basename zip Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Angie Zhang <langelzh@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Peter Zhu zhujiaxi@amazon.com
Issue #, if available:
#348
Description of changes:
Completely fix docker pull and install plugin
CheckList:
[x] Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.