Add connection to triggers for doc level alerting #316

lezzago · 2022-03-01T17:02:57Z

Issue #, if available:

Description of changes:
Add connection to triggers for doc level alerting
CheckList:
[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

getsaurabh02

Thanks Ashish. Added few comments/recommendations to think around how we can achieve some parallelism, in near future. Also it will be great if we can start adding unit-tests across each of the newly created class files. That will help improve the testability of changes and improvements.

getsaurabh02 · 2022-03-14T20:49:25Z

alerting/src/main/kotlin/org/opensearch/alerting/MonitorRunner.kt

+            updatedLastRunContext[shard] = maxSeqNo.toString()
+        }
+
+        val queryDocIds = mutableMapOf<DocLevelQuery, Set<String>>()


queryDocIds --> queryToDocIds ?

getsaurabh02 · 2022-03-14T20:58:36Z

alerting/src/main/kotlin/org/opensearch/alerting/MonitorRunner.kt

+        }
+
+        val queryDocIds = mutableMapOf<DocLevelQuery, Set<String>>()
+        val docsToQueries = mutableMapOf<String, MutableList<String>>()


docsToQueries -> docIdsToQueries

getsaurabh02 · 2022-03-14T21:56:38Z

alerting/src/main/kotlin/org/opensearch/alerting/MonitorRunner.kt

        for (i: Int in 0 until count) {
            val shard = i.toString()
            try {
                logger.info("Monitor execution for shard: $shard")

-                val maxSeqNo: Long = getMaxSeqNo(index, shard)
+                val maxSeqNo: Long = updatedLastRunContext[shard].toString().toLong()


I like the idea that we are pre-caching the last run context per shard, as this allows uniform run-time across the shards since we its essential sequential run among the shards.

However, I see the opportunity of creating an execution object which provides abstraction for all the information needed to run the queries per shard. Such as queries, lastRunContext, UpdatedContext, matchingDocs under a single wrapper.

Think of it like the state object which you can pass to a runnable for asynchronous parallel executions. We will need this in very near future. This will help make the flow logic of this method stateless.

I added a new object, but note that this object will be modified more later on as we optimize the flow and utilize the object. I didn't see any benefit to add the matchingDocs, so that was not added.

getsaurabh02 · 2022-03-14T22:30:31Z

alerting/src/main/kotlin/org/opensearch/alerting/MonitorRunner.kt

                logger.info("MaxSeqNo of shard_$shard is $maxSeqNo")

-                // todo: scope to optimize this: in prev seqno and current max seq no are same don't search.
                val hits: SearchHits = searchShard(index, shard, lastRunContext[shard].toString().toLongOrNull(), maxSeqNo, query.query)


handle current seq number less than current? Possible it also needs initial handling when contexts are created.

Fail fast or return empty for cases where there are merges and the sequence numbers are messed up. This way next monitor execution will work correctly

getsaurabh02 · 2022-03-14T23:21:36Z

alerting/src/main/kotlin/org/opensearch/alerting/MonitorRunner.kt

+            val matchingDocIds = runForEachQuery(monitor, lastRunContext, updatedLastRunContext, index, query)
+            queryDocIds[query] = matchingDocIds
+            matchingDocIds.forEach {
+                if (docsToQueries.containsKey(it)) {
+                    docsToQueries[it]?.add(query.id)
+                } else {
+                    docsToQueries[it] = mutableListOf(query.id)
+                }
+            }


Can we simplify this by passing a Supplier Function to runForEachQuery instead which already has the matchedDocumentIds? I am again trying to put a perspective how runForEachQuery can be executed concurrently.

By trying to add a supplier, the code started to seem more complex and I noticed we need to change the threads the plugin runs on and additionally add additional permissions for the plugin to parallelize on multiple threads in the cluster.

We can do this as a separate PR

getsaurabh02 · 2022-03-14T23:25:25Z

alerting/src/main/kotlin/org/opensearch/alerting/MonitorRunner.kt

+            val triggerCtx = DocumentLevelTriggerExecutionContext(monitor, trigger as DocumentLevelTrigger)
+            val triggerResult = triggerService.runDocLevelTrigger(monitor, trigger, triggerCtx, docsToQueries, queryIds)
+
+            logger.info("trigger results")
+            logger.info(triggerResult.triggeredDocs.toString())
+
+            queryDocIds.forEach {
+                val queryTriggeredDocs = it.value.intersect(triggerResult.triggeredDocs)
+                if (queryTriggeredDocs.isNotEmpty()) {
+                    val findingId = createFindings(monitor, index, it.key, queryTriggeredDocs, trigger)
+                    // TODO: check if need to create alert, if so create it and point it to FindingId
+                    // TODO: run action as well, but this mat need to be throttled based on Mo's comment for bucket level alerting
+                }
+            }


Abstract this out as a separate runForEachTrigger. Again to achieve higher parallelism we can expect each trigger execution to return the findings. Here we may only want to consolidate them to create final findings. Thoughts?

I have separated the function out for this. Also not sure if there is any benefit to consolidate all the findings in the end since we just want to run a single action based on each finding

getsaurabh02 · 2022-03-14T23:37:55Z

alerting/src/main/kotlin/org/opensearch/alerting/TriggerService.kt

+        return try {
+            val triggeredDocs = mutableListOf<String>()
+
+            for (doc in docsToQueries.keys) {
+                val params = trigger.condition.params.toMutableMap()
+                for (queryId in queryIds) {
+                    params[queryId] = docsToQueries[doc]!!.contains(queryId)
+                }
+                val triggered = scriptService.compile(trigger.condition, TriggerScript.CONTEXT)
+                    .newInstance(params)
+                    .execute(ctx)
+                logger.info("trigger val: $triggered")
+                if (triggered) triggeredDocs.add(doc)
+            }
+
+            DocumentLevelTriggerRunResult(trigger.name, triggeredDocs, null)
+        } catch (e: Exception) {


Instead of Document -> Query, can we do Query -> Document as number of documents will be fairly large compared to number of rules. Also it will simplify match all cases, since it will boil down to the problem of common ids across multiple lists. thoughts?

This is still in discussion and we will have a path forward in a future PR.

getsaurabh02 · 2022-03-14T23:45:39Z

alerting/src/main/kotlin/org/opensearch/alerting/MonitorRunner.kt

@@ -757,39 +759,119 @@ object MonitorRunner : JobRunner, CoroutineScope, AbstractLifecycleComponent() {
            return
        }

+        val count: Int = lastRunContext["shards_count"] as Int


Do you think it's the time we break MonitorRunner into multiple concrete implementations for different types of alerting to make sure we are segregating responsibilities? This class is growing huge. It will also simplify start adding tests with dedicated scope.

Yes I agree and I have a task for refactoring to help cleanup monitor runner

alerting/src/main/kotlin/org/opensearch/alerting/MonitorRunner.kt

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

getsaurabh02

Thanks @lezzago. Added few comments for considerations. Feel free to defer them in favor of future PRs by capturing them in the main issue.
I still see missing unit tests as the major concerns. This should be our outmost next priority.

getsaurabh02 · 2022-03-18T00:42:40Z

alerting/src/main/kotlin/org/opensearch/alerting/MonitorRunner.kt

+                // TODO: check if need to create alert, if so create it and point it to FindingId
+                // TODO: run action as well, but this mat need to be throttled based on Mo's comment for bucket level alerting


Do you think its better to cover ToDo in issues (linked under one Meta) and tag them here for more context? Will it ensure we close them out before the release?

Created a github issue and will create one meta github issue later which this will be included in

getsaurabh02 · 2022-03-21T21:00:52Z

alerting/src/main/kotlin/org/opensearch/alerting/MonitorRunner.kt

@@ -757,39 +760,133 @@ object MonitorRunner : JobRunner, CoroutineScope, AbstractLifecycleComponent() {
            return
        }

-        for (query in queries) {
-            runForEachQuery(monitor, lastRunContext, index, query)
+        val count: Int = lastRunContext["shards_count"] as Int


How do we handle change in shard count between the runs? Are there edge scenarios which might need this handling.

I created this github issue regarding this. Also this only happens when there is a reindexing operation, so there might still be issues during executions since the sequence numbers will be changed as well.

getsaurabh02 · 2022-03-21T21:05:00Z

alerting/src/main/kotlin/org/opensearch/alerting/MonitorRunner.kt

+        val updatedMonitor = monitor.copy(lastRunContext = updatedLastRunContext)
+        // note: update has to called in serial for shards of a given index.
+        // make sure this is just updated for the specific query or at the end of all the queries
+        updateMonitor(client, xContentRegistry, settings, updatedMonitor)


What is there are race due to concurrent updates to monitor from user driven update vs last context updates?
I see a value into segregating the monitor configuration information from state information. Thoughts?

I will remove these comments since these have now been sorted. Yea there has been talks of having another index for additional metadata information and this can help with throttling.

getsaurabh02 · 2022-03-21T23:19:41Z

alerting/src/main/kotlin/org/opensearch/alerting/model/DocumentLevelTriggerRunResult.kt

+) : TriggerRunResult(triggerName, error) {
+
+    @Throws(IOException::class)
+    @Suppress("UNCHECKED_CAST")


can we avoid this?

It is due to actionResults has to be casted as MutableMap<String, ActionRunResult> from a generic map in this function. This is an issue for Query Level and Bucket level

getsaurabh02

Approving, as I don't see any blocking comments/feedbacks. Let's revisit these in follow up PRs.

…#316) Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

* Document level alerting dev (#272) * Update license headers (#239) Signed-off-by: Annie Lee <leeyun@amazon.com> * Delete unused properties file. (#262) Signed-off-by: dblock <dblock@dblock.org> * Update cron-utils (#266) * Update cron-utils Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * Add last run context to Monitor data model Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Co-authored-by: Annie Lee <71157062+leeyun-amzn@users.noreply.github.com> Co-authored-by: Daniel Doubrovkine (dB.) <dblock@dblock.org> * add Update Monitor function Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * fix integ test Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * Implemented draft of Finding data model, a new Input type, and some basic unit tests. (#260) * Implemented draft of Finding data model, and some basic unit tests for it. Signed-off-by: AWSHurneyt <79280347+AWSHurneyt@users.noreply.github.com> * POC for doc-level-alerting (#277) Signed-off-by: Sriram <59816283+skkosuri-amzn@users.noreply.github.com> * Add connection to triggers for doc level alerting (#316) Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * CRUD APIs integration Tests and validation"conflict resolved" (#362) Signed-off-by: charliezhangaws <zhanncha@amazon.com> * Seggregate monitor runner logic for separation of concerns (#363) * Refactor monitor runner logic for separation of concerns and better testability. Signed-off-by: Saurabh Singh <getsaurabh02@gmail.com> * Add action and alert flow and findings schema and additional fixes (#381) Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * Finding Search API (#385) * Findings search API based on Annie's work Signed-off-by: Annie Lee <leeyun@amazon.com> * Fix Search API and add IT tests Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Co-authored-by: Annie Lee <leeyun@amazon.com> * Fix integ tests and minor issues from doc level changes Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Co-authored-by: Annie Lee <71157062+leeyun-amzn@users.noreply.github.com> Co-authored-by: Daniel Doubrovkine (dB.) <dblock@dblock.org> Co-authored-by: AWSHurneyt <79280347+AWSHurneyt@users.noreply.github.com> Co-authored-by: Sriram <59816283+skkosuri-amzn@users.noreply.github.com> Co-authored-by: charliezhangaws <zhanncha@amazon.com> Co-authored-by: Saurabh Singh <getsaurabh02@gmail.com> Co-authored-by: Annie Lee <leeyun@amazon.com>

* Rebase to push doc level changes on latest main changes (#391) * Document level alerting dev (#272) Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * Add last run context to Monitor data model Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * add Update Monitor function Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * fix integ test Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * Implemented draft of Finding data model, a new Input type, and some basic unit tests. (#260) * Implemented draft of Finding data model, and some basic unit tests for it. Signed-off-by: AWSHurneyt <79280347+AWSHurneyt@users.noreply.github.com> * POC for doc-level-alerting (#277) Signed-off-by: Sriram <59816283+skkosuri-amzn@users.noreply.github.com> * Add connection to triggers for doc level alerting (#316) Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * CRUD APIs integration Tests and validation"conflict resolved" (#362) Signed-off-by: charliezhangaws <zhanncha@amazon.com> * Segregate monitor runner logic for separation of concerns (#363) * Refactor monitor runner logic for separation of concerns and better testability. Signed-off-by: Saurabh Singh <getsaurabh02@gmail.com> * Add action and alert flow and findings schema and additional fixes (#381) Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * Finding Search API (#385) * Findings search API based on Annie's work Signed-off-by: Annie Lee <leeyun@amazon.com> * Fix Search API and add IT tests Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Co-authored-by: Annie Lee <leeyun@amazon.com> * Fix integ tests and minor issues from doc level changes Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Co-authored-by: Annie Lee <71157062+leeyun-amzn@users.noreply.github.com> Co-authored-by: Daniel Doubrovkine (dB.) <dblock@dblock.org> Co-authored-by: AWSHurneyt <79280347+AWSHurneyt@users.noreply.github.com> Co-authored-by: Sriram <59816283+skkosuri-amzn@users.noreply.github.com> Co-authored-by: charliezhangaws <zhanncha@amazon.com> Co-authored-by: Saurabh Singh <getsaurabh02@gmail.com> Co-authored-by: Annie Lee <leeyun@amazon.com> * Add Trigger condition resolver which parses and evaluates the Trigger expression. (#405) Signed-off-by: Saurabh Singh <sisurab@amazon.com> * percolate query implementation in doc-level alerting (#399) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> * Finding Index rollover (#408) * Finding Index rollover Signed-off-by: jiahe zhang <zhanncha@amazon.com> * Apply fixes to make rollover work Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Co-authored-by: jiahe zhang <zhanncha@amazon.com> Co-authored-by: Annie Lee <71157062+leeyun-amzn@users.noreply.github.com> Co-authored-by: Daniel Doubrovkine (dB.) <dblock@dblock.org> Co-authored-by: AWSHurneyt <79280347+AWSHurneyt@users.noreply.github.com> Co-authored-by: Sriram <59816283+skkosuri-amzn@users.noreply.github.com> Co-authored-by: charliezhangaws <zhanncha@amazon.com> Co-authored-by: Saurabh Singh <getsaurabh02@gmail.com> Co-authored-by: Annie Lee <leeyun@amazon.com> Co-authored-by: Saurabh Singh <sisurab@amazon.com> Co-authored-by: Subhobrata Dey <sbcd90@gmail.com>

* Rebase to push doc level changes on latest main changes (opensearch-project#391) * Document level alerting dev (opensearch-project#272) Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * Add last run context to Monitor data model Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * add Update Monitor function Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * fix integ test Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * Implemented draft of Finding data model, a new Input type, and some basic unit tests. (opensearch-project#260) * Implemented draft of Finding data model, and some basic unit tests for it. Signed-off-by: AWSHurneyt <79280347+AWSHurneyt@users.noreply.github.com> * POC for doc-level-alerting (opensearch-project#277) Signed-off-by: Sriram <59816283+skkosuri-amzn@users.noreply.github.com> * Add connection to triggers for doc level alerting (opensearch-project#316) Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * CRUD APIs integration Tests and validation"conflict resolved" (opensearch-project#362) Signed-off-by: charliezhangaws <zhanncha@amazon.com> * Segregate monitor runner logic for separation of concerns (opensearch-project#363) * Refactor monitor runner logic for separation of concerns and better testability. Signed-off-by: Saurabh Singh <getsaurabh02@gmail.com> * Add action and alert flow and findings schema and additional fixes (opensearch-project#381) Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * Finding Search API (opensearch-project#385) * Findings search API based on Annie's work Signed-off-by: Annie Lee <leeyun@amazon.com> * Fix Search API and add IT tests Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Co-authored-by: Annie Lee <leeyun@amazon.com> * Fix integ tests and minor issues from doc level changes Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Co-authored-by: Annie Lee <71157062+leeyun-amzn@users.noreply.github.com> Co-authored-by: Daniel Doubrovkine (dB.) <dblock@dblock.org> Co-authored-by: AWSHurneyt <79280347+AWSHurneyt@users.noreply.github.com> Co-authored-by: Sriram <59816283+skkosuri-amzn@users.noreply.github.com> Co-authored-by: charliezhangaws <zhanncha@amazon.com> Co-authored-by: Saurabh Singh <getsaurabh02@gmail.com> Co-authored-by: Annie Lee <leeyun@amazon.com> * Add Trigger condition resolver which parses and evaluates the Trigger expression. (opensearch-project#405) Signed-off-by: Saurabh Singh <sisurab@amazon.com> * percolate query implementation in doc-level alerting (opensearch-project#399) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> * Finding Index rollover (opensearch-project#408) * Finding Index rollover Signed-off-by: jiahe zhang <zhanncha@amazon.com> * Apply fixes to make rollover work Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Co-authored-by: jiahe zhang <zhanncha@amazon.com> Co-authored-by: Annie Lee <71157062+leeyun-amzn@users.noreply.github.com> Co-authored-by: Daniel Doubrovkine (dB.) <dblock@dblock.org> Co-authored-by: AWSHurneyt <79280347+AWSHurneyt@users.noreply.github.com> Co-authored-by: Sriram <59816283+skkosuri-amzn@users.noreply.github.com> Co-authored-by: charliezhangaws <zhanncha@amazon.com> Co-authored-by: Saurabh Singh <getsaurabh02@gmail.com> Co-authored-by: Annie Lee <leeyun@amazon.com> Co-authored-by: Saurabh Singh <sisurab@amazon.com> Co-authored-by: Subhobrata Dey <sbcd90@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* fix security test workflow (#407) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Integrate Document Level Alerting changes (#410) * Rebase to push doc level changes on latest main changes (#391) * Document level alerting dev (#272) Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * Add last run context to Monitor data model Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * add Update Monitor function Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * fix integ test Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * Implemented draft of Finding data model, a new Input type, and some basic unit tests. (#260) * Implemented draft of Finding data model, and some basic unit tests for it. Signed-off-by: AWSHurneyt <79280347+AWSHurneyt@users.noreply.github.com> * POC for doc-level-alerting (#277) Signed-off-by: Sriram <59816283+skkosuri-amzn@users.noreply.github.com> * Add connection to triggers for doc level alerting (#316) Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * CRUD APIs integration Tests and validation"conflict resolved" (#362) Signed-off-by: charliezhangaws <zhanncha@amazon.com> * Segregate monitor runner logic for separation of concerns (#363) * Refactor monitor runner logic for separation of concerns and better testability. Signed-off-by: Saurabh Singh <getsaurabh02@gmail.com> * Add action and alert flow and findings schema and additional fixes (#381) Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * Finding Search API (#385) * Findings search API based on Annie's work Signed-off-by: Annie Lee <leeyun@amazon.com> * Fix Search API and add IT tests Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Co-authored-by: Annie Lee <leeyun@amazon.com> * Fix integ tests and minor issues from doc level changes Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Co-authored-by: Annie Lee <71157062+leeyun-amzn@users.noreply.github.com> Co-authored-by: Daniel Doubrovkine (dB.) <dblock@dblock.org> Co-authored-by: AWSHurneyt <79280347+AWSHurneyt@users.noreply.github.com> Co-authored-by: Sriram <59816283+skkosuri-amzn@users.noreply.github.com> Co-authored-by: charliezhangaws <zhanncha@amazon.com> Co-authored-by: Saurabh Singh <getsaurabh02@gmail.com> Co-authored-by: Annie Lee <leeyun@amazon.com> * Add Trigger condition resolver which parses and evaluates the Trigger expression. (#405) Signed-off-by: Saurabh Singh <sisurab@amazon.com> * percolate query implementation in doc-level alerting (#399) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> * Finding Index rollover (#408) * Finding Index rollover Signed-off-by: jiahe zhang <zhanncha@amazon.com> * Apply fixes to make rollover work Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Co-authored-by: jiahe zhang <zhanncha@amazon.com> Co-authored-by: Annie Lee <71157062+leeyun-amzn@users.noreply.github.com> Co-authored-by: Daniel Doubrovkine (dB.) <dblock@dblock.org> Co-authored-by: AWSHurneyt <79280347+AWSHurneyt@users.noreply.github.com> Co-authored-by: Sriram <59816283+skkosuri-amzn@users.noreply.github.com> Co-authored-by: charliezhangaws <zhanncha@amazon.com> Co-authored-by: Saurabh Singh <getsaurabh02@gmail.com> Co-authored-by: Annie Lee <leeyun@amazon.com> Co-authored-by: Saurabh Singh <sisurab@amazon.com> Co-authored-by: Subhobrata Dey <sbcd90@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Remove write Destination APIs (#412) * Remove write Destination API REST handlers Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com> * Remove write Destination transport actions Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com> * Remove write Destination action, request and response classes Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com> * Create Alerting config index if it doesn't exist before legacy Destination indexing Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com> * Remove write Destination related security tests Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com> * Remove unused access roles and imports Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Deprecate the Master nomenclature in 2.0 (#415) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Remove Alerting's notification subproject (#413) * Remove notification subproject Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com> * Remove publishing to maven in build script Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Skipping destination migration if alerting index is not initialized (#417) Signed-off-by: Ravi 6005951+thalurur@users.noreply.github.com Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Alias support for Document Level Monitors (#416) * Implemented support for defining doc level monitors using aliases. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fix integ tests and cleaup alias logic Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Co-authored-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed a flaky test condition. (#375) Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Replace checked-in ZIP for bwc tests with a dynamic dependency (#411) * Replace checked-in ZIP with a dynamic dependency Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> * Replace checked-in ZIP with a dynamic dependency Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Update integTest gradle scripts to run via remote cluster independently (#418) Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Removed tests that were duplicated while resolving merge conflicts. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Co-authored-by: Subhobrata Dey <sbcd90@gmail.com> Co-authored-by: Ashish Agrawal <ashisagr@amazon.com> Co-authored-by: Annie Lee <71157062+leeyun-amzn@users.noreply.github.com> Co-authored-by: Daniel Doubrovkine (dB.) <dblock@dblock.org> Co-authored-by: Sriram <59816283+skkosuri-amzn@users.noreply.github.com> Co-authored-by: charliezhangaws <zhanncha@amazon.com> Co-authored-by: Saurabh Singh <getsaurabh02@gmail.com> Co-authored-by: Annie Lee <leeyun@amazon.com> Co-authored-by: Saurabh Singh <sisurab@amazon.com> Co-authored-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com> Co-authored-by: Ravi <6005951+thalurur@users.noreply.github.com>

* fix security test workflow (opensearch-project#407) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Integrate Document Level Alerting changes (opensearch-project#410) * Rebase to push doc level changes on latest main changes (opensearch-project#391) * Document level alerting dev (opensearch-project#272) Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * Add last run context to Monitor data model Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * add Update Monitor function Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * fix integ test Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * Implemented draft of Finding data model, a new Input type, and some basic unit tests. (opensearch-project#260) * Implemented draft of Finding data model, and some basic unit tests for it. Signed-off-by: AWSHurneyt <79280347+AWSHurneyt@users.noreply.github.com> * POC for doc-level-alerting (opensearch-project#277) Signed-off-by: Sriram <59816283+skkosuri-amzn@users.noreply.github.com> * Add connection to triggers for doc level alerting (opensearch-project#316) Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * CRUD APIs integration Tests and validation"conflict resolved" (opensearch-project#362) Signed-off-by: charliezhangaws <zhanncha@amazon.com> * Segregate monitor runner logic for separation of concerns (opensearch-project#363) * Refactor monitor runner logic for separation of concerns and better testability. Signed-off-by: Saurabh Singh <getsaurabh02@gmail.com> * Add action and alert flow and findings schema and additional fixes (opensearch-project#381) Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * Finding Search API (opensearch-project#385) * Findings search API based on Annie's work Signed-off-by: Annie Lee <leeyun@amazon.com> * Fix Search API and add IT tests Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Co-authored-by: Annie Lee <leeyun@amazon.com> * Fix integ tests and minor issues from doc level changes Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Co-authored-by: Annie Lee <71157062+leeyun-amzn@users.noreply.github.com> Co-authored-by: Daniel Doubrovkine (dB.) <dblock@dblock.org> Co-authored-by: AWSHurneyt <79280347+AWSHurneyt@users.noreply.github.com> Co-authored-by: Sriram <59816283+skkosuri-amzn@users.noreply.github.com> Co-authored-by: charliezhangaws <zhanncha@amazon.com> Co-authored-by: Saurabh Singh <getsaurabh02@gmail.com> Co-authored-by: Annie Lee <leeyun@amazon.com> * Add Trigger condition resolver which parses and evaluates the Trigger expression. (opensearch-project#405) Signed-off-by: Saurabh Singh <sisurab@amazon.com> * percolate query implementation in doc-level alerting (opensearch-project#399) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> * Finding Index rollover (opensearch-project#408) * Finding Index rollover Signed-off-by: jiahe zhang <zhanncha@amazon.com> * Apply fixes to make rollover work Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Co-authored-by: jiahe zhang <zhanncha@amazon.com> Co-authored-by: Annie Lee <71157062+leeyun-amzn@users.noreply.github.com> Co-authored-by: Daniel Doubrovkine (dB.) <dblock@dblock.org> Co-authored-by: AWSHurneyt <79280347+AWSHurneyt@users.noreply.github.com> Co-authored-by: Sriram <59816283+skkosuri-amzn@users.noreply.github.com> Co-authored-by: charliezhangaws <zhanncha@amazon.com> Co-authored-by: Saurabh Singh <getsaurabh02@gmail.com> Co-authored-by: Annie Lee <leeyun@amazon.com> Co-authored-by: Saurabh Singh <sisurab@amazon.com> Co-authored-by: Subhobrata Dey <sbcd90@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Remove write Destination APIs (opensearch-project#412) * Remove write Destination API REST handlers Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com> * Remove write Destination transport actions Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com> * Remove write Destination action, request and response classes Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com> * Create Alerting config index if it doesn't exist before legacy Destination indexing Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com> * Remove write Destination related security tests Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com> * Remove unused access roles and imports Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Deprecate the Master nomenclature in 2.0 (opensearch-project#415) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Remove Alerting's notification subproject (opensearch-project#413) * Remove notification subproject Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com> * Remove publishing to maven in build script Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Skipping destination migration if alerting index is not initialized (opensearch-project#417) Signed-off-by: Ravi 6005951+thalurur@users.noreply.github.com Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Alias support for Document Level Monitors (opensearch-project#416) * Implemented support for defining doc level monitors using aliases. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fix integ tests and cleaup alias logic Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Co-authored-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed a flaky test condition. (opensearch-project#375) Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Replace checked-in ZIP for bwc tests with a dynamic dependency (opensearch-project#411) * Replace checked-in ZIP with a dynamic dependency Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> * Replace checked-in ZIP with a dynamic dependency Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Update integTest gradle scripts to run via remote cluster independently (opensearch-project#418) Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Removed tests that were duplicated while resolving merge conflicts. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Co-authored-by: Subhobrata Dey <sbcd90@gmail.com> Co-authored-by: Ashish Agrawal <ashisagr@amazon.com> Co-authored-by: Annie Lee <71157062+leeyun-amzn@users.noreply.github.com> Co-authored-by: Daniel Doubrovkine (dB.) <dblock@dblock.org> Co-authored-by: Sriram <59816283+skkosuri-amzn@users.noreply.github.com> Co-authored-by: charliezhangaws <zhanncha@amazon.com> Co-authored-by: Saurabh Singh <getsaurabh02@gmail.com> Co-authored-by: Annie Lee <leeyun@amazon.com> Co-authored-by: Saurabh Singh <sisurab@amazon.com> Co-authored-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com> Co-authored-by: Ravi <6005951+thalurur@users.noreply.github.com> Signed-off-by: Angie Zhang <langelzh@amazon.com>

* Rebase to push doc level changes on latest main changes (opensearch-project#391) * Document level alerting dev (opensearch-project#272) Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * Add last run context to Monitor data model Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * add Update Monitor function Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * fix integ test Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * Implemented draft of Finding data model, a new Input type, and some basic unit tests. (opensearch-project#260) * Implemented draft of Finding data model, and some basic unit tests for it. Signed-off-by: AWSHurneyt <79280347+AWSHurneyt@users.noreply.github.com> * POC for doc-level-alerting (opensearch-project#277) Signed-off-by: Sriram <59816283+skkosuri-amzn@users.noreply.github.com> * Add connection to triggers for doc level alerting (opensearch-project#316) Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * CRUD APIs integration Tests and validation"conflict resolved" (opensearch-project#362) Signed-off-by: charliezhangaws <zhanncha@amazon.com> * Segregate monitor runner logic for separation of concerns (opensearch-project#363) * Refactor monitor runner logic for separation of concerns and better testability. Signed-off-by: Saurabh Singh <getsaurabh02@gmail.com> * Add action and alert flow and findings schema and additional fixes (opensearch-project#381) Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * Finding Search API (opensearch-project#385) * Findings search API based on Annie's work Signed-off-by: Annie Lee <leeyun@amazon.com> * Fix Search API and add IT tests Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Co-authored-by: Annie Lee <leeyun@amazon.com> * Fix integ tests and minor issues from doc level changes Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Co-authored-by: Annie Lee <71157062+leeyun-amzn@users.noreply.github.com> Co-authored-by: Daniel Doubrovkine (dB.) <dblock@dblock.org> Co-authored-by: AWSHurneyt <79280347+AWSHurneyt@users.noreply.github.com> Co-authored-by: Sriram <59816283+skkosuri-amzn@users.noreply.github.com> Co-authored-by: charliezhangaws <zhanncha@amazon.com> Co-authored-by: Saurabh Singh <getsaurabh02@gmail.com> Co-authored-by: Annie Lee <leeyun@amazon.com> * Add Trigger condition resolver which parses and evaluates the Trigger expression. (opensearch-project#405) Signed-off-by: Saurabh Singh <sisurab@amazon.com> * percolate query implementation in doc-level alerting (opensearch-project#399) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> * Finding Index rollover (opensearch-project#408) * Finding Index rollover Signed-off-by: jiahe zhang <zhanncha@amazon.com> * Apply fixes to make rollover work Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Co-authored-by: jiahe zhang <zhanncha@amazon.com> Co-authored-by: Annie Lee <71157062+leeyun-amzn@users.noreply.github.com> Co-authored-by: Daniel Doubrovkine (dB.) <dblock@dblock.org> Co-authored-by: AWSHurneyt <79280347+AWSHurneyt@users.noreply.github.com> Co-authored-by: Sriram <59816283+skkosuri-amzn@users.noreply.github.com> Co-authored-by: charliezhangaws <zhanncha@amazon.com> Co-authored-by: Saurabh Singh <getsaurabh02@gmail.com> Co-authored-by: Annie Lee <leeyun@amazon.com> Co-authored-by: Saurabh Singh <sisurab@amazon.com> Co-authored-by: Subhobrata Dey <sbcd90@gmail.com> Signed-off-by: Angie Zhang <langelzh@amazon.com>

* fix security test workflow (opensearch-project#407) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Integrate Document Level Alerting changes (opensearch-project#410) * Rebase to push doc level changes on latest main changes (opensearch-project#391) * Document level alerting dev (opensearch-project#272) Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * Add last run context to Monitor data model Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * add Update Monitor function Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * fix integ test Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * Implemented draft of Finding data model, a new Input type, and some basic unit tests. (opensearch-project#260) * Implemented draft of Finding data model, and some basic unit tests for it. Signed-off-by: AWSHurneyt <79280347+AWSHurneyt@users.noreply.github.com> * POC for doc-level-alerting (opensearch-project#277) Signed-off-by: Sriram <59816283+skkosuri-amzn@users.noreply.github.com> * Add connection to triggers for doc level alerting (opensearch-project#316) Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * CRUD APIs integration Tests and validation"conflict resolved" (opensearch-project#362) Signed-off-by: charliezhangaws <zhanncha@amazon.com> * Segregate monitor runner logic for separation of concerns (opensearch-project#363) * Refactor monitor runner logic for separation of concerns and better testability. Signed-off-by: Saurabh Singh <getsaurabh02@gmail.com> * Add action and alert flow and findings schema and additional fixes (opensearch-project#381) Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * Finding Search API (opensearch-project#385) * Findings search API based on Annie's work Signed-off-by: Annie Lee <leeyun@amazon.com> * Fix Search API and add IT tests Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Co-authored-by: Annie Lee <leeyun@amazon.com> * Fix integ tests and minor issues from doc level changes Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Co-authored-by: Annie Lee <71157062+leeyun-amzn@users.noreply.github.com> Co-authored-by: Daniel Doubrovkine (dB.) <dblock@dblock.org> Co-authored-by: AWSHurneyt <79280347+AWSHurneyt@users.noreply.github.com> Co-authored-by: Sriram <59816283+skkosuri-amzn@users.noreply.github.com> Co-authored-by: charliezhangaws <zhanncha@amazon.com> Co-authored-by: Saurabh Singh <getsaurabh02@gmail.com> Co-authored-by: Annie Lee <leeyun@amazon.com> * Add Trigger condition resolver which parses and evaluates the Trigger expression. (opensearch-project#405) Signed-off-by: Saurabh Singh <sisurab@amazon.com> * percolate query implementation in doc-level alerting (opensearch-project#399) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> * Finding Index rollover (opensearch-project#408) * Finding Index rollover Signed-off-by: jiahe zhang <zhanncha@amazon.com> * Apply fixes to make rollover work Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Co-authored-by: jiahe zhang <zhanncha@amazon.com> Co-authored-by: Annie Lee <71157062+leeyun-amzn@users.noreply.github.com> Co-authored-by: Daniel Doubrovkine (dB.) <dblock@dblock.org> Co-authored-by: AWSHurneyt <79280347+AWSHurneyt@users.noreply.github.com> Co-authored-by: Sriram <59816283+skkosuri-amzn@users.noreply.github.com> Co-authored-by: charliezhangaws <zhanncha@amazon.com> Co-authored-by: Saurabh Singh <getsaurabh02@gmail.com> Co-authored-by: Annie Lee <leeyun@amazon.com> Co-authored-by: Saurabh Singh <sisurab@amazon.com> Co-authored-by: Subhobrata Dey <sbcd90@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Remove write Destination APIs (opensearch-project#412) * Remove write Destination API REST handlers Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com> * Remove write Destination transport actions Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com> * Remove write Destination action, request and response classes Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com> * Create Alerting config index if it doesn't exist before legacy Destination indexing Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com> * Remove write Destination related security tests Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com> * Remove unused access roles and imports Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Deprecate the Master nomenclature in 2.0 (opensearch-project#415) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Remove Alerting's notification subproject (opensearch-project#413) * Remove notification subproject Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com> * Remove publishing to maven in build script Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Skipping destination migration if alerting index is not initialized (opensearch-project#417) Signed-off-by: Ravi 6005951+thalurur@users.noreply.github.com Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Alias support for Document Level Monitors (opensearch-project#416) * Implemented support for defining doc level monitors using aliases. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fix integ tests and cleaup alias logic Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Co-authored-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed a flaky test condition. (opensearch-project#375) Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Replace checked-in ZIP for bwc tests with a dynamic dependency (opensearch-project#411) * Replace checked-in ZIP with a dynamic dependency Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> * Replace checked-in ZIP with a dynamic dependency Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Update integTest gradle scripts to run via remote cluster independently (opensearch-project#418) Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Removed tests that were duplicated while resolving merge conflicts. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Co-authored-by: Subhobrata Dey <sbcd90@gmail.com> Co-authored-by: Ashish Agrawal <ashisagr@amazon.com> Co-authored-by: Annie Lee <71157062+leeyun-amzn@users.noreply.github.com> Co-authored-by: Daniel Doubrovkine (dB.) <dblock@dblock.org> Co-authored-by: Sriram <59816283+skkosuri-amzn@users.noreply.github.com> Co-authored-by: charliezhangaws <zhanncha@amazon.com> Co-authored-by: Saurabh Singh <getsaurabh02@gmail.com> Co-authored-by: Annie Lee <leeyun@amazon.com> Co-authored-by: Saurabh Singh <sisurab@amazon.com> Co-authored-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com> Co-authored-by: Ravi <6005951+thalurur@users.noreply.github.com> Signed-off-by: Angie Zhang <langelzh@amazon.com>

lezzago requested a review from a team March 1, 2022 17:02

Add connection to triggers for doc level alerting

7550c7b

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

lezzago force-pushed the document-level-alerting-dev branch from 6b8c55b to 7550c7b Compare March 1, 2022 17:04

remove comments

4ba370d

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

getsaurabh02 reviewed Mar 14, 2022

View reviewed changes

AWSHurneyt reviewed Mar 15, 2022

View reviewed changes

alerting/src/main/kotlin/org/opensearch/alerting/MonitorRunner.kt Show resolved Hide resolved

fixes

2ea6420

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

getsaurabh02 reviewed Mar 21, 2022

View reviewed changes

getsaurabh02 approved these changes Mar 21, 2022

View reviewed changes

lezzago merged commit de635f4 into opensearch-project:document-level-alerting-dev Mar 22, 2022

lezzago added a commit to lezzago/alerting-opensearch that referenced this pull request Apr 10, 2022

Add connection to triggers for doc level alerting (opensearch-project…

1858079

…#316) Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

lezzago added a commit to lezzago/alerting-opensearch that referenced this pull request Apr 10, 2022

Add connection to triggers for doc level alerting (opensearch-project…

e6d9735

…#316) Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

lezzago added a commit to lezzago/alerting-opensearch that referenced this pull request Apr 10, 2022

Add connection to triggers for doc level alerting (opensearch-project…

64fc0d4

…#316) Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add connection to triggers for doc level alerting #316

Add connection to triggers for doc level alerting #316

lezzago commented Mar 1, 2022

getsaurabh02 left a comment

getsaurabh02 Mar 14, 2022

getsaurabh02 Mar 14, 2022

getsaurabh02 Mar 14, 2022

lezzago Mar 17, 2022

getsaurabh02 Mar 14, 2022

lezzago Mar 16, 2022

getsaurabh02 Mar 14, 2022

lezzago Mar 17, 2022

getsaurabh02 Mar 14, 2022

lezzago Mar 17, 2022

getsaurabh02 Mar 14, 2022

lezzago Mar 16, 2022

getsaurabh02 Mar 14, 2022

lezzago Mar 15, 2022

getsaurabh02 left a comment

getsaurabh02 Mar 18, 2022

lezzago Mar 22, 2022

getsaurabh02 Mar 21, 2022

lezzago Mar 22, 2022

getsaurabh02 Mar 21, 2022

lezzago Mar 22, 2022

getsaurabh02 Mar 21, 2022

lezzago Mar 22, 2022

getsaurabh02 left a comment

		// TODO: check if need to create alert, if so create it and point it to FindingId
		// TODO: run action as well, but this mat need to be throttled based on Mo's comment for bucket level alerting

Add connection to triggers for doc level alerting #316

Add connection to triggers for doc level alerting #316

Conversation

lezzago commented Mar 1, 2022

getsaurabh02 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

getsaurabh02 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

getsaurabh02 left a comment

Choose a reason for hiding this comment