Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update maven publication to include cksums. #224

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

mch2
Copy link
Member

@mch2 mch2 commented Nov 4, 2021

Signed-off-by: Marc Handalian handalm@amazon.com

Issue #, if available:
closes #223

Description of changes:
This change adds a task to publish to a local staging repo under build/ that includes cksums. It also updates build.sh to use this new task and copy the contents of the staging repo to the output directory.
The maven publish plugin will not include these cksums when publishing to maven local but will when published to a separate folder.

./scripts/build.sh -v 1.2.0 -s false
~/workspace/alerting (maven)$ find ./artifacts/maven/org/opensearch/notification/
./artifacts/maven/org/opensearch/notification/
./artifacts/maven/org/opensearch/notification//maven-metadata.xml.sha256
./artifacts/maven/org/opensearch/notification//maven-metadata.xml
./artifacts/maven/org/opensearch/notification//maven-metadata.xml.sha512
./artifacts/maven/org/opensearch/notification//1.2.0.0
./artifacts/maven/org/opensearch/notification//1.2.0.0/notification-1.2.0.0.pom.sha256
./artifacts/maven/org/opensearch/notification//1.2.0.0/notification-1.2.0.0.jar.sha512
./artifacts/maven/org/opensearch/notification//1.2.0.0/notification-1.2.0.0.jar.sha1
./artifacts/maven/org/opensearch/notification//1.2.0.0/notification-1.2.0.0-sources.jar.sha256
./artifacts/maven/org/opensearch/notification//1.2.0.0/notification-1.2.0.0-sources.jar.sha1
./artifacts/maven/org/opensearch/notification//1.2.0.0/notification-1.2.0.0-javadoc.jar.md5
./artifacts/maven/org/opensearch/notification//1.2.0.0/notification-1.2.0.0-javadoc.jar.sha512
./artifacts/maven/org/opensearch/notification//1.2.0.0/notification-1.2.0.0-javadoc.jar
./artifacts/maven/org/opensearch/notification//1.2.0.0/notification-1.2.0.0-sources.jar
./artifacts/maven/org/opensearch/notification//1.2.0.0/notification-1.2.0.0.pom.sha1
./artifacts/maven/org/opensearch/notification//1.2.0.0/notification-1.2.0.0-sources.jar.sha512
./artifacts/maven/org/opensearch/notification//1.2.0.0/notification-1.2.0.0.pom.md5
./artifacts/maven/org/opensearch/notification//1.2.0.0/notification-1.2.0.0.pom.sha512
./artifacts/maven/org/opensearch/notification//1.2.0.0/notification-1.2.0.0.jar.sha256
./artifacts/maven/org/opensearch/notification//1.2.0.0/notification-1.2.0.0.pom
./artifacts/maven/org/opensearch/notification//1.2.0.0/notification-1.2.0.0.jar.md5
./artifacts/maven/org/opensearch/notification//1.2.0.0/notification-1.2.0.0-sources.jar.md5
./artifacts/maven/org/opensearch/notification//1.2.0.0/notification-1.2.0.0-javadoc.jar.sha1
./artifacts/maven/org/opensearch/notification//1.2.0.0/notification-1.2.0.0.jar
./artifacts/maven/org/opensearch/notification//1.2.0.0/notification-1.2.0.0-javadoc.jar.sha256
./artifacts/maven/org/opensearch/notification//maven-metadata.xml.md5
./artifacts/maven/org/opensearch/notification//maven-metadata.xml.sha1

CheckList:
[x ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

This change adds a task to publish to a local staging repo under build/ that includes cksums.  It also updates build.sh to use this new task and copy the contents of the staging repo to the output directory.
The maven publish plugin will not include these cksums when publishing to maven local but will when published to a separate folder.

Signed-off-by: Marc Handalian <handalm@amazon.com>
@codecov-commenter
Copy link

Codecov Report

Merging #224 (9b3a8ff) into main (8b337e7) will decrease coverage by 0.20%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #224      +/-   ##
============================================
- Coverage     78.63%   78.43%   -0.21%     
+ Complexity      215      212       -3     
============================================
  Files           173      173              
  Lines          6959     6959              
  Branches        912      912              
============================================
- Hits           5472     5458      -14     
- Misses         1002     1017      +15     
+ Partials        485      484       -1     
Impacted Files Coverage Δ
...arch/alerting/core/schedule/JobSchedulerMetrics.kt 55.55% <0.00%> (-16.67%) ⬇️
...rch/alerting/core/action/node/ScheduledJobStats.kt 55.55% <0.00%> (-11.12%) ⬇️
.../opensearch/alerting/core/schedule/JobScheduler.kt 69.44% <0.00%> (-6.95%) ⬇️
...in/kotlin/org/opensearch/alerting/MonitorRunner.kt 71.38% <0.00%> (-0.68%) ⬇️
...ain/kotlin/org/opensearch/alerting/AlertService.kt 78.04% <0.00%> (-0.49%) ⬇️
...e/action/node/ScheduledJobsStatsTransportAction.kt 75.51% <0.00%> (ø)
.../kotlin/org/opensearch/alerting/core/JobSweeper.kt 72.25% <0.00%> (+0.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b337e7...9b3a8ff. Read the comment docs.

@dblock dblock merged commit 621d75e into opensearch-project:main Nov 5, 2021
rishabhmaurya pushed a commit to rishabhmaurya/alerting-1 that referenced this pull request Nov 8, 2021
This change adds a task to publish to a local staging repo under build/ that includes cksums.  It also updates build.sh to use this new task and copy the contents of the staging repo to the output directory.
The maven publish plugin will not include these cksums when publishing to maven local but will when published to a separate folder.

Signed-off-by: Marc Handalian <handalm@amazon.com>
rishabhmaurya added a commit that referenced this pull request Nov 9, 2021
* Updates alerting version to 1.2 (#192)

* Updates alerting version to 1.2

* Adds snapshot repo to the repository file

Signed-off-by: Clay Downs <downsrob@amazon.com>

* Update build to use public Maven repo (#184)

Signed-off-by: Abbas Hussain <abbas_10690@yahoo.com>

* Publish notification JARs checksums. (#196)

* Publish notification JARs checksums.

Signed-off-by: dblock <dblock@dblock.org>

* Remove sonatype staging.

Signed-off-by: dblock <dblock@dblock.org>

* Updates testCompile mockito version to match OpenSearch changes (#204)

Signed-off-by: Clay Downs <downsrob@amazon.com>

* Update maven publication to include cksums. (#224)

This change adds a task to publish to a local staging repo under build/ that includes cksums.  It also updates build.sh to use this new task and copy the contents of the staging repo to the output directory.
The maven publish plugin will not include these cksums when publishing to maven local but will when published to a separate folder.

Signed-off-by: Marc Handalian <handalm@amazon.com>

* Add release notes for 1.2.0.0 release (#225)

* Create opensearch-alerting.release-notes-1.2.0.0.md

Signed-off-by: Annie Lee <leeyun@amazon.com>

* Update opensearch-alerting.release-notes-1.2.0.0.md

* Update opensearch-alerting.release-notes-1.2.0.0.md

* Add backwards compatibility tests (#199)

* Initial commit for BWC tests

Signed-off-by: Mohammad Qureshi <qreshi@amazon.com>

* Update bwc test to check Monitor stats and add bwc tests to GitHub Actions

Signed-off-by: Mohammad Qureshi <qreshi@amazon.com>

* Use current version plugin bundle from build for bwc tests instead of manually uploading

Signed-off-by: Mohammad Qureshi <qreshi@amazon.com>

* Update mockito-core dependency to 3.12.4 to prevent conflict

Signed-off-by: Mohammad Qureshi <qreshi@amazon.com>

* Remove disabling security manager flag when running BWC tests

Signed-off-by: Mohammad Qureshi <qreshi@amazon.com>

Co-authored-by: Clay Downs <89109232+downsrob@users.noreply.github.com>
Co-authored-by: Abbas Hussain <abbashus@amazon.com>
Co-authored-by: Daniel Doubrovkine (dB.) <dblock@dblock.org>
Co-authored-by: Marc Handalian <handalm@amazon.com>
Co-authored-by: Annie Lee <71157062+leeyun-amzn@users.noreply.github.com>
Co-authored-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>
rishabhmaurya added a commit that referenced this pull request Nov 9, 2021
* Cherry-pick commits to 1.x (#227)

* Update copyright notice (#222)

Signed-off-by: Mohammad Qureshi <qreshi@amazon.com>

* Admin Users must be able to access all monitors #139 (#220)

* Admin Users must be able to access all monitors #139

* Refactored

Co-authored-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>
Co-authored-by: Sriram <59816283+skkosuri-amzn@users.noreply.github.com>

* Updates alerting version to 1.2 (#192)

* Updates alerting version to 1.2

* Adds snapshot repo to the repository file

Signed-off-by: Clay Downs <downsrob@amazon.com>

* Update build to use public Maven repo (#184)

Signed-off-by: Abbas Hussain <abbas_10690@yahoo.com>

* Publish notification JARs checksums. (#196)

* Publish notification JARs checksums.

Signed-off-by: dblock <dblock@dblock.org>

* Remove sonatype staging.

Signed-off-by: dblock <dblock@dblock.org>

* Updates testCompile mockito version to match OpenSearch changes (#204)

Signed-off-by: Clay Downs <downsrob@amazon.com>

* Update maven publication to include cksums. (#224)

This change adds a task to publish to a local staging repo under build/ that includes cksums.  It also updates build.sh to use this new task and copy the contents of the staging repo to the output directory.
The maven publish plugin will not include these cksums when publishing to maven local but will when published to a separate folder.

Signed-off-by: Marc Handalian <handalm@amazon.com>

* Add release notes for 1.2.0.0 release (#225)

* Create opensearch-alerting.release-notes-1.2.0.0.md

Signed-off-by: Annie Lee <leeyun@amazon.com>

* Update opensearch-alerting.release-notes-1.2.0.0.md

* Update opensearch-alerting.release-notes-1.2.0.0.md

* Add backwards compatibility tests (#199)

* Initial commit for BWC tests

Signed-off-by: Mohammad Qureshi <qreshi@amazon.com>

* Update bwc test to check Monitor stats and add bwc tests to GitHub Actions

Signed-off-by: Mohammad Qureshi <qreshi@amazon.com>

* Use current version plugin bundle from build for bwc tests instead of manually uploading

Signed-off-by: Mohammad Qureshi <qreshi@amazon.com>

* Update mockito-core dependency to 3.12.4 to prevent conflict

Signed-off-by: Mohammad Qureshi <qreshi@amazon.com>

* Remove disabling security manager flag when running BWC tests

Signed-off-by: Mohammad Qureshi <qreshi@amazon.com>

Co-authored-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>
Co-authored-by: Sriram <59816283+skkosuri-amzn@users.noreply.github.com>
Co-authored-by: Clay Downs <89109232+downsrob@users.noreply.github.com>
Co-authored-by: Abbas Hussain <abbashus@amazon.com>
Co-authored-by: Daniel Doubrovkine (dB.) <dblock@dblock.org>
Co-authored-by: Marc Handalian <handalm@amazon.com>
Co-authored-by: Annie Lee <71157062+leeyun-amzn@users.noreply.github.com>
AWSHurneyt pushed a commit to AWSHurneyt/OpenSearch-Alerting that referenced this pull request Mar 30, 2022
* Updates alerting version to 1.2 (opensearch-project#192)

* Updates alerting version to 1.2

* Adds snapshot repo to the repository file

Signed-off-by: Clay Downs <downsrob@amazon.com>

* Update build to use public Maven repo (opensearch-project#184)

Signed-off-by: Abbas Hussain <abbas_10690@yahoo.com>

* Publish notification JARs checksums. (opensearch-project#196)

* Publish notification JARs checksums.

Signed-off-by: dblock <dblock@dblock.org>

* Remove sonatype staging.

Signed-off-by: dblock <dblock@dblock.org>

* Updates testCompile mockito version to match OpenSearch changes (opensearch-project#204)

Signed-off-by: Clay Downs <downsrob@amazon.com>

* Update maven publication to include cksums. (opensearch-project#224)

This change adds a task to publish to a local staging repo under build/ that includes cksums.  It also updates build.sh to use this new task and copy the contents of the staging repo to the output directory.
The maven publish plugin will not include these cksums when publishing to maven local but will when published to a separate folder.

Signed-off-by: Marc Handalian <handalm@amazon.com>

* Add release notes for 1.2.0.0 release (opensearch-project#225)

* Create opensearch-alerting.release-notes-1.2.0.0.md

Signed-off-by: Annie Lee <leeyun@amazon.com>

* Update opensearch-alerting.release-notes-1.2.0.0.md

* Update opensearch-alerting.release-notes-1.2.0.0.md

* Add backwards compatibility tests (opensearch-project#199)

* Initial commit for BWC tests

Signed-off-by: Mohammad Qureshi <qreshi@amazon.com>

* Update bwc test to check Monitor stats and add bwc tests to GitHub Actions

Signed-off-by: Mohammad Qureshi <qreshi@amazon.com>

* Use current version plugin bundle from build for bwc tests instead of manually uploading

Signed-off-by: Mohammad Qureshi <qreshi@amazon.com>

* Update mockito-core dependency to 3.12.4 to prevent conflict

Signed-off-by: Mohammad Qureshi <qreshi@amazon.com>

* Remove disabling security manager flag when running BWC tests

Signed-off-by: Mohammad Qureshi <qreshi@amazon.com>

Co-authored-by: Clay Downs <89109232+downsrob@users.noreply.github.com>
Co-authored-by: Abbas Hussain <abbashus@amazon.com>
Co-authored-by: Daniel Doubrovkine (dB.) <dblock@dblock.org>
Co-authored-by: Marc Handalian <handalm@amazon.com>
Co-authored-by: Annie Lee <71157062+leeyun-amzn@users.noreply.github.com>
Co-authored-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Incorrect maven artifacts published
3 participants