Removed log entry regarding destination migration #1356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riysaxen-amzn
requested review from
lezzago,
AWSHurneyt,
sbcd90,
eirsep,
getsaurabh02,
praveensameneni,
qreshi,
bowenlan-amzn and
rishabhmaurya
as code owners
Signed-off-by: Riya Saxena <riysaxen@amazon.com>
riysaxen-amzn
force-pushed
the
fix-pollutingLogEntry
branch
from
921abb8
to
4ed4386
Compare
eirsep
approved these changes
Jan 6, 2024
sbcd90
approved these changes
Jan 8, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 22, 2024
Signed-off-by: Riya Saxena <riysaxen@amazon.com> (cherry picked from commit 48e56bf) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 22, 2024
Signed-off-by: Riya Saxena <riysaxen@amazon.com> (cherry picked from commit 48e56bf) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
riysaxen-amzn
pushed a commit
that referenced
this pull request
Mar 22, 2024
(cherry picked from commit 48e56bf) Signed-off-by: Riya Saxena <riysaxen@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
riysaxen-amzn
pushed a commit
that referenced
this pull request
Mar 22, 2024
(cherry picked from commit 48e56bf) Signed-off-by: Riya Saxena <riysaxen@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
Hi @riysaxen-amzn , instead of the "Detected cluster change event for destination migration!" Logline now for every cluster change event 'Cancelling the migration process.' gets logged. Is it save to extend this else if condition To:
In my understanding only if the runningLock is present a Migration can/should be canceled? best regards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue #1183 *
*There was a specific log that keeps on appearing quite frequently on all OpenSearch clusters (even fresh installations).
[INFO ][o.o.a.u.d.DestinationMigrationCoordinator] [my-node-name] Detected cluster change event for destination migration*CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.