[Backport 2.9] add workflow type field exists check in search monitors action to return both workflows and monitors on search #1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
…urn both workflows and monitors on search (#1026) * add workflow type field exists check in search monitors action to retunr both workflows and monitors on search Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * remove .get() invocation on future and replace with suspendUntil call for search Associated monitors Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * add workflowIds param in rest get alerts action Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> --------- Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> (cherry picked from commit 064e5f5)
Codecov Report
@@ Coverage Diff @@
## 2.9 #1027 +/- ##
============================================
+ Coverage 72.69% 72.80% +0.11%
Complexity 119 119
============================================
Files 160 160
Lines 10441 10448 +7
Branches 1572 1572
============================================
+ Hits 7590 7607 +17
+ Misses 1961 1952 -9
+ Partials 890 889 -1
|
eirsep
approved these changes
Jul 14, 2023
lezzago
approved these changes
Jul 14, 2023
42 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 064e5f5 from #1026