Fix monitor parse and alerts table #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
lezzago
requested review from
AWSHurneyt,
amsiglan,
sbcd90,
eirsep,
getsaurabh02,
praveensameneni,
qreshi,
bowenlan-amzn and
rishabhmaurya
as code owners
getsaurabh02
approved these changes
Jul 14, 2023
eirsep
approved these changes
Jul 14, 2023
ohltyler
reviewed
Jul 15, 2023
| @@ -22,7 +22,7 @@ const getMonitors = async (params) => { | |||
|
|
|||
| const parseMonitor = (monitor) => { | |||
| const state = monitor.monitor.enabled ? 'enabled' : 'disabled'; | |||
| const latestAlert = monitor.latestAlert === "--" ? undefined : monitor.latestAlert; | |||
There was a problem hiding this comment.
is there tests for parseMonitor? At least should be one added for this scenario
There was a problem hiding this comment.
Will follow up on tests and will create a tracking issue.
Codecov Report
@@ Coverage Diff @@
## main #645 +/- ##
=======================================
Coverage 49.99% 49.99%
=======================================
Files 231 231
Lines 6509 6509
Branches 927 927
=======================================
Hits 3254 3254
Misses 3252 3252
Partials 3 3 |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 15, 2023
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> (cherry picked from commit 6972667)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 15, 2023
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> (cherry picked from commit 6972667)
lezzago
added a commit
that referenced
this pull request
Jul 15, 2023
lezzago
added a commit
that referenced
this pull request
Jul 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix retrieving the correct latest alert time for the Alerts on Dashboards visualization feature.
Fix showing the alerts table on monitor details page. The issue was introduced in #611
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.