-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated cypress test based on text changes. #630
Merged
eirsep
merged 9 commits into
opensearch-project:main
from
AWSHurneyt:main_cluster_metrics_enh
Jul 13, 2023
Merged
Updated cypress test based on text changes. #630
eirsep
merged 9 commits into
opensearch-project:main
from
AWSHurneyt:main_cluster_metrics_enh
Jul 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ces, and cat/shards API. Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #630 +/- ##
=======================================
Coverage 49.96% 49.96%
=======================================
Files 231 231
Lines 6506 6506
Branches 927 927
=======================================
Hits 3251 3251
Misses 3252 3252
Partials 3 3 |
The updated test passes locally. Unsure why the entire cypress workflow is failing, but it may be related to the building of the 2.9 RC artifacts. |
eirsep
previously approved these changes
Jul 13, 2023
lezzago
previously approved these changes
Jul 13, 2023
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
AWSHurneyt
requested review from
amsiglan,
sbcd90,
getsaurabh02,
praveensameneni,
qreshi,
bowenlan-amzn and
rishabhmaurya
as code owners
July 13, 2023 00:31
This was referenced Jul 13, 2023
bowenlan-amzn
approved these changes
Jul 13, 2023
lezzago
approved these changes
Jul 13, 2023
eirsep
approved these changes
Jul 13, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 13, 2023
* Added support for creating cluster metrics monitors with the cat/indices, and cat/shards API. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated snapshots. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated snapshots. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed import. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Adjusted label text. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated cypress test based on text changes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Made all click() calls forced. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Adjusted check for the monitor creation button. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> (cherry picked from commit 0e73fba)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 13, 2023
* Added support for creating cluster metrics monitors with the cat/indices, and cat/shards API. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated snapshots. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated snapshots. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed import. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Adjusted label text. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated cypress test based on text changes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Made all click() calls forced. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Adjusted check for the monitor creation button. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> (cherry picked from commit 0e73fba)
AWSHurneyt
added a commit
that referenced
this pull request
Jul 13, 2023
* Added support for creating cluster metrics monitors with the cat/indices, and cat/shards API. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated snapshots. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated snapshots. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed import. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Adjusted label text. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated cypress test based on text changes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Made all click() calls forced. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Adjusted check for the monitor creation button. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> (cherry picked from commit 0e73fba) Co-authored-by: AWSHurneyt <hurneyt@amazon.com>
AWSHurneyt
added a commit
that referenced
this pull request
Jul 13, 2023
* Added support for creating cluster metrics monitors with the cat/indices, and cat/shards API. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated snapshots. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated snapshots. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed import. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Adjusted label text. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated cypress test based on text changes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Made all click() calls forced. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Adjusted check for the monitor creation button. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> (cherry picked from commit 0e73fba) Co-authored-by: AWSHurneyt <hurneyt@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated cypress test based on text changes.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.