Implemented support for configuring a cluster metrics monitor to call cat/indices, and cat/shards. #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ces, and cat/shards API. Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
AWSHurneyt
requested review from
lezzago,
amsiglan,
sbcd90,
eirsep,
getsaurabh02,
praveensameneni,
qreshi,
bowenlan-amzn and
rishabhmaurya
as code owners
Codecov Report
@@ Coverage Diff @@
## main #609 +/- ##
==========================================
- Coverage 51.97% 51.94% -0.04%
==========================================
Files 220 220
Lines 5866 5870 +4
Branches 847 849 +2
==========================================
Hits 3049 3049
- Misses 2814 2818 +4
Partials 3 3 |
|
The cypress test workflow is failing in this PR because it depends on the changes in PR opensearch-project/alerting#992. Manual testing suggests the changes are working as intended. |
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
bowenlan-amzn
previously approved these changes
Jul 11, 2023
...pages/CreateMonitor/components/ClusterMetricsMonitor/utils/clusterMetricsMonitorConstants.js
Outdated
Show resolved
Hide resolved
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
lezzago
approved these changes
Jul 11, 2023
amsiglan
reviewed
Jul 12, 2023
...pages/CreateMonitor/components/ClusterMetricsMonitor/utils/clusterMetricsMonitorConstants.js
Show resolved
Hide resolved
amsiglan
approved these changes
Jul 12, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 12, 2023
… cat/indices, and cat/shards. (#609) * Added support for creating cluster metrics monitors with the cat/indices, and cat/shards API. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated snapshots. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated snapshots. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed import. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Adjusted label text. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> (cherry picked from commit e84dfcd)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 12, 2023
… cat/indices, and cat/shards. (#609) * Added support for creating cluster metrics monitors with the cat/indices, and cat/shards API. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated snapshots. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated snapshots. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed import. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Adjusted label text. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> (cherry picked from commit e84dfcd)
AWSHurneyt
added a commit
that referenced
this pull request
Jul 12, 2023
… cat/indices, and cat/shards. (#609) (#616) * Added support for creating cluster metrics monitors with the cat/indices, and cat/shards API. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated snapshots. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated snapshots. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed import. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Adjusted label text. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> (cherry picked from commit e84dfcd) Co-authored-by: AWSHurneyt <hurneyt@amazon.com>
AWSHurneyt
added a commit
that referenced
this pull request
Jul 12, 2023
… cat/indices, and cat/shards. (#609) (#617) * Added support for creating cluster metrics monitors with the cat/indices, and cat/shards API. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated snapshots. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated snapshots. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed import. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Adjusted label text. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> (cherry picked from commit e84dfcd) Co-authored-by: AWSHurneyt <hurneyt@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented support for configuring a cluster metrics monitor to call cat/indices, and cat/shards.
Documentation issue opensearch-project/documentation-website#4437
Issues Resolved
opensearch-project/alerting#611
Screenshots
Indicesand `Shards options appear in API selection dropdown.Users can preview the response for
IndicesAPI. They can also, optionally, provide path parameters.Users can preview the response for
ShardsAPI. They can also, optionally, provide path parameters.An example trigger condition for the
IndicesAPI.An example trigger condition for the
ShardsAPI.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.