Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDS Bug fix when configuring a Trigger Action in Create Monitor #1127

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

riysaxen-amzn
Copy link
Collaborator

Description

  • It fixes the disabled Managed Channels issue when Configuring a trigger Action while Creating a monitor from Alerts Page.

Issues Resolved

recording-alerting.mov

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Riya Saxena <riysaxen@amazon.com>
Signed-off-by: Riya Saxena <riysaxen@amazon.com>
@AWSHurneyt
Copy link
Collaborator

Manual backport of PR #1128

Copy link
Member

@lezzago lezzago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend adding tests for this

@AWSHurneyt AWSHurneyt merged commit abd7944 into opensearch-project:2.17 Oct 17, 2024
3 of 4 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 17, 2024
* bug fix so that managed channels could be enabled

Signed-off-by: Riya Saxena <riysaxen@amazon.com>

* bug fix so that managed channels could be enabled

Signed-off-by: Riya Saxena <riysaxen@amazon.com>

---------

Signed-off-by: Riya Saxena <riysaxen@amazon.com>
(cherry picked from commit abd7944)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt pushed a commit that referenced this pull request Oct 25, 2024
… (#1129)

* bug fix so that managed channels could be enabled



* bug fix so that managed channels could be enabled



---------


(cherry picked from commit abd7944)

Signed-off-by: Riya Saxena <riysaxen@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants