[Backport 2.17] Fit and Finish UX changes Pt 2 (#1099) #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove truncated monitor name Signed-off-by: Joanne Wang <jowg@amazon.com> * wip Signed-off-by: Joanne Wang <jowg@amazon.com> * fix alerts not showing up when no datasource id Signed-off-by: Joanne Wang <jowg@amazon.com> * fix url for composite monitors Signed-off-by: Joanne Wang <jowg@amazon.com> * check if datasource is enabled Signed-off-by: Joanne Wang <jowg@amazon.com> * fix overflow monitor name Signed-off-by: Joanne Wang <jowg@amazon.com> * make monitor name truncated dynamically Signed-off-by: Joanne Wang <jowg@amazon.com> * change mounting point id and fix sizing Signed-off-by: Joanne Wang <jowg@amazon.com> --------- Signed-off-by: Joanne Wang <jowg@amazon.com>
jowg-amazon
changed the title
AWSHurneyt
approved these changes
Sep 23, 2024
riysaxen-amzn
approved these changes
Sep 24, 2024
5 tasks
jowg-amazon
added a commit
to jowg-amazon/alerting-dashboards-plugin
that referenced
this pull request
Sep 24, 2024
5 tasks
jowg-amazon
added a commit
to jowg-amazon/alerting-dashboards-plugin
that referenced
this pull request
Sep 24, 2024
…nsearch-project#1107)" This reverts commit bfb0d79. Signed-off-by: Joanne Wang <jowg@amazon.com>
AWSHurneyt
pushed a commit
that referenced
this pull request
Sep 24, 2024
* Revert "Fit and Finish UX changes Pt 2 (#1099) (#1107)" This reverts commit bfb0d79. Signed-off-by: Joanne Wang <jowg@amazon.com> * Revert "Fit and Finish UX Fixes (#1092) (#1094)" This reverts commit 51d2c95. Signed-off-by: Joanne Wang <jowg@amazon.com> --------- Signed-off-by: Joanne Wang <jowg@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Manual backport of 42ee4fe from #1099.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.