[Backport 2.17] Fit and Finish UX Fixes #1095
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove horizontal line below search bar Signed-off-by: Joanne Wang <jowg@amazon.com> * space between header and panel 16px and space around table 16px Signed-off-by: Joanne Wang <jowg@amazon.com> * fix 16px around table and search bar Signed-off-by: Joanne Wang <jowg@amazon.com> * remove pagination from top of table Signed-off-by: Joanne Wang <jowg@amazon.com> * add button to create monitor Signed-off-by: Joanne Wang <jowg@amazon.com> * add tooltip to delete Signed-off-by: Joanne Wang <jowg@amazon.com> * remove space on trash icon Signed-off-by: Joanne Wang <jowg@amazon.com> * fix gutter size Signed-off-by: Joanne Wang <jowg@amazon.com> * move edit under actions Signed-off-by: Joanne Wang <jowg@amazon.com> * fix notifications breadcrumb redirect Signed-off-by: Joanne Wang <jowg@amazon.com> * spacing from title to panel 16 for view monitor Signed-off-by: Joanne Wang <jowg@amazon.com> * fix some padding and remove horiz rule for findings section Signed-off-by: Joanne Wang <jowg@amazon.com> * change update monitor to edit monitor Signed-off-by: Joanne Wang <jowg@amazon.com> * change update to save and fix padding for create monitor Signed-off-by: Joanne Wang <jowg@amazon.com> * change monitor details padding and fix link to new page in alerts card Signed-off-by: Joanne Wang <jowg@amazon.com> * remove boarder when empty state Signed-off-by: Joanne Wang <jowg@amazon.com> * fix search bar spacing above Signed-off-by: Joanne Wang <jowg@amazon.com> * make create and edit monitor panels 16px padding Signed-off-by: Joanne Wang <jowg@amazon.com> * rename Signed-off-by: Joanne Wang <jowg@amazon.com> * fix original tabs Signed-off-by: Joanne Wang <jowg@amazon.com> * fix spacing on original monitor page Signed-off-by: Joanne Wang <jowg@amazon.com> * add pagination back to the alerts page Signed-off-by: Joanne Wang <jowg@amazon.com> * fix spacing for alerts dashboard flyout Signed-off-by: Joanne Wang <jowg@amazon.com> * cleanup Signed-off-by: Joanne Wang <jowg@amazon.com> * fix unit tests and run yarn test:jest -u Signed-off-by: Joanne Wang <jowg@amazon.com> * fix cypress tests Signed-off-by: Joanne Wang <jowg@amazon.com> --------- Signed-off-by: Joanne Wang <jowg@amazon.com>
|
|
AWSHurneyt
approved these changes
Sep 17, 2024
|
Closing in favor of #1094 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 4a2b603 from #1092.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.