[FEATURE] Validate trigger names and ensure there are no duplicate names in the same monitor #671
Labels
Comments
|
i will work on this issue |
5 tasks
lezzago
pushed a commit
that referenced
this issue
Nov 27, 2023
AWSHurneyt
pushed a commit
to AWSHurneyt/alerting-dashboards-plugin
that referenced
this issue
Feb 5, 2024
…project#794) Signed-off-by: Chenxi Wang <wangchenxi.us@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
amsiglan
added a commit
that referenced
this issue
Feb 6, 2024
* Support any channel types from Notification (#743) * Support any channel types from Notification Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * Remove unused CHANNEL_TYPES constant Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * Return empty array if failed to get features Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> --------- Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Drafted 2.11 release notes. (#764) * Drafted 2.11 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Drafted 2.11 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Removed "last updated by" sections from the UI. (#767) * Removed "last updated by" section from the UI as the SearchMonitor API can no longer return that info. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated cypress workflow. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Onboard Jenkins prod docker image to github actions (#789) * Onboard Jenkins prod docker image to github actions Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Small typos Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add back workflows Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Restore macos/windows Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> --------- Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Bumped babel version. (#821) * Bumped babel version. Adjusted babel config. Refactored unit test that started failing after bump. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated yarn file. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fix fetching of channels for composite monitors (#820) * fixed incorrect use of this.props Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * resolved dependency conflict Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated babel config Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added 2.11.1 release notes. (#828) * Amended 2.11.0 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added 2.11.1 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added 2.11.1 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added 2.11.1 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added 2.11.1 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed bucket monitor groupBy/aggregation display bug. (#827) * Fixed a bug that was causing groupBy/aggregation fields from displaying in various areas of the UI. Related issues: 816, 817, 818. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed trigger context object bug in issue 791. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Capitalized bucket column titles, and moved bucket columns to the end of the column array. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added wait steps to reduce test flakiness. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added wait step to reduce test flakiness. Adjusted test monitor trigger condition to always triggers on a healthy clusters. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Removed unused imports. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * fixed bucket level monitor flaky cypress test Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Issue #671 fix trigger name validation (#794) Signed-off-by: Chenxi Wang <wangchenxi.us@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Remove integtest.sh since it is not being used (#849) Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * do not create Message component on every text change (#854) Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Implemented server API call to feature backend API. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Implemented remote cluster support for creating/editing query, bucket, and cluster metrics monitors. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Implemented warning model when monitor execution time exceeds a certain value. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated alert details flyout to show remote cluster info. Updated monitor details page to show data sources. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated unit tests. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added experimental banner. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated snapshots. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Edited text on the experimental banner. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Moved getSettings call to hide Data source panel for cluster metrics monitors when remote monitoring is disabled. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated snapshots. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Increased cypress test timeout. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: Chenxi Wang <wangchenxi.us@gmail.com> Signed-off-by: Derek Ho <dxho@amazon.com> Co-authored-by: Ashish Agrawal <ashisagr@amazon.com> Co-authored-by: Peter Zhu <zhujiaxi@amazon.com> Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Co-authored-by: Chenxi Wang <56898616+wang-chenxi@users.noreply.github.com> Co-authored-by: Derek Ho <derek01778@gmail.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this issue
Feb 6, 2024
* Support any channel types from Notification (#743) * Support any channel types from Notification Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * Remove unused CHANNEL_TYPES constant Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * Return empty array if failed to get features Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> --------- Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Drafted 2.11 release notes. (#764) * Drafted 2.11 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Drafted 2.11 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Removed "last updated by" sections from the UI. (#767) * Removed "last updated by" section from the UI as the SearchMonitor API can no longer return that info. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated cypress workflow. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Onboard Jenkins prod docker image to github actions (#789) * Onboard Jenkins prod docker image to github actions Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Small typos Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add back workflows Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Restore macos/windows Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> --------- Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Bumped babel version. (#821) * Bumped babel version. Adjusted babel config. Refactored unit test that started failing after bump. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated yarn file. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fix fetching of channels for composite monitors (#820) * fixed incorrect use of this.props Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * resolved dependency conflict Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated babel config Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added 2.11.1 release notes. (#828) * Amended 2.11.0 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added 2.11.1 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added 2.11.1 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added 2.11.1 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added 2.11.1 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed bucket monitor groupBy/aggregation display bug. (#827) * Fixed a bug that was causing groupBy/aggregation fields from displaying in various areas of the UI. Related issues: 816, 817, 818. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed trigger context object bug in issue 791. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Capitalized bucket column titles, and moved bucket columns to the end of the column array. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added wait steps to reduce test flakiness. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added wait step to reduce test flakiness. Adjusted test monitor trigger condition to always triggers on a healthy clusters. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Removed unused imports. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * fixed bucket level monitor flaky cypress test Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Issue #671 fix trigger name validation (#794) Signed-off-by: Chenxi Wang <wangchenxi.us@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Remove integtest.sh since it is not being used (#849) Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * do not create Message component on every text change (#854) Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Implemented server API call to feature backend API. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Implemented remote cluster support for creating/editing query, bucket, and cluster metrics monitors. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Implemented warning model when monitor execution time exceeds a certain value. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated alert details flyout to show remote cluster info. Updated monitor details page to show data sources. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated unit tests. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added experimental banner. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated snapshots. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Edited text on the experimental banner. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Moved getSettings call to hide Data source panel for cluster metrics monitors when remote monitoring is disabled. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated snapshots. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Increased cypress test timeout. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: Chenxi Wang <wangchenxi.us@gmail.com> Signed-off-by: Derek Ho <dxho@amazon.com> Co-authored-by: Ashish Agrawal <ashisagr@amazon.com> Co-authored-by: Peter Zhu <zhujiaxi@amazon.com> Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Co-authored-by: Chenxi Wang <56898616+wang-chenxi@users.noreply.github.com> Co-authored-by: Derek Ho <derek01778@gmail.com> (cherry picked from commit fb82368) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt
pushed a commit
that referenced
this issue
Feb 6, 2024
* Support any channel types from Notification (#743) * Support any channel types from Notification * Remove unused CHANNEL_TYPES constant * Return empty array if failed to get features --------- * Drafted 2.11 release notes. (#764) * Drafted 2.11 release notes. * Drafted 2.11 release notes. --------- * Removed "last updated by" sections from the UI. (#767) * Removed "last updated by" section from the UI as the SearchMonitor API can no longer return that info. * Updated cypress workflow. --------- * Onboard Jenkins prod docker image to github actions (#789) * Onboard Jenkins prod docker image to github actions * Small typos * Add back workflows * Restore macos/windows --------- * Bumped babel version. (#821) * Bumped babel version. Adjusted babel config. Refactored unit test that started failing after bump. * Updated yarn file. --------- * Fix fetching of channels for composite monitors (#820) * fixed incorrect use of this.props * resolved dependency conflict * updated babel config --------- * Added 2.11.1 release notes. (#828) * Amended 2.11.0 release notes. * Added 2.11.1 release notes. * Added 2.11.1 release notes. * Added 2.11.1 release notes. * Added 2.11.1 release notes. --------- * Fixed bucket monitor groupBy/aggregation display bug. (#827) * Fixed a bug that was causing groupBy/aggregation fields from displaying in various areas of the UI. Related issues: 816, 817, 818. * Fixed trigger context object bug in issue 791. * Capitalized bucket column titles, and moved bucket columns to the end of the column array. * Added wait steps to reduce test flakiness. * Added wait step to reduce test flakiness. Adjusted test monitor trigger condition to always triggers on a healthy clusters. * Removed unused imports. * fixed bucket level monitor flaky cypress test --------- * Issue #671 fix trigger name validation (#794) * Remove integtest.sh since it is not being used (#849) * do not create Message component on every text change (#854) * Implemented server API call to feature backend API. * Implemented remote cluster support for creating/editing query, bucket, and cluster metrics monitors. * Implemented warning model when monitor execution time exceeds a certain value. * Updated alert details flyout to show remote cluster info. Updated monitor details page to show data sources. * Updated unit tests. * Added experimental banner. * Updated snapshots. * Edited text on the experimental banner. * Moved getSettings call to hide Data source panel for cluster metrics monitors when remote monitoring is disabled. * Updated snapshots. * Increased cypress test timeout. --------- (cherry picked from commit fb82368) Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: Chenxi Wang <wangchenxi.us@gmail.com> Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Ashish Agrawal <ashisagr@amazon.com> Co-authored-by: Peter Zhu <zhujiaxi@amazon.com> Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Co-authored-by: Chenxi Wang <56898616+wang-chenxi@users.noreply.github.com> Co-authored-by: Derek Ho <derek01778@gmail.com>
smuthukaruppannp
pushed a commit
to smuthukaruppannp/alerting-dashboards-plugin
that referenced
this issue
Feb 7, 2024
…project#794) Signed-off-by: Chenxi Wang <wangchenxi.us@gmail.com>
amsiglan
pushed a commit
that referenced
this issue
Sep 4, 2024
(cherry picked from commit 83a2b3e) Signed-off-by: Chenxi Wang <wangchenxi.us@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt
pushed a commit
that referenced
this issue
Sep 4, 2024
(cherry picked from commit 83a2b3e) Signed-off-by: Chenxi Wang <wangchenxi.us@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem?
Trigger names are not validated to see if there are other triggers in the same monitor with the same name
What solution would you like?
Prevent monitors from being created where the monitor have triggers with the same name
The text was updated successfully, but these errors were encountered: