Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing javadoc error #9976

Merged
merged 15 commits into from
Sep 14, 2023
Merged

Fixing javadoc error #9976

merged 15 commits into from
Sep 14, 2023

Conversation

ker2x
Copy link
Contributor

@ker2x ker2x commented Sep 11, 2023

Friendly greetings !

i wrote more javadoc and fixed some mistake from the previous PR.
I ran gradle precommit and check

There are some errors unrelated to my commits

meta ticket #221

PS : signoff should be ok this time

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

fixing javadoc error and warning
javadoc for org.opensearch.core.indices.breaker
javadoc for org.opensearch.core.index.shard.ShardId
javadoc for org.opensearch.core.index.Index
fixing a mishap in formatting rule
fixing javadoc of org.opensearch.cli.Terminal

Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Sep 11, 2023

Compatibility status:

Checks if related components are compatible with change 5fc2973

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@reta
Copy link
Collaborator

reta commented Sep 11, 2023

  • RESULT: FAILURE ❌

@ker2x there javadoc issues:

* What went wrong:
Execution failed for task ':libs:opensearch-core:javadoc'.
> Javadoc generation failed. Generated Javadoc options file (useful for troubleshooting): '/var/jenkins/workspace/gradle-check/search/libs/core/build/tmp/javadoc/javadoc.options'

@reta
Copy link
Collaborator

reta commented Sep 12, 2023

one of your fix that i approved (by mistake, i didn't see the extra line in the diff) generated an error. i pushed a fix

Thank you, apologies for messing it up

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@msfroh
Copy link
Collaborator

msfroh commented Sep 13, 2023

Gradle checks may keep failing until the PR is rebased to the latest main.

See #10032 for some details. Essentially, I think the checks will keep failing on the same test until the PR branch picks up 91821c7.

@reta
Copy link
Collaborator

reta commented Sep 13, 2023

Gradle checks may keep failing until the PR is rebased to the latest main.

See #10032 for some details. Essentially, I think the checks will keep failing on the same test until the PR branch picks up 91821c7.

Thanks @kotwanikunal , all kinds of issues, including

* What went wrong:
Execution failed for task ':test:fixtures:gcs-fixture:composeBuild'.
> Exit-code 1 when calling /usr/bin/docker-compose, stdout: Step 1/11 : FROM ubuntu:18.04

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

ker2x and others added 2 commits September 14, 2023 17:54
Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>
Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteStoreStatsIT.testStatsResponseFromLocalNode
      1 org.opensearch.remotestore.RemoteStoreStatsIT.testStatsResponseAllShards

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@reta reta merged commit 71f6136 into opensearch-project:main Sep 14, 2023
12 of 13 checks passed
@reta reta added the backport 2.x Backport to 2.x branch label Sep 14, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 14, 2023
* Fixing javadoc error
fixing javadoc error and warning
javadoc for org.opensearch.core.indices.breaker
javadoc for org.opensearch.core.index.shard.ShardId
javadoc for org.opensearch.core.index.Index
fixing a mishap in formatting rule
fixing javadoc of org.opensearch.cli.Terminal

Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* removing unsupported @ImplNote

Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* Update libs/common/src/main/java/org/opensearch/common/collect/Iterators.java

Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* Update libs/compress/src/main/java/org/opensearch/compress/ZstdCompressor.java

Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* Apply suggestions from code review

Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* Apply suggestions from code review

Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* Apply suggestions from code review

Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* Apply suggestions from code review

Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* Update CollectionUtils.java

Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* fixing javadoc warnings

Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* remove useless p tag

Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* removing a p tag

Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* proper capitalization

Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

---------

Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>
Co-authored-by: Andriy Redko <drreta@gmail.com>
(cherry picked from commit 71f6136)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta added a commit that referenced this pull request Sep 14, 2023
* Fixing javadoc error
fixing javadoc error and warning
javadoc for org.opensearch.core.indices.breaker
javadoc for org.opensearch.core.index.shard.ShardId
javadoc for org.opensearch.core.index.Index
fixing a mishap in formatting rule
fixing javadoc of org.opensearch.cli.Terminal



* removing unsupported @ImplNote



* Update libs/common/src/main/java/org/opensearch/common/collect/Iterators.java




* Update libs/compress/src/main/java/org/opensearch/compress/ZstdCompressor.java




* Apply suggestions from code review




* Apply suggestions from code review




* Apply suggestions from code review




* Apply suggestions from code review




* Update CollectionUtils.java



* fixing javadoc warnings



* remove useless p tag



* removing a p tag




* proper capitalization




---------



(cherry picked from commit 71f6136)

Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Andriy Redko <drreta@gmail.com>
sarthakaggarwal97 pushed a commit to sarthakaggarwal97/OpenSearch that referenced this pull request Sep 20, 2023
* Fixing javadoc error
fixing javadoc error and warning
javadoc for org.opensearch.core.indices.breaker
javadoc for org.opensearch.core.index.shard.ShardId
javadoc for org.opensearch.core.index.Index
fixing a mishap in formatting rule
fixing javadoc of org.opensearch.cli.Terminal

Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* removing unsupported @ImplNote

Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* Update libs/common/src/main/java/org/opensearch/common/collect/Iterators.java

Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* Update libs/compress/src/main/java/org/opensearch/compress/ZstdCompressor.java

Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* Apply suggestions from code review

Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* Apply suggestions from code review

Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* Apply suggestions from code review

Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* Apply suggestions from code review

Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* Update CollectionUtils.java

Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* fixing javadoc warnings

Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* remove useless p tag

Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* removing a p tag

Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* proper capitalization

Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

---------

Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>
Co-authored-by: Andriy Redko <drreta@gmail.com>
brusic pushed a commit to brusic/OpenSearch that referenced this pull request Sep 25, 2023
* Fixing javadoc error
fixing javadoc error and warning
javadoc for org.opensearch.core.indices.breaker
javadoc for org.opensearch.core.index.shard.ShardId
javadoc for org.opensearch.core.index.Index
fixing a mishap in formatting rule
fixing javadoc of org.opensearch.cli.Terminal

Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* removing unsupported @ImplNote

Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* Update libs/common/src/main/java/org/opensearch/common/collect/Iterators.java

Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* Update libs/compress/src/main/java/org/opensearch/compress/ZstdCompressor.java

Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* Apply suggestions from code review

Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* Apply suggestions from code review

Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* Apply suggestions from code review

Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* Apply suggestions from code review

Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* Update CollectionUtils.java

Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* fixing javadoc warnings

Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* remove useless p tag

Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* removing a p tag

Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* proper capitalization

Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

---------

Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>
Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
vikasvb90 pushed a commit to vikasvb90/OpenSearch that referenced this pull request Oct 10, 2023
* Fixing javadoc error
fixing javadoc error and warning
javadoc for org.opensearch.core.indices.breaker
javadoc for org.opensearch.core.index.shard.ShardId
javadoc for org.opensearch.core.index.Index
fixing a mishap in formatting rule
fixing javadoc of org.opensearch.cli.Terminal

Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* removing unsupported @ImplNote

Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* Update libs/common/src/main/java/org/opensearch/common/collect/Iterators.java

Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* Update libs/compress/src/main/java/org/opensearch/compress/ZstdCompressor.java

Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* Apply suggestions from code review

Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* Apply suggestions from code review

Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* Apply suggestions from code review

Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* Apply suggestions from code review

Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* Update CollectionUtils.java

Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* fixing javadoc warnings

Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* remove useless p tag

Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* removing a p tag

Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* proper capitalization

Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

---------

Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>
Co-authored-by: Andriy Redko <drreta@gmail.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
* Fixing javadoc error
fixing javadoc error and warning
javadoc for org.opensearch.core.indices.breaker
javadoc for org.opensearch.core.index.shard.ShardId
javadoc for org.opensearch.core.index.Index
fixing a mishap in formatting rule
fixing javadoc of org.opensearch.cli.Terminal

Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* removing unsupported @ImplNote

Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* Update libs/common/src/main/java/org/opensearch/common/collect/Iterators.java

Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* Update libs/compress/src/main/java/org/opensearch/compress/ZstdCompressor.java

Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* Apply suggestions from code review

Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* Apply suggestions from code review

Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* Apply suggestions from code review

Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* Apply suggestions from code review

Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* Update CollectionUtils.java

Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* fixing javadoc warnings

Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* remove useless p tag

Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* removing a p tag

Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

* proper capitalization

Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>

---------

Signed-off-by: Laurent Laborde <kerdezixe@gmail.com>
Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants